Verification levels must be between 0 and 4 inclusive, and block heights should
always be positive. While code in the scan process handles the latter case with
a default value, it's better to verify and reject invalid input where it first
enters the system.
- improves conciseness of tips displayed in Qt
- makes the function of the reset button on the importkeydialog
describe reality
- describe alertnotify to match the new reality after 565280f4
- make sure that "koinu" is not expressed as "koinus"
- fix type in advanced send screen
This adds more defensiveness around dumping or backing up wallets, so
that the directory and filepaths are always available (even if they were
on transient storage that was removed), and that they never overwrite
other files.
This allows users to set the directory in which to store backups and
datadumps. If not provided, defaults to a subdirectory of `datadir`
called `backups/`, and if that cannot be created, defaults to `datadir`.
It was noted that there is no clear documentation of which protocol
features are available for Dogecoin. This document fulfills that
function, but hasn't been maintained thus far.
This PR changes the document to list all the BIPs implemented and
activated by Dogecoin Core until v1.14.6, and adds protocol
features from other code bases we have adopted.
Tests that depend on enable_mocktime() because they use the cached
chain are testing things that need actual time. Because we're
mocking time more often when we are processing messages, these
tests fail (because to the node, no time expires)
This rewrites these tests to no longer use the cached chain.
Tests affected:
- listtransactions.py
- receivedby.py
While looking at the network code, we realized this code is unused and
largely unmaintained. Given issue #2231, and its removal in 1.21, it's
time to remove it now.
This has the nice benefit of removing a single point of failure/control
(because it depends on a keypair to send alerts).
This code restores the pre-alert behavior before the merge of PR #1470.
See #2523, a request not to drop data when changing the time scale of
the graph.
This change includes several components performed by @michilumin:
* allows resampling and data retention
* separates data from visual sample stores on the graph
* uses averages instead of maximums for samples
* improves timing accuracy
Co-authored-by: Michi Lumin <michi@luskwood.org>
Throughout the code, we use mockable time in places where we want
to test things that are subject to timing constraints, but don't
want to wait for great amounts of time when we use the regtest
network to ensure nothing gets broken. Mockable time is a system
time override that is only enabled on chains that have the
fMineBlocksOnDemand parameter set (currently: regtest).
Currently, only time expressed in seconds is able to be mocked, but
we have a couple of places where time is evaluated in microseconds,
one of them being the time between sending out addr messages.
This introduces a mockable time in microseconds and refactors the
time evaluation for addr messages to be mocked, so that we can
more reliably (and faster) test that.
Other protocol features may want to use this too, but currently the
sending of addr messages is the only place we test. Bitcoin Core
nowadays has a much better time system that we inherit in future
versions, but for the current scope I found this not worth the
effort of backporting, as these would impact a much larger part of
the code base.
Inspired by: 1a8f0d5a from Amiti Uttarwar
- explain apt-cacher post-installation tasks
- change doc example to 1.14.5 because 1.14.4 expects trusty
- remove pressure on bitcoincore.org by downloading files from
dogecoincore.org
Adds the time field to addr messages from protocol version 31402,
but serialize/deserialize without it for version messages. This
allows us to test p2p addr messages.
See src/version.h and c891967b
After a bionic update on 2022/06/03, Github Actions images have a
mono-runtime installation that takes precedence over wine, which
we need for running the tests.
This removes mono-runtime from both win CI jobs if it exists, so
that it doesn't bother us anymore in any way thinkable. We do not
need mono there, as we do not .net
Although the issue only manifested on x86_64-w64-mingw32 builds,
this also removes it from the i686-w64-mingw32 build as a
precaution.
A fully translated version of README on Brazilian Portuguese. For better assessment and understanding of Dogecoin Core. It should be refered on EN and CH Readme files too.
Describes a pull request process that prevents maintainers from
merging code too quickly, giving contributors a chance to react to
changes and voice concerns before a pull request is merged and
closed. This makes development more transparent and inclusive.
The process prescribes a lag time between maintainer approval and
merge of minimally 24 hours because that creates a workable
balance between maintaining development momentum and transparency.
Maintenance tasks are exempt from the lag time requirement, as are
time-critical fixes.
