14009 Commits

Author SHA1 Message Date
Ross Nicoll
190d48e487
Merge pull request #2757 from patricklodder/1.14.6-uninit-scopeid
net: Ensure every CNetAddr constructor initializes the scopeId field
2021-12-19 11:50:47 +00:00
Ross Nicoll
e4e3371b6f
Merge pull request #2759 from patricklodder/1.14.6-initialize-counters
net: avoid uninitialized reads on counters
2021-12-19 11:36:28 +00:00
Ross Nicoll
b39c06aa90
Merge pull request #2755 from patricklodder/1.14.6-fix-rpc-race
rpc: Fix data race (UB) in InterruptRPC()
2021-12-19 11:30:32 +00:00
Patrick Lodder
39a476dcb2
net: avoid uninitialized reads on counters
Initialize CConnman byte counters during construction, so that
GetTotalBytesRecv() and GetTotalBytesSent() methods don't return
garbage before Start() is called, in QT.

Backported from: 8313fa8e
Original author: Russell Yanofsky <russ@yanofsky.org>
2021-12-17 19:45:45 -04:00
Kaz Wesley
b31dbd9dba
fix uninitialized read when stringifying an addrLocal
Reachable from either place where SetIP is used when our best-guess
addrLocal for a peer is IPv4, but the peer tells us it's reaching us at
an IPv6 address.

In that case, SetIP turns an IPv4 address into an IPv6 address without
setting the scopeId, which is subsequently read in GetSockAddr during
CNetAddr::ToStringIP and passed to getnameinfo. Fix by ensuring every
constructor initializes the scopeId field with something.

Cherry-picked from: b7b36dec
2021-12-17 16:19:41 -04:00
Kaz Wesley
ee4f7fbc13
add test demonstrating addrLocal UB
Cherry-picked from: 8ebbef01

Conflicts: missing MakeUnique, replaced with manual new CNode()
2021-12-17 16:19:07 -04:00
practicalswift
bfdaf2d269
rpc: Fix data race (UB) in InterruptRPC()
Cherry-picked from: 6c10037f7
2021-12-17 15:45:20 -04:00
Michi Lumin
7019ead6a1
Merge pull request #2687 from edtubbs/1.14.6-dev
[feat] Added ARMv8 SHA support
2021-12-11 13:07:22 -07:00
Ed Tubbs
be9df91a4d Updated ARMv8 intrinsics for SHA-512
Updated cross build for ci environment
Updated experimental build to focal
Unified cross and native ARMv8.2 build options
Updated experimental build in ci
2021-12-08 19:24:49 -06:00
Ross Nicoll
2bc100ad10
Merge pull request #2727 from patricklodder/1.14.6-fix-msghdr-warn
backport: Fail instead of truncate command name in CMessageHeader constructor
2021-12-04 07:42:31 +00:00
Patrick Lodder
311b855a12
Merge pull request #2637 from sinetek/newldb
Update leveldb to bitcoin's upstream.
2021-11-29 14:28:50 -05:00
Wladimir J. van der Laan
3fd3563d0a
net: Fail instead of truncate command name in CMessageHeader
Replace the memset/strncpy dance in `CMessageHeader::CMessageHeader`
with explicit code that copies then name and asserts the length.

This removes a warning in g++ 9.1.1 and IMO makes the code more readable
by not relying on strncpy padding and silent truncation behavior.

Cherry-picked from: b837b33
2021-11-29 20:08:15 +01:00
sinetek
fd5798d431 doge: we don't support android, so drop autoconf target. 2021-11-29 18:58:59 +01:00
Wladimir J. van der Laan
87946deb94 build: Update build system for new leveldb
Upstream leveldb switched build systems, which means we need to define
a few different values.
2021-11-29 18:35:38 +01:00
MarcoFalke
752cb6d88d Add extra LevelDB source to Makefile 2021-11-29 18:27:05 +01:00
Chun Kuan Lee
97998bd989 build: Remove WINVER pre define in Makefile.leveldb.inlcude 2021-11-29 18:27:05 +01:00
Wladimir J. van der Laan
fd64777c4f Update to leveldb upstream using subtree merge 2021-11-29 18:27:05 +01:00
MarcoFalke
0b42af2ddb Pull leveldb subtree 2021-11-29 18:27:05 +01:00
MarcoFalke
c7f5171919 Merge leveldb subtree
Merge commit 'ec749b1bcdf2483b642fb51d635800e272c68ba6' into HEAD
2021-11-29 18:27:05 +01:00
MarcoFalke
c217773a6b Bump leveldb subtree 2021-11-29 18:27:05 +01:00
Pieter Wuille
8c4966dd66 Update LevelDB with latest Bitcoin-specific patches 2021-11-29 18:27:05 +01:00
Pieter Wuille
fc11055f0a Update to LevelDB 1.20 2021-11-29 18:27:05 +01:00
Patrick Lodder
f6bbad704f
Merge pull request #2718 from Likenttt/patch-1
fix a grammar problem
2021-11-22 14:33:22 -05:00
Chuanyi
fb2567fc6a
fix a grammar problem
Who own the private keys own the coins. -> Who owns the private keys owns the coins.
2021-11-21 16:55:26 +08:00
Patrick Lodder
fd0798bb16
Merge pull request #2716 from bmwant/master
Fix typo in docs when checking shasum
2021-11-18 13:21:10 -05:00
Misha Behersky
dd0e49bbb7
Fix typo when checking shasum 2021-11-18 20:13:09 +02:00
Ed Tubbs
54d5954761 Added cross and native variables for experimental build
Updated ci
2021-11-17 22:55:59 +00:00
Ed Tubbs
3a7fef10ca Added ARMv8.2 intrinsics for SHA-512
Added build parameter for ARMv8.2
Added experimental ci build
Updated comments
2021-11-17 22:55:59 +00:00
Ross Nicoll
89aeecc0dc
Merge pull request #2660 from patricklodder/1.14.5-exp-ci-bionic
[qa] run the experimental builds on bionic too
2021-11-16 19:26:46 +00:00
Ross Nicoll
4b3e6529e9
Merge pull request #2693 from patricklodder/1.14.6-fix-boost-autoconf
build: change minimum boost to 1_60_0
2021-11-12 00:47:18 +00:00
Ross Nicoll
5449f441df
Merge pull request #2694 from patricklodder/1.14.6-fix-bench
bench: remove erroring components and integrate with CI
2021-11-11 22:19:01 +00:00
Patrick Lodder
543d896a49
Merge pull request #2692 from ayushman17/master
doc: fix capitalization
2021-11-11 15:32:43 -05:00
Patrick Lodder
a9d5a6e343
qa: run benchmark on CI and store with artifact
This makes sure that the benchmarks don't get broken and may
give insights into how improvements impact performance.
2021-11-11 14:02:21 -05:00
Patrick Lodder
d5f19e266b
bench: remove bitcoin-specific benchmarks 2021-11-11 13:22:40 -05:00
Patrick Lodder
bd865b061d
build: remove outdated boost checks now that we require 1_60+ 2021-11-11 10:13:19 -05:00
Ayushman Singh Chauhan
1b95f4980f
Update README.md
docs update => proper capitalisation would be better. 👍
2021-11-11 14:32:27 +05:30
Patrick Lodder
a2587deb83
build: fix minimum boost version for autoconf: 1_60_0 2021-11-10 19:33:44 -05:00
Ed
8400c57d90 Added experimental build to ci environment 2021-11-08 23:08:39 -06:00
Ed Tubbs
2767f3e8a5 Added --with-armv8-crypto to configure.ac
Added ARMv8 SHA1 and SHA256 intrinsics
2021-11-08 23:08:39 -06:00
Patrick Lodder
a834a4b4ae
qa: make experimental build on bionic too
Sets the linux experimental build to bionic, to be in line with the
rest of the CI and not have any unexpected surprises when moving
features from experimental to release.

This was caused by the bionic downgrade for the CI crossing the
introduction of the experimental CI for AVX2.
2021-11-08 21:26:10 +01:00
Ross Nicoll
3b1376906d
Merge pull request #2680 from patricklodder/1.14.6-cfgac-format
trivial: fix spacing issues in configure.ac
2021-11-08 19:21:43 +00:00
Ross Nicoll
23b4850130
Merge pull request #2685 from patricklodder/1.14.6-fix-policy-race
qa: fix race condition in p2p-policy test
2021-11-08 19:20:50 +00:00
Ross Nicoll
ca94ba2246
Merge pull request #2683 from patricklodder/1.14.6-ci-trigger
qa: nuke caches on CI descriptor change
2021-11-08 18:51:17 +00:00
Ross Nicoll
9102581176
Merge pull request #2682 from patricklodder/1.14.6-codeql-scope
qa: fixup codeql path scope
2021-11-08 18:49:28 +00:00
Patrick Lodder
0010eedd12
qa: fix race condition in p2p-policy test
Fixes a race condition in p2p-policy tests by waiting for a reject
message rather than assuming it was received before a pong message
2021-11-08 11:40:41 -05:00
Patrick Lodder
8d6f5166f9
Merge pull request #2684 from AbcSxyZ/abcsxyz-key
gitian: add abcsxyz's pgp public key
2021-11-08 11:38:44 -05:00
Patrick Lodder
93c94f1453
Merge pull request #2678 from xanimo/xanimo-key-add
xanimo key
2021-11-08 11:01:18 -05:00
Patrick Lodder
d52b659385
Merge pull request #2677 from fdoving/fdov-gitan-key
Add fdov's gitian key
2021-11-08 11:01:01 -05:00
AbcSxyZ
72aed2e54b add abcsxyz pgp key 2021-11-08 16:49:59 +01:00
Patrick Lodder
f2a079f571
qa: fixup codeql path scope 2021-11-08 10:01:18 -05:00