cryptogera/dogecoin
1
0
Fork 0
mirror of https://github.com/dogecoin/dogecoin.git synced 2026-02-01 02:50:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

qa: fix race condition in p2p-policy test

Browse Source 
Fixes a race condition in p2p-policy tests by waiting for a reject
message rather than assuming it was received before a pong message
This commit is contained in:
Patrick Lodder 2021-11-08 11:25:17 -05:00
parent 93c94f1453
commit 0010eedd12
No known key found for this signature in database
GPG Key ID: 7C523F5FBABE80E7
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
qa/rpc-tests/p2p-policy.py
View File

@ -37,6 +37,14 @@ class TestNode(NodeConnCB):
def on_reject(self, conn, message):
self.rejects.append(message)
# wait for a rejection message
def wait_for_reject(self, num_rejects=None):
if num_rejects is None:
num_rejects = len(self.rejects)
def reject_received():
return len(self.rejects) > num_rejects
return wait_until(reject_received, timeout=10)
# wait for verack to make sure the node accepts our connection attempt
def wait_for_verack(self):
def veracked():
@ -175,8 +183,8 @@ class P2PPolicyTests(BitcoinTestFramework):
assert_equal(self.recvNode.wait_for_tx_inv(tx.hash), True)
assert_equal(len(self.sendNode.rejects), num_rejects)
else:
# test that there was a rejection received with the correct code
assert_greater_than(len(self.sendNode.rejects), num_rejects)
# wait until there was a rejection received with the correct code
assert_equal(self.sendNode.wait_for_reject(num_rejects), True)
assert_equal(self.sendNode.rejects[-1].code, expected_reject_code)
return tx