cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src/node
History
MacroFake da23320998
Merge bitcoin/bitcoin#25651: refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public, rm temporaries, simplify 
4bedfd702ad878645c51bea6ee8ce40d8c0bd3da refactor: remove unneeded temporaries in node/interfaces, simplify code (Jon Atack)
b27ba169ebd4a8e4ec29be590f03a4d0da61a0cc refactor: make all NodeImpl/ChainImpl/ExternalSignerImpl members public (Jon Atack)

Pull request description:

  - Make all `NodeImpl`, `ChainImpl` and `ExternalSignerImpl` class members `public` (and document why), to be consistent in all the `*Impl` classes in `src/node/interfaces.cpp` and `src/wallet/interfaces.cpp` and to help future reviewers and contributors.

  - Remove unneeded temporaries in `NodeImpl` and `ChainImpl` methods in `src/node/interfaces.cpp` and simplify, to make the code easier to read and understand and to improve performance by avoiding unnecessary move operations.

ACKs for top commit:
  ryanofsky:
    Code review ACK 4bedfd702ad878645c51bea6ee8ce40d8c0bd3da. Changes since last review, applying suggested style & simplifiying first commit. Also avoiding another lock in second commit.

Tree-SHA512: 112f7cad5e2838c94c5b79d61328f42fe75fdb97f401ab49eccf696fc2c6a8a0c0ee55ec974c0602acf7423f78bb82e90eb8a0cc531e1d3347f73b7c83685504
2022-08-01 11:19:55 +02:00
..
blockstorage.cpp
Merge bitcoin/bitcoin#25571: refactor: Make mapBlocksUnknownParent local, and rename it
2022-07-29 15:47:23 +01:00
blockstorage.h
LoadMempool: Pass in load_path, stop using gArgs
2022-07-15 12:26:20 -04:00
caches.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
caches.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
chainstate.cpp
refactor: Fix iwyu on node/chainstate
2022-07-21 20:23:23 +02:00
chainstate.h
refactor: Fix iwyu on node/chainstate
2022-07-21 20:23:23 +02:00
coin.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
coin.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
connection_types.cpp
[net] Move ConnectionType to its own file
2022-07-06 18:13:53 +02:00
connection_types.h
[net] Move ConnectionType to its own file
2022-07-06 18:13:53 +02:00
context.cpp
init: Initialize globals with kernel::Context's life
2022-06-02 11:40:03 -04:00
context.h
kernel: Introduce empty and unused kernel::Context
2022-05-31 14:18:31 -04:00
eviction.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
eviction.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
interface_ui.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
interface_ui.h
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
interfaces.cpp
refactor: remove unneeded temporaries in node/interfaces, simplify code
2022-07-29 19:41:23 +02:00
mempool_persist_args.cpp
DumpMempool: Pass in dump_path, stop using gArgs
2022-07-15 11:30:50 -04:00
mempool_persist_args.h
Move DEFAULT_PERSIST_MEMPOOL out of libbitcoinkernel
2022-07-15 12:26:20 -04:00
miner.cpp
miner: Make mempool optional for BlockAssembler
2022-06-06 15:38:09 -04:00
miner.h
miner: Make mempool optional for BlockAssembler
2022-06-06 15:38:09 -04:00
minisketchwrapper.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
minisketchwrapper.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
psbt.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
psbt.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
README.md
…
transaction.cpp
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
transaction.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
utxo_snapshot.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.