History

Merge #19277 : util: Add Assert identity function

fab80fef61ddd4afeff6e497c7e76bffcd05e8a4 refactor: Remove unused EnsureChainman (MarcoFalke)
fa34587f1c811d99200453b0936219c473f514b0 scripted-diff: Replace EnsureChainman with Assert in unit tests (MarcoFalke)
fa6ef701adba1cb48535cac25fd43c742a82e40d util: Add Assert identity function (MarcoFalke)
fa457fbd3387661e1973a8f4e5cc2def79e0c625 move-only: Move NDEBUG compile time check to util/check (MarcoFalke)

Pull request description:

  The utility function is primarily useful to dereference pointer types, which are known to be not null at that time.

  For example, the ArgsManager is known to exist when the wallets are started: https://github.com/bitcoin/bitcoin/pull/18923/files#diff-fdb2a1a1d8bc790fcddeb6cf5a42ac55R503 . Instead of silently relying on that assumption, `Assert` can be used to abort the program and avoid UB should the assumption ever be violated.

ACKs for top commit:
  promag:
    Tested ACK fab80fef61ddd4afeff6e497c7e76bffcd05e8a4.
  ryanofsky:
    Code review ACK fab80fef61ddd4afeff6e497c7e76bffcd05e8a4

Tree-SHA512: 830fba10152ba17d47c4dd42809c7e26f9fe6d38e17a2d5b3f054fd644a5c4c9841286ac421ec9bb28cea9f5faeb659740fcf00de6cc589d423fee7694c42d16

2020-07-04 08:44:45 -04:00

coin.cpp

node: Use mempool from node context instead of global

2019-12-05 14:22:05 -05:00

coin.h

node: Use mempool from node context instead of global

2019-12-05 14:22:05 -05:00

coinstats.cpp

rpc: Make gettxoutsetinfo/GetUTXOStats interruptible

2020-05-22 15:53:50 -04:00

coinstats.h

rpc: Make gettxoutsetinfo/GetUTXOStats interruptible

2020-05-22 15:53:50 -04:00

context.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

context.h

refactor: Remove unused EnsureChainman

2020-06-15 07:39:35 -04:00

psbt.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

psbt.h

Have a PSBTAnalysis state that indicates invalid PSBT

2019-11-19 14:54:08 -05:00

README.md

…

transaction.cpp

[mempool] Track "unbroadcast" transactions

2020-04-23 14:42:25 -07:00

transaction.h

Merge #17509 : gui: save and load PSBT

2020-04-23 13:16:23 +12:00

ui_interface.cpp

gui: change combiner for signals to optional_last_value

2020-07-01 21:40:51 +08:00

ui_interface.h

scripted-diff: Move ui_interface to the node lib

2020-06-27 11:49:28 -04:00

utxo_snapshot.h

Convert everything except wallet/qt to new serialization

2020-03-30 16:10:30 -07:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.