cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src/node
History
W. J. van der Laan 7f0f853373
Merge bitcoin/bitcoin#23005: multiprocess: Delay wallet client construction 
ad085f9ba15c131fc5cc77086a620f2e366aac7c multiprocess: Delay wallet client construction (Russell Yanofsky)

Pull request description:

  Delay wallet client construction until after logging, thread and other init for two reasons:

  - More responsive multiprocess GUI startup. When bitcoin-gui is started this moves the call from bitcoin-gui to bitcoin-node that spawns bitcoin-wallet off of the GUI event thread and onto the background GUI init executor thread.

  - Avoids feature_logging.py test failures with bitcoin-node by making bitcoin-wallet logging start after bitcoin-node logging starts,
    because the tests are not written to handle the bitcoin-wallet logging init code running first.

  This partially reverts commit b266b3e0bf29d0f3d5deaeec62d57c5025b35525, moving wallet client creation back to the place it was located before.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  laanwj:
    code review ACK ad085f9ba15c131fc5cc77086a620f2e366aac7c
  hebasto:
    ACK ad085f9ba15c131fc5cc77086a620f2e366aac7c, I have reviewed the code and it looks OK.

Tree-SHA512: 74d957ce2ee096db745c517124f60800185814b06c20db676090e10dce1b90311adbab02865a69731f8c39b9365f9ee14be0830ca1368cac9b474801ea92bad5
2021-11-15 18:08:49 +01:00
..
blockstorage.cpp
Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method
2021-10-15 10:01:56 +02:00
blockstorage.h
add missing atomic include
2021-06-22 11:06:30 +02:00
coin.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coinstats.h
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
context.cpp
validation: Farewell, global Chainstate!
2021-06-10 15:05:25 -04:00
context.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
interfaces.cpp
Merge bitcoin/bitcoin#23005: multiprocess: Delay wallet client construction
2021-11-15 18:08:49 +01:00
psbt.cpp
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
transaction.cpp
[refactor] Don't call AcceptToMemoryPool() from outside validation.cpp
2021-11-03 14:34:41 +00:00
transaction.h
refactor: move GetTransaction(...) to node/transaction.cpp
2021-07-22 15:53:17 +02:00
ui_interface.cpp
multiprocess: Delay wallet client construction
2021-09-16 14:17:01 -04:00
ui_interface.h
multiprocess: Delay wallet client construction
2021-09-16 14:17:01 -04:00
utxo_snapshot.h
validation: remove nchaintx from assumeutxo metadata
2021-04-26 13:22:37 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.