mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-17 00:42:45 +00:00
ff7cdf633e
fa90b21430b4f3bae6f4092a27e611bb06f2777f test: Remove unused feature_segwit.py functions (MarcoFalke) fa6b05c96ffb6cef42bf8907759d0d99f97a2e22 test: Remove unused CUSTOM_._COUNT (MarcoFalke) fa7bac94d87a1b25f8b33ebd29ce47bf442f137e test: Remove unused wait_for_addr, firstAddrnServices, on_addr (MarcoFalke) fa388a35855cc53d1a48d464c1bdcf793a0e2968 test: Remove unused self.p2p_conn_index = 1 (MarcoFalke) fa803710e2783c92e803d0c4e57ae32b34947738 test: Remove unused AddressType (MarcoFalke) fab5072ce1396484b9caa7320da4dc3c98070adc ci: Remove vulture (MarcoFalke) Pull request description: Currently, `vulture` is run with `--min-confidence=100`, which reduces its checks to dead code after control statements, which is nice, but not really a common nor severe issue. See the discussion in https://github.com/bitcoin/bitcoin/issues/34810#issuecomment-4045927137 and commit 5c005363a880c136cc44ff2456a402e398fcbf44, which had to remove dead code manually. Reducing the confidence has shown to be too brittle/tedious in the past, so remove the tool for now from CI. Of course, removing this from CI does not prevent anyone from running it locally and removing dead code. Fixes https://github.com/bitcoin/bitcoin/issues/34810 ACKs for top commit: fanquake: ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f willcl-ark: ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f Tree-SHA512: 6a5998470dae3a17baec29b70b02333f4cd9b81bc4c6a05b56085ff1ba527ed7bdeccd17b09d9ad785ae03c97982ee1f3147e4df3bd537c66b02e9a44d0e5f15