ff7cdf633e
fa90b21430b4f3bae6f4092a27e611bb06f2777f test: Remove unused feature_segwit.py functions (MarcoFalke) fa6b05c96ffb6cef42bf8907759d0d99f97a2e22 test: Remove unused CUSTOM_._COUNT (MarcoFalke) fa7bac94d87a1b25f8b33ebd29ce47bf442f137e test: Remove unused wait_for_addr, firstAddrnServices, on_addr (MarcoFalke) fa388a35855cc53d1a48d464c1bdcf793a0e2968 test: Remove unused self.p2p_conn_index = 1 (MarcoFalke) fa803710e2783c92e803d0c4e57ae32b34947738 test: Remove unused AddressType (MarcoFalke) fab5072ce1396484b9caa7320da4dc3c98070adc ci: Remove vulture (MarcoFalke) Pull request description: Currently, `vulture` is run with `--min-confidence=100`, which reduces its checks to dead code after control statements, which is nice, but not really a common nor severe issue. See the discussion in https://github.com/bitcoin/bitcoin/issues/34810#issuecomment-4045927137 and commit 5c005363a880c136cc44ff2456a402e398fcbf44, which had to remove dead code manually. Reducing the confidence has shown to be too brittle/tedious in the past, so remove the tool for now from CI. Of course, removing this from CI does not prevent anyone from running it locally and removing dead code. Fixes https://github.com/bitcoin/bitcoin/issues/34810 ACKs for top commit: fanquake: ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f willcl-ark: ACK fa90b21430b4f3bae6f4092a27e611bb06f2777f Tree-SHA512: 6a5998470dae3a17baec29b70b02333f4cd9b81bc4c6a05b56085ff1ba527ed7bdeccd17b09d9ad785ae03c97982ee1f3147e4df3bd537c66b02e9a44d0e5f15
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.