cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 11:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
MarcoFalke 24e4857b29
Merge #20494: refactor: Move node and wallet code out of src/interfaces 
629a9299b2a7241a3fa7d597cb34abcbe1af9255 Move WalletImpl from interfaces/wallet.cpp to wallet/interfaces.cpp (Russell Yanofsky)
2a26771d8161d30be1853a35acfee588cce03634 Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp (Russell Yanofsky)
12bd0fc9d70333c54c83ebb08c734272dbd330c2 Move NodeImpl from interfaces/node.cpp to node/interfaces.cpp (Russell Yanofsky)

Pull request description:

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

  ---

  Move `NodeImpl` from `interfaces/node.cpp` to `node/interfaces.cpp`
  Move `ChainImpl` from `interfaces/chain.cpp` to `node/interfaces.cpp`
  Move `WalletImpl` from `interfaces/wallet.cpp` to `wallet/interfaces.cpp`

  No changes to any classes (can review with `git diff --color-moved=dimmed_zebra`)

  Motivation for this change is to move node and wallet code to respective directories where it might fit in better than `src/interfaces/`, but also to remove all unnecessary code from `src/interfaces/` to unblock #19160 review, which has been hung up partially because of code organization. Building on top of this PR, #19160 should now be able to organize interface implementations more understandably in `src/node/` `src/wallet/` `src/ipc/` and `src/init/` directories instead of having so much functionality all in `src/interfaces/`

ACKs for top commit:
  promag:
    Code review ACK 629a9299b2a7241a3fa7d597cb34abcbe1af9255.
  MarcoFalke:
    review ACK 629a9299b2a7241a3fa7d597cb34abcbe1af9255 🔺

Tree-SHA512: 87c2b8fd51519bbd4e5ad3539a79debcf88c3bf021eb28c63f3f555186538b62a0c4cc1a3f07cfb4ff13aea8b0b2fdde505d81f22a5e5fd12a6e375b55a92ab8
2020-12-01 09:39:56 +01:00
..
coin.cpp
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
rpc: Add hash_type NONE to gettxoutsetinfo
2020-06-22 01:55:36 +02:00
coinstats.h
rpc: Add hash_type NONE to gettxoutsetinfo
2020-06-22 01:55:36 +02:00
context.cpp
Remove mempool global
2020-09-05 16:24:56 +02:00
context.h
scripted-diff: [net processing] Rename PeerLogicValidation to PeerManager
2020-09-07 11:15:48 +01:00
interfaces.cpp
Move ChainImpl from interfaces/chain.cpp to node/interfaces.cpp
2020-11-24 10:13:23 -05:00
psbt.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
psbt.h
Have a PSBTAnalysis state that indicates invalid PSBT
2019-11-19 14:54:08 -05:00
README.md
[docs] Document src subdirectories and different libraries
2019-04-09 17:53:08 -04:00
transaction.cpp
style and nits for fee-checking in BroadcastTransaction
2020-10-08 14:11:16 -07:00
transaction.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
ui_interface.cpp
gui: change combiner for signals to optional_last_value
2020-07-01 21:40:51 +08:00
ui_interface.h
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
utxo_snapshot.h
Convert everything except wallet/qt to new serialization
2020-03-30 16:10:30 -07:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.