cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-07 06:01:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
glozow 0d9a13ddd8
Merge bitcoin/bitcoin#28149: net processing: clamp PeerManager::Options user input 
547fa52443cbb5e8ccfee993486f5ced8cdbb33b net processing: clamp -blockreconstructionextratxn to uint32_t bounds (stickies-v)
e451d1e3c66350017da195335f428a96fdc7d840 net processing: clamp -maxorphantx to uint32_t bounds (stickies-v)
aa89e04e07ca9ff51b1d7d310a11821c6ad963cf doc: document PeerManager::Options members (stickies-v)

Pull request description:

  Avoid out-of-bounds user input for `PeerManager::Options` by safely clamping `-maxorphantx` and `-blockreconstructionextratxn`, and avoid platform-specific behaviour by changing `PeerManager::Options::max_extra_txs` from `size_t` to a `uint32_t`. Addresses https://github.com/bitcoin/bitcoin/pull/27499#pullrequestreview-1544114932.

  Also documents all `PeerManager::Options` members, addressing https://github.com/bitcoin/bitcoin/pull/27499#discussion_r1272302469.

ACKs for top commit:
  dergoegge:
    Code review ACK 547fa52443cbb5e8ccfee993486f5ced8cdbb33b
  glozow:
    reACK 547fa52443cbb5e8ccfee993486f5ced8cdbb33b

Tree-SHA512: 042d47b35bb8a7b29ef3dadd4c0c5d26f13a8f174f33687855d603c19f8de0fcbbda94418453331e149885412d4edd5f402d640d938f6d94b4dcf54e2fdbbcc9
2023-08-09 14:26:03 +02:00
..
abort.cpp
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
abort.h
kernel: Add fatalError method to notifications
2023-06-28 09:52:33 +02:00
blockmanager_args.cpp
refactor: Move stopafterblockimport handling out of blockstorage
2023-07-11 12:00:57 +02:00
blockmanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
blockstorage.cpp
Merge bitcoin/bitcoin#28191: refactor: Remove unused MessageStartChars parameters from BlockManager methods
2023-08-07 10:57:39 +02:00
blockstorage.h
Merge bitcoin/bitcoin#28191: refactor: Remove unused MessageStartChars parameters from BlockManager methods
2023-08-07 10:57:39 +02:00
caches.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
caches.h
…
chainstate.cpp
Move block-arrival information / preciousblock counters to ChainstateManager
2023-07-14 17:09:06 -04:00
chainstate.h
validation: Stricter assumeutxo error handling in LoadChainstate
2023-06-15 15:11:32 -04:00
chainstatemanager_args.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
chainstatemanager_args.h
Add [[nodiscard]] where ignoring a Result return type is an error
2023-05-29 13:12:45 +02:00
coin.cpp
…
coin.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
coins_view_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
coins_view_args.h
refactor, txdb: Add CoinsViewOptions struct
2023-02-10 04:39:11 -04:00
connection_types.cpp
[net] Move ConnectionType to its own file
2022-07-06 18:13:53 +02:00
connection_types.h
[net] Move ConnectionType to its own file
2022-07-06 18:13:53 +02:00
context.cpp
kernel: Add notification interface
2023-05-20 12:03:22 +02:00
context.h
refactor: init indexes, decouple 'Start()' from the creation step
2023-07-07 19:31:27 -03:00
database_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
database_args.h
refactor, dbwrapper: Add DBParams and DBOptions structs
2023-02-10 04:39:11 -04:00
eviction.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
eviction.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
interface_ui.cpp
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interface_ui.h
Add InitError(error, details) overload
2023-02-28 12:04:47 -05:00
interfaces.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
kernel_notifications.cpp
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
kernel_notifications.h
kernel: Remove StartShutdown calls from validation code
2023-07-11 12:30:56 -04:00
mempool_args.cpp
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_args.h
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
mempool_persist_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
mempool_persist_args.h
refactor: Move fs.* to util/fs.*
2023-03-23 12:55:18 +01:00
miner.cpp
refactor: Fix logging.h includes
2023-08-05 10:42:56 +02:00
miner.h
Add public Boost headers explicitly
2023-05-31 15:43:01 +01:00
mini_miner.cpp
Mitigate timeout in CalculateTotalBumpFees
2023-06-01 18:04:44 -04:00
mini_miner.h
Implement Mini version of BlockAssembler to calculate mining scores
2023-03-30 17:03:04 -04:00
minisketchwrapper.cpp
Use steady clock in SeedStrengthen and FindBestImplementation
2023-03-02 14:48:28 +01:00
minisketchwrapper.h
…
peerman_args.cpp
Merge bitcoin/bitcoin#28149: net processing: clamp PeerManager::Options user input
2023-08-09 14:26:03 +02:00
peerman_args.h
[net processing] Introduce PeerManager options
2023-07-24 18:30:59 +02:00
psbt.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
psbt.h
…
README.md
…
transaction.cpp
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
transaction.h
refactor: Move functions to BlockManager methods
2023-05-10 19:06:53 +02:00
txreconciliation.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
txreconciliation.h
[net processing] Move -txreconciliation to PeerManager::Options
2023-07-24 18:35:28 +02:00
utxo_snapshot.cpp
lint: remove /* Continued */ markers from codebase
2023-08-03 17:52:24 +01:00
utxo_snapshot.h
refactor: Add path argument to FindSnapshotChainstateDir
2023-05-30 16:52:48 +02:00
validation_cache_args.cpp
move-only: Extract common/args and common/config.cpp from util/system
2023-04-19 10:48:30 +02:00
validation_cache_args.h
validationcaches: Add and use ValidationCacheSizes
2022-08-03 12:03:27 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.