cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 19:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
MarcoFalke cf63d635b1
Merge bitcoin/bitcoin#23499: multiprocess: Add interfaces::Node::broadCastTransaction method 
0e0f4fdd892223766db4a83194b6576847b757f7 multiprocess: Add interfaces::Node::broadCastTransaction method (Russell Yanofsky)

Pull request description:

  This fixes a null pointer crash in the bitcoin-gui PSBT dialog. The bitcoin-gui interfaces::Node object has a null NodeContext pointer, and can't broadcast transactions directly. It needs to broadcast transactions through the bitcoin-node process instead.

  ---

  This PR is part of the [process separation project](https://github.com/bitcoin/bitcoin/projects/10).

ACKs for top commit:
  lsilva01:
    Code Review ACK 0e0f4fd

Tree-SHA512: cd2c1fe8dc15e7cecf01a21d64319d6add1124995305a9ef9cb72f8492dc692c62d4f846182567d47a5048a533178a925419250941a47cb39932467c36bea3e1
2021-11-16 08:42:21 +01:00
..
blockstorage.cpp
Merge bitcoin/bitcoin#22937: refactor: Forbid calling unsafe fs::path(std::string) constructor and fs::path::string() method
2021-10-15 10:01:56 +02:00
blockstorage.h
add missing atomic include
2021-06-22 11:06:30 +02:00
coin.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
coinstats.h
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
context.cpp
validation: Farewell, global Chainstate!
2021-06-10 15:05:25 -04:00
context.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
interfaces.cpp
Merge bitcoin/bitcoin#23499: multiprocess: Add interfaces::Node::broadCastTransaction method
2021-11-16 08:42:21 +01:00
psbt.cpp
[MOVEONLY] consensus: move amount.h into consensus
2021-09-30 07:41:57 +08:00
psbt.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
README.md
doc: Remove irrelevant link to GitHub
2021-04-06 09:34:21 +02:00
transaction.cpp
[refactor] Don't call AcceptToMemoryPool() from outside validation.cpp
2021-11-03 14:34:41 +00:00
transaction.h
refactor: move GetTransaction(...) to node/transaction.cpp
2021-07-22 15:53:17 +02:00
ui_interface.cpp
multiprocess: Delay wallet client construction
2021-09-16 14:17:01 -04:00
ui_interface.h
multiprocess: Delay wallet client construction
2021-09-16 14:17:01 -04:00
utxo_snapshot.h
validation: remove nchaintx from assumeutxo metadata
2021-04-26 13:22:37 -04:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

This directory is at the moment sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.