cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 19:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/node
History
MarcoFalke 6c156e49cb
Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore 
fa4e088cbac035b8029a10b492849540150d0622 wallet: Mark replaced tx to not be in the mempool anymore (MarcoFalke)

Pull request description:

  The wallet does not mark the replaced tx as out-of-mempool. This causes failures in user scripts, because later RPCs may depend on this state change from `bumpfee`.

  For example, the following might fail on current master:

  ```
  txid = sendtoaddress(...)
  bumpfee(txid)
  abandontransaction(txid)  # fails because txid is still marked as "in mempool"
  ```

  Fixes #18831

ACKs for top commit:
  meshcollider:
    utACK fa4e088cbac035b8029a10b492849540150d0622
  ryanofsky:
    Code review ACK fa4e088cbac035b8029a10b492849540150d0622, and previous ACK faeedff5c87091fd83d2fb2b29eb49c948363f29 is also still valid in case there's a preference for the original fix

Tree-SHA512: 9858f40f5fb5a43a7b584b5c4268b6befa82e6a84583be5206fe721bcb6c255e8d35479d347d0b9aed72703df49887c02b14ab680e8efdd28b90dd6b93d9439a
2021-03-09 07:54:18 +01:00
..
coin.cpp
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coin.h
node: Use mempool from node context instead of global
2019-12-05 14:22:05 -05:00
coinstats.cpp
chainparams: add allowed assumeutxo values
2021-02-12 07:53:22 -06:00
coinstats.h
rpc: Add hash_type MUHASH to gettxoutsetinfo
2021-01-30 17:38:21 +01:00
context.cpp
Remove the remaining fee estimation globals
2020-12-03 12:56:37 +01:00
context.h
Remove the remaining fee estimation globals
2020-12-03 12:56:37 +01:00
interfaces.cpp
Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore
2021-03-09 07:54:18 +01:00
psbt.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
psbt.h
Have a PSBTAnalysis state that indicates invalid PSBT
2019-11-19 14:54:08 -05:00
README.md
[docs] Document src subdirectories and different libraries
2019-04-09 17:53:08 -04:00
transaction.cpp
scripted-diff: Invoke ::AcceptToMemoryPool with chainstate
2021-02-18 14:49:06 -05:00
transaction.h
scripted-diff: Use [[nodiscard]] (C++17) instead of NODISCARD
2020-11-26 09:05:59 +00:00
ui_interface.cpp
gui: change combiner for signals to optional_last_value
2020-07-01 21:40:51 +08:00
ui_interface.h
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
utxo_snapshot.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00

README.md

src/node/

The src/node/ directory contains code that needs to access node state (state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar classes).

Code in src/node/ is meant to be segregated from code in src/wallet/ and src/qt/, to ensure wallet and GUI code changes don't interfere with node operation, to allow wallet and GUI code to run in separate processes, and to perhaps eventually allow wallet and GUI code to be maintained in separate source repositories.

As a rule of thumb, code in one of the src/node/, src/wallet/, or src/qt/ directories should avoid calling code in the other directories directly, and only invoke it indirectly through the more limited src/interfaces/ classes.

The src/node/ directory is a new directory introduced in #14978 and at the moment is sparsely populated. Eventually more substantial files like src/validation.cpp and src/txmempool.cpp might be moved there.