94ca99ac51
7426afbe62414fa575f91b4f8d3ea63bcc653e8b [p2p] assign just 1 random announcer in AddChildrenToWorkSet (glozow) 4c1fa6b28c292dcaf11d605e0e8c2bbf59cc4de4 test fix: make peer who sends MSG_TX announcement non-wtxidrelay (glozow) 2da46b88f09ff3c58c94bd258273c04d16c8b649 pass P2PTxInvStore init args to P2PInterface init (glozow) e3bd51e4b52069d1db5c478aaec00666fc8f4101 [doc] how unique_parents can be empty (glozow) 32eb6dc758a90b6c154d1e3e503f0d4840c44b02 [refactor] assign local variable for wtxid (glozow) 18820ccf6b2163b42ee1256d33cc3d14d268b682 multi-announcer orphan handling test fixups (glozow) c4cc61db98ff1f0a5943fc7469adf9d9df6fddcd [fuzz] GetCandidatePeers (glozow) 7704139cf0dbddf322eac2af9be0c3f2838bc285 [refactor] make GetCandidatePeers take uint256 and in-out vector (glozow) 6e4d392a7536d9c5e1afc60196ee82195dbfec35 [refactor] rename to OrphanResolutionCandidate to MaybeAdd* (glozow) 57221ad97971d399a90d509c5e7b64227f6b2b5e [refactor] move parent inv-adding to OrphanResolutionCandidate (glozow) Pull request description: Followup to #31397. Addressing (in order): https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1906077380 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1881060842 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1905994963 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1905999581 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1906001592 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1905989913 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1905920861 https://github.com/bitcoin/bitcoin/pull/31658#pullrequestreview-2551617694 https://github.com/bitcoin/bitcoin/pull/31397#discussion_r1917559601 ACKs for top commit: instagibbs: reACK 7426afbe62414fa575f91b4f8d3ea63bcc653e8b marcofleon: reACK 7426afbe62414fa575f91b4f8d3ea63bcc653e8b mzumsande: Code Review ACK 7426afbe62414fa575f91b4f8d3ea63bcc653e8b dergoegge: Code review ACK 7426afbe62414fa575f91b4f8d3ea63bcc653e8b Tree-SHA512: bca8f576873fdaa20b758e1ee9708ce94e618ff14726864b29b50f0f9a4db58136a286d2b654af569b09433a028901fe6bcdda68dcbfea71e2d1271934725503
src/node/
The src/node/ directory contains code that needs to access node state
(state in CChain, CBlockIndex, CCoinsView, CTxMemPool, and similar
classes).
Code in src/node/ is meant to be segregated from code in
src/wallet/ and src/qt/, to ensure wallet and GUI
code changes don't interfere with node operation, to allow wallet and GUI code
to run in separate processes, and to perhaps eventually allow wallet and GUI
code to be maintained in separate source repositories.
As a rule of thumb, code in one of the src/node/,
src/wallet/, or src/qt/ directories should avoid
calling code in the other directories directly, and only invoke it indirectly
through the more limited src/interfaces/ classes.
This directory is at the moment
sparsely populated. Eventually more substantial files like
src/validation.cpp and
src/txmempool.cpp might be moved there.