cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-05 03:06:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
merge-script 34a5ecadd7
Merge bitcoin/bitcoin#34397: doc: fix arg name hints so bugprone can validate them 
a73a3ec5532ddc05c1b013d868d9994f2889c9cf doc: fix invalid arg name hints for bugprone validation (Lőrinc)

Pull request description:

  The extra leading `=` or missing trailing `=` prevented clang-tidy's `bugprone-argument-comment` check from validating the parameter name, as it only matches comments formatted strictly as `/*parameter_name=*/` (see https://clang.llvm.org/extra/clang-tidy/checks/bugprone/argument-comment.html).

  I have considered doing a scripted diff, but the values I found aren't so numerous and can easily be reviewed manually.

ACKs for top commit:
  b-l-u-e:
    ACK a73a3ec tested and saw that argument comments now use the strict "/*param=*/"  format required by bugprone-argument-comment
  Sjors:
    utACK a73a3ec5532ddc05c1b013d868d9994f2889c9cf
  maflcko:
    review ACK a73a3ec5532ddc05c1b013d868d9994f2889c9cf 🍦

Tree-SHA512: 31177934d645116f381668a0f945028d7e04fab1fc6185dd0e3b7451aab71f89f1e4dd07246db667d1c4734eea3e5d73433c8b0e09181b3ece47dacc8677401e
2026-01-26 16:51:15 +00:00
..
bench
doc: fix invalid arg name hints for bugprone validation
2026-01-24 00:44:22 +01:00
common
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
compat
Merge bitcoin/bitcoin#34090: net: Fix -Wmissing-braces
2026-01-22 12:39:52 +01:00
consensus
Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count
2026-01-20 15:47:17 -08:00
crc32c
…
crypto
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
index
util: Remove FilterHeaderHasher
2026-01-20 16:26:50 +00:00
init
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
interfaces
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
ipc
Merge bitcoin/bitcoin#34363: Update libmultiprocess subtree to avoid occasional rpc_misc.py timeout
2026-01-21 15:07:23 +00:00
kernel
Merge bitcoin/bitcoin#34384: Remove epoch logic from mempool
2026-01-23 15:10:54 +00:00
leveldb
Update leveldb subtree to latest master
2025-10-16 13:49:49 +01:00
logging
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
minisketch
Update minisketch subtree to latest upstream
2025-10-13 12:33:23 +01:00
node
doc: fix invalid arg name hints for bugprone validation
2026-01-24 00:44:22 +01:00
policy
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
primitives
refactor: rename CTransaction::GetTotalSize to signal that it's not cached
2026-01-19 20:20:13 +01:00
qt
Merge bitcoin-core/gui#920: Set peer version and subversion to N/A when not available or detecting
2026-01-25 14:23:05 +00:00
rpc
doc: fix invalid arg name hints for bugprone validation
2026-01-24 00:44:22 +01:00
script
Merge bitcoin/bitcoin#32471: wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key
2026-01-20 12:17:19 -08:00
secp256k1
Update secp256k1 subtree to latest master
2025-10-15 09:49:11 +01:00
support
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
test
Merge bitcoin/bitcoin#34397: doc: fix arg name hints so bugprone can validate them
2026-01-26 16:51:15 +00:00
univalue
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
util
Merge bitcoin/bitcoin#34351: util: Remove FilterHeaderHasher
2026-01-26 10:17:35 +00:00
wallet
doc: fix invalid arg name hints for bugprone validation
2026-01-24 00:44:22 +01:00
zmq
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
.clang-format
clang-format: use AngleBracket for main includes
2026-01-19 17:11:23 +00:00
.clang-tidy
Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods
2026-01-21 13:23:43 +01:00
addrdb.cpp
…
addrdb.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addresstype.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
addrman_impl.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
addrman.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
addrman.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
arith_uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
arith_uint256.h
refactor(headerssync): Extract test constants ahead of breakup into functions
2025-09-12 22:28:41 +02:00
attributes.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Add Handle/View pattern for BlockValidationState
2026-01-21 19:40:25 +05:30
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections
2026-01-12 15:02:14 -05:00
bitcoin-res.rc
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Remove no longer necessary WinCmdLineArgs class
2025-10-06 19:41:35 +01:00
bitcoin.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockencodings.cpp
log,blocks: avoid ComputeTotalSize and GetHash work when logging is disabled
2026-01-19 20:20:13 +01:00
blockencodings.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
blockfilter.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chain.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
chain.h
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
chainparams.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
chainparams.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsbase.cpp
…
chainparamsbase.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
chainparamsseeds.h
contrib: update fixed seeds
2025-09-03 11:23:30 +01:00
checkqueue.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
clientversion.cpp
refactor: Avoid -W*-whitespace in git archive
2025-11-13 09:33:36 +01:00
clientversion.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cluster_linearize.h
clusterlin: minimize chunks (feature)
2026-01-12 17:38:30 -05:00
CMakeLists.txt
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
coins.cpp
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
coins.h
refactor: Let CCoinsViewCache::BatchWrite return void
2025-12-14 22:25:31 +01:00
compressor.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
compressor.h
…
core_io.cpp
Merge bitcoin/bitcoin#33738: log: avoid collecting GetSerializeSize data when compact block logging is disabled
2026-01-20 15:41:30 -08:00
core_io.h
refactor: [move-only] Merge core_io module
2026-01-19 12:57:16 +01:00
core_memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
cuckoocache.h
…
dbwrapper.cpp
refactor: Add Chainstate::StoragePath() method
2025-12-12 06:49:59 -04:00
dbwrapper.h
refactor: Add Chainstate::StoragePath() method
2025-12-12 06:49:59 -04:00
deploymentinfo.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentinfo.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
deploymentstatus.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
deploymentstatus.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
dummywallet.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
external_signer.cpp
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
external_signer.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
flatfile.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
flatfile.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
hash.cpp
…
hash.h
…
headerssync.cpp
refactor: Use reference for chain_start in HeadersSyncState
2025-11-20 11:34:21 +09:00
headerssync.h
refactor: Use reference for chain_start in HeadersSyncState
2025-11-20 11:34:21 +09:00
httprpc.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
httprpc.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
httpserver.cpp
Merge bitcoin/bitcoin#34032: util: Add some more Unexpected and Expected methods
2026-01-21 13:23:43 +01:00
httpserver.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
i2p.cpp
log: Remove brittle and confusing LogPrintLevel
2025-12-13 13:43:24 +01:00
i2p.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
indirectmap.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
init.cpp
Merge bitcoin/bitcoin#34224: init: Return EXIT_SUCCESS on interrupt
2026-01-13 15:23:12 -08:00
init.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key_io.cpp
…
key_io.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
key.cpp
Merge bitcoin/bitcoin#29675: wallet: Be able to receive and spend inputs involving MuSig2 aggregate keys
2025-10-14 16:25:52 -04:00
key.h
sign: Add CreateMuSig2PartialSig
2025-09-30 11:06:43 -07:00
logging.cpp
Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections
2026-01-12 15:02:14 -05:00
logging.h
Merge bitcoin/bitcoin#29415: Broadcast own transactions only via short-lived Tor or I2P connections
2026-01-12 15:02:14 -05:00
mapport.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
mapport.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
memusage.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
merkleblock.cpp
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
merkleblock.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
musig.cpp
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
musig.h
musig: Move MUSIG_CHAINCODE to musig.cpp
2025-11-24 18:48:43 +01:00
net_permissions.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_permissions.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_processing.cpp
Merge bitcoin/bitcoin#34297: p2p: add validation checks for initial self-announcement
2026-01-22 12:01:36 +01:00
net_processing.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
net_types.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net_types.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
net.cpp
Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations
2026-01-23 13:25:42 +01:00
net.h
Merge bitcoin/bitcoin#34302: fuzz: Restore SendMessages coverage in process_message(s) fuzz targets
2026-01-20 16:45:18 +01:00
netaddress.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
netaddress.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
netbase.cpp
Modernize GetBindAddress()
2026-01-22 10:35:14 -05:00
netbase.h
Merge bitcoin/bitcoin#34242: Prepare string and net utils for future HTTP operations
2026-01-23 13:25:42 +01:00
netgroup.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
netgroup.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
netmessagemaker.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
noui.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
outputtype.cpp
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
outputtype.h
refactor: increase string_view usage
2025-10-02 12:53:55 +01:00
pow.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
pow.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
prevector.h
refactor: Prefer <=> over multiple relational operators
2025-11-03 14:39:50 +01:00
private_broadcast.cpp
net_processing: retry private broadcast
2025-12-16 17:53:50 +01:00
private_broadcast.h
net_processing: retry private broadcast
2025-12-16 17:53:50 +01:00
protocol.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
protocol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
psbt.cpp
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
psbt.h
refactor: Avoid copies by using const references or by move-construction
2026-01-14 23:03:47 +01:00
pubkey.cpp
pubkey: Return tweaks from BIP32 derivation
2025-09-30 11:06:09 -07:00
pubkey.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
random.cpp
…
random.h
refactor: Enforce readability-avoid-const-params-in-decls
2026-01-14 23:04:12 +01:00
randomenv.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
randomenv.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
rest.cpp
rest: reformat uri_prefixes initializer list
2025-12-14 10:04:37 +01:00
rest.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
scheduler.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
semaphore_grant.h
…
serialize.h
refactor: Return uint64_t from GetSerializeSize
2025-10-30 17:51:53 +01:00
signet.cpp
Merge bitcoin/bitcoin#32497: merkle: pre‑reserve leaves to prevent reallocs with odd vtx count
2026-01-20 15:47:17 -08:00
signet.h
kernel: Remove some unnecessary non-kernel includes
2025-12-21 10:24:09 +01:00
span.h
…
streams.cpp
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
streams.h
refactor: Add AutoFile::size
2025-11-14 01:17:38 +02:00
sync.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
sync.h
doc: Fix wrong code in WITH_LOCK doxygen comment
2026-01-21 14:51:12 +01:00
threadsafety.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
tinyformat.h
…
torcontrol.cpp
refactor: Use std::bind_front over std::bind
2026-01-20 15:30:46 +01:00
torcontrol.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
txdb.cpp
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
txdb.h
Merge bitcoin/bitcoin#33866: refactor: Let CCoinsViewCache::BatchWrite return void
2026-01-02 16:49:23 -08:00
txgraph.cpp
clusterlin: minimize chunks (feature)
2026-01-12 17:38:30 -05:00
txgraph.h
txgraph: drop move assignment operator
2025-11-25 07:36:50 -05:00
txmempool.cpp
Rework CTxMemPool::GetChildren() to not use epochs
2026-01-22 21:51:13 -05:00
txmempool.h
Rework CTxMemPool::GetChildren() to not use epochs
2026-01-22 21:51:13 -05:00
txrequest.cpp
Fix compilation for old Boost versions
2025-12-18 22:38:02 +01:00
txrequest.h
doc: fix double-word typos in comments
2025-12-30 12:12:26 -08:00
uint256.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
uint256.h
refactor: Remove all operator!= definitions
2025-11-03 14:39:48 +01:00
undo.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validation.cpp
doc: fix invalid arg name hints for bugprone validation
2026-01-24 00:44:22 +01:00
validation.h
Merge bitcoin/bitcoin#32740: refactor: Header sync optimisations & simplifications
2026-01-14 11:38:07 -08:00
validationinterface.cpp
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
validationinterface.h
refactor: Convert ChainstateRole enum to struct
2025-12-12 06:49:59 -04:00
versionbits_impl.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
versionbits.cpp
Merge bitcoin/bitcoin#34084: scripted-diff: [doc] Unify stale copyright headers
2025-12-19 16:56:02 +00:00
versionbits.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00
walletinitinterface.h
scripted-diff: [doc] Unify stale copyright headers
2025-12-16 22:21:15 +01:00