cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-17 17:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Modernize GetBindAddress()

Browse Source 
Replace the C-style casting with C++ reinterpret_cast
This commit is contained in:
Matthew Zipkin 2025-10-14 12:49:14 -04:00
parent a0ca851d26
commit 0b0d9125c1
No known key found for this signature in database
GPG Key ID: E7E2984B6289C93A
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/netbase.cpp
View File

@ -951,10 +951,13 @@ CService MaybeFlipIPv6toCJDNS(const CService& service)
CService GetBindAddress(const Sock& sock)
{
CService addr_bind;
struct sockaddr_storage sockaddr_bind;
socklen_t sockaddr_bind_len = sizeof(sockaddr_bind);
if (!sock.GetSockName((struct sockaddr*)&sockaddr_bind, &sockaddr_bind_len)) {
addr_bind.SetSockAddr((const struct sockaddr*)&sockaddr_bind, sockaddr_bind_len);
sockaddr_storage storage;
socklen_t len = sizeof(storage);
auto sa = reinterpret_cast<sockaddr*>(&storage);
if (sock.GetSockName(sa, &len) == 0) {
addr_bind.SetSockAddr(sa, len);
} else {
LogWarning("getsockname failed\n");
}