laanwj
fcf6c8f4eb
doc: Update manual pages for 23.0
...
Tree-SHA512: 0e683e928e3c8e2e5534b8a28eb288445caeadf698e27d1c307cad8a8edb02c151ec245de4ed64fc6b7f137dfcb808fec410bd9f968f6d3f80ee3067563ca97a
2022-04-21 21:28:32 +02:00
laanwj
4253c619cf
build: Bump to final
...
Tree-SHA512: 389a841cb36dd8b9c99279d63473a10c83c09700b0077bd16f73d1141d5d79c1bdbba462f6fcb4c1917c28260bbf1359bf93bbe695b150adde23c4533d6c85cd
2022-04-21 21:23:55 +02:00
laanwj
9549b28c04
doc: Update manual pages for 23.0rc5
...
Tree-SHA512: cc721bc9a0a916a33979b17d98bfea1c569bd827072d651d8882ee674a0f14f0981bf22e3cd9eff384e580d6afd90c7310a1928d99f204833fce4d06a3287a67
2022-04-14 18:05:18 +02:00
laanwj
cf42ffdaca
qt: 23.0rc5 translations update
...
Tree-SHA512: 86a246bf5a817084f077ace118edad16dc48d06ec8d39476d82d6d6c5010bde9ec91eec00d7bd9736fc3ecfd1b67629f06e38798d484e6a0f09768553a52a231
2022-04-14 18:05:02 +02:00
laanwj
30ad7ac8fe
build: Bump rc to 23.0rc5
...
Tree-SHA512: 394d58796c13d8ce2cef2fc0f2dc364cd2736cefe019e4cf6bef82b773c2c8a8ecb77ead67014eab9046c40d416096a56ebfaaacac2d4485c40f1ec9c4659638
2022-04-14 17:26:41 +02:00
laanwj
dabac355c8
Merge bitcoin/bitcoin#24843 : [23.x] rc5 backports
...
a75b8ec836a5a5c08aebaf2efd99d5c34d033292 guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues (fanquake)
Pull request description:
Currently backports:
* https://github.com/bitcoin/bitcoin/pull/24842
ACKs for top commit:
gruve-p:
ACK a75b8ec836
2022-04-14 17:25:53 +02:00
fanquake
a75b8ec836
guix: fix GCC 10.3.0 + mingw-w64 setjmp/longjmp issues
...
This commit backports a patch to the GCC 10.3.0 we build for Windows
cross-compilation in Guix. The commit has been backported to the GCC
releases/gcc-10 branch, but hasn't yet made it into a release.
The patch corrects a regression from an earlier GCC commit, see:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=357c4350680bf29f0c7a115424e3da11c53b5582
and
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=074226d5aa86cd3de517014acfe34c7f69a2ccc7 ,
related to the way newer versions of mingw-w64 implement setjmp/longjmp.
Ultimately this was causing a crash for us when Windows users were
viewing the network traffic tab inside the GUI. After some period, long
enough that a buffer would need reallocating, a call into FreeTypes
gray_record_cell() would result in a call to ft_longjmp (longjmp), which
would then trigger a crash.
Fixes: https://github.com/bitcoin-core/gui/issues/582 .
See also:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=e8d1ca7d2c344a411779892616c423e157f4aea8 .
https://bugreports.qt.io/browse/QTBUG-93476 .
Github-Pull: #24842
Rebased-From: 457148a803cee02897b7428fa7b3eb93eed71e4c
2022-04-13 13:49:04 +01:00
laanwj
b6253829c1
doc: Update manual pages for 23.0rc4
...
Tree-SHA512: 0124eaf86ef7324c14a77eafab8f53f0f3da83b19bc63922218051dd50bc154ab8e47f427fdc4ac5c2c3c34004ffd8e2df7ec134c66a16a78c4917a4ce1edae4
2022-04-08 16:06:51 +02:00
laanwj
d37081e483
qt: 23.0rc4 translations update
...
Tree-SHA512: 1bf7ac70963fc6361b5cd117612355e6d4b1862721441003eb7b11f8366a706cb83d45a46533bfad421d7ea0dd12931b4e37881818eb0f0be845de19b823f98c
2022-04-08 16:05:58 +02:00
laanwj
5f8635541e
build: Bump rc to 23.0rc4
...
Tree-SHA512: 18e4560c9b04d1270449ed1938b4c3ce9a903b1b65257e92947884f12a2d45e64e4074f8e7738c7ccb7076f696f9e7fb2056a55f856335a98eed143e0c1167f3
2022-04-08 15:53:50 +02:00
laanwj
308a2022c0
Merge bitcoin/bitcoin#24807 : [23.x] Final rc4 backports
...
e3e4be9cd513c85311634a8128e018dbf8748888 RPC: Switch getblockfrompeer back to standard param name blockhash (Luke Dashjr)
69cc83df69e5a9306a0090df0dade38d5383af4d Add DEBUG_LOCKCONTENTION documentation to the developer notes (Jon Atack)
6374e24887e3957cfcf17841a8c48cac2ffbda4f Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive (Jon Atack)
Pull request description:
Backports:
* #24770
* #24806
ACKs for top commit:
laanwj:
Commit list and code review ACK e3e4be9cd513c85311634a8128e018dbf8748888
jonatack:
Code review and commit metadata ACK e3e4be9cd513c85311634a8128e018dbf8748888
Tree-SHA512: eff2b506379a9396b12b42ed2858e3eb9403a55950d6dec0b5dcc95c4c2998cddf9e0ec88af2f8ac5a7bece4d4537acede1c75f59bbc6616bee273384f87f6b0
2022-04-08 15:53:08 +02:00
Luke Dashjr
e3e4be9cd5
RPC: Switch getblockfrompeer back to standard param name blockhash
...
This commit partially reverts 923312fbf6a89efde1739da0b7209694d4f892ba.
Github-Pull: #24806
Rebased-From: 88917f93cc01b5e881072b0e476b74d20b7673c4
2022-04-08 13:27:19 +01:00
Jon Atack
69cc83df69
Add DEBUG_LOCKCONTENTION documentation to the developer notes
...
Github-Pull: #24770
Rebassedd-From: 43947333315d07f59e1247bd76e0ba9d35a99e31
2022-04-08 13:27:02 +01:00
Jon Atack
6374e24887
Put lock logging behind DEBUG_LOCKCONTENTION preprocessor directive
...
Github-Pull: #24770
Rebased-From: 39a34b6877945908759f6a2322f60852e521e2ee
2022-04-08 13:26:34 +01:00
MarcoFalke
1ea76767d0
Merge bitcoin/bitcoin#24755 : [23.x] Further build backports
...
39396ab593f2d6790b8dd0b2588cb0981d97ebb5 build: Fix "ERR: Unsigned tarballs do not exist" (Hennadii Stepanov)
db8a5d60944dd565e15f4aba776a475972b4a9c9 guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64 (fanquake)
Pull request description:
Backports:
* https://github.com/bitcoin/bitcoin/pull/24733
* https://github.com/bitcoin/bitcoin/pull/24736
ACKs for top commit:
gruve-p:
ACK 39396ab593
2022-04-05 08:51:54 +02:00
Hennadii Stepanov
39396ab593
build: Fix "ERR: Unsigned tarballs do not exist"
...
Github-Pull: #24733
Rebased-From: 7762c5683f91a066cf833a19e7c0153942395cb1
2022-04-04 10:49:17 +01:00
fanquake
db8a5d6094
guix: fix vmov alignment issues with gcc 10.3.0 & mingw-w64
...
This introduces a patch to our GCC (10.3.0) mingw-w64 compiler, in Guix, to make
it avoid using aligned vmov instructions. This works around a longstanding issue
in GCC, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54412 , which was recently
discovered to be causing issues, see #24726 .
Note that distros like Debian are also patching around this issue, and that is
where this patch comes from. This would also explain why we haven't run into this
problem earlier, in development builds. See:
https://salsa.debian.org/mingw-w64-team/gcc-mingw-w64/-/blob/master/debian/patches/vmov-alignment.patch .
Fixes #24726 .
Alternative to #24727 .
See also:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=939559
Github-Pull: #24736
Rebased-From: d6fae988eff78e28756d9b6219ec0239c420f51b
2022-04-04 10:48:33 +01:00
MarcoFalke
e089c68aa1
Merge bitcoin/bitcoin#24725 : 23.0: rc4 backport
...
1448c99380bbb83f2cf0410470e75049d0e0c627 wallet: Postpone NotifyWalletLoaded() for encrypted wallets (Hennadii Stepanov)
4f3ba8517a7e8c8f823617149d12e72cb32c8d0d wallet, refactor: Add wallet::NotifyWalletLoaded() function (Hennadii Stepanov)
Pull request description:
ACKs for top commit:
Sjors:
ACK 1448c99380bbb83f2cf0410470e75049d0e0c627
hebasto:
ACK 1448c99380bbb83f2cf0410470e75049d0e0c627
jarolrod:
ACK 1448c99380
2022-04-01 08:48:42 +02:00
Hennadii Stepanov
1448c99380
wallet: Postpone NotifyWalletLoaded() for encrypted wallets
...
Too early NotifyWalletLoaded() call in CWallet::Create() results the
notification goes before DescriptorScriptPubKeyMans were created and
added to an encrypted wallet.
Co-authored-by: Andrew Chow <achow101-github@achow101.com>
Github-Pull: bitcoin/bitcoin#24711
Rebased-From: 0c12f0116ca802f55f5ab43e6c4842ac403b9889
2022-03-31 19:04:04 +02:00
Hennadii Stepanov
4f3ba8517a
wallet, refactor: Add wallet::NotifyWalletLoaded() function
...
This change is a prerequisite for the following bugfix.
Github-Pull: bitcoin/bitcoin#24711
Rebased-From: aeee419c6aae085cacd75343c1ce23486b2b8916
2022-03-31 19:04:02 +02:00
laanwj
e181e94e86
doc: Update manual pages for 23.0rc3
...
Tree-SHA512: 5350255e4260b85b7f294e980f9c47fb0aa8370965711411e37c16702cd3eee010ea83c2135b1e4fe6241402b9b1b478bc7f6a181f3e6da2c261a024b45aa8ae
2022-03-31 16:13:45 +02:00
laanwj
752c9d82a6
qt: 23.0rc3 translations update
...
Tree-SHA512: 110fab39faae351f10a9bb3a8a852d29f1e8e4bae27b790a52198fc39c5e1a2261c0fe8f0289f4c626e3d39f237c9410ae80f311bdcf446f778c680bc0fdc367
2022-03-31 16:13:38 +02:00
laanwj
2a1d3a48c4
build: Bump rc to 23.0rc3
...
Tree-SHA512: 558379b8b0e9e12a84b563d673377712950b425fd5862f68dddcecde14090e9566917e30720a82ddf8cb1132f02e21bab1ab93594f507e9ca34d039408ca15b4
2022-03-31 16:13:25 +02:00
fanquake
c243e08351
Merge bitcoin/bitcoin#24512 : 23.x backports
...
174af33d5d78cfe341b688f5393d9acc8c4aaf6b util: Add inotify_rm_watch to syscall sandbox (AllowFileSystem) (Hennadii Stepanov)
ded10fe3eae2ad8058d0cc8f1cee1ad1d34bb507 build: Fix Boost.Process test for Boost 1.78 (Hennadii Stepanov)
26c2f23f36228e334d17c43a0cb61f76cc545c3d build: Fix Boost.Process detection on macOS arm64 (Hennadii Stepanov)
85f85c7e5fce1ac1682bf62808d37f3da23614f7 util: add linkat to syscall sandbox (AllowFileSystem) (fanquake)
eaa04194b979635a3d8590a8409084159d1e6576 contrib: fix signet miner (sighash mismatch) (Sebastian Falbesoner)
235b04259414fd708c31bbe0cab28ba09bcd25f1 rpc: Exclude descriptor when address is excluded (MarcoFalke)
b05a59b69fd51dd6a7ebc79dc0d11dc2af47a006 ci: Temporarily use clang-13 to work around clang-14 TSan bug (MarcoFalke)
65b966743c62914df7fd9b7f028f1f5bb3683eda doc, init: add links to doc/cjdns.md (Jon Atack)
7a553d4e657d52e2d15b53a4b54b4ca5ecde2f04 doc: update i2p.md with cjdns, improve local addresses section (Jon Atack)
4148396229db008419f895161b6c7310a44d563b doc: update tor.md with cjdns and getnodeaddresses, fix tor grep, (Jon Atack)
4690e8af1300daba276c7b426030d4c69d27d73b doc: create initial doc/cjdns.md for cjdns how-to documentation (Jon Atack)
5d24f612d1f7f5f1258216e3b7c569399c657abb Clarify in -maxtimeadjustment that only outbound peers influence time data (Jon Atack)
b1646f1bb573031ca587081276d9fe7c4873b8c9 test: set segwit height back to 0 on regtest (Martin Zumsande)
ef6a37b7c4b942f2db95809a299700e410b94460 rpc: rename getdeploymentinfo status-next to status_next (Jon Atack)
2a6fcf9c136f7a0c6ba12010ff1769acd07804cf init, doc: improve -onlynet help and tor/i2p documentation (Jon Atack)
Pull request description:
Backport the following to 23.x:
- #24468
- #24528
- #24527
- #24609
- #24555
- #24663
- #24572
- #24636
- #24553
- #24659
- #24521
- #24523
- #24690
- #24710
Possibly also:
- #24579
- #24691
ACKs for top commit:
laanwj:
List-of-commits ACK 174af33d5d78cfe341b688f5393d9acc8c4aaf6b, I think we should merge this and move forward with rc3..
hebasto:
ACK 174af33d5d78cfe341b688f5393d9acc8c4aaf6b
Tree-SHA512: 5a493e1652b780b527767d6ca9e67012abd2fa5573496e85e0d8aa4bed3eb332bfcd72610b8dfb954ff274d42450623233c96c479de2085b9c8344ba5abf1935
2022-03-31 12:19:22 +01:00
Hennadii Stepanov
174af33d5d
util: Add inotify_rm_watch to syscall sandbox (AllowFileSystem)
...
Github-Pull: bitcoin#24690
Rebased-From: f05a4cd
2022-03-31 10:38:11 +02:00
Hennadii Stepanov
ded10fe3ea
build: Fix Boost.Process test for Boost 1.78
...
Github-Pull: bitcoin#24523
Rebased-From: 532c64a
2022-03-31 10:38:09 +02:00
Hennadii Stepanov
26c2f23f36
build: Fix Boost.Process detection on macOS arm64
...
Could be tested as follows:
```
% brew install boost@1.76
% ./autogen.sh
% ./configure --with-boost='/opt/homebrew/opt/boost@1.76'
```
Github-Pull: bitcoin#24521
Rebased-From: 1d4157a
2022-03-31 10:37:15 +02:00
fanquake
85f85c7e5f
util: add linkat to syscall sandbox (AllowFileSystem)
...
Github-Pull: bitcoin#24659
Rebased-From: 9809db3
2022-03-31 10:30:14 +02:00
Sebastian Falbesoner
eaa04194b9
contrib: fix signet miner (sighash mismatch)
...
PSBT signing was changed to use SIGHASH_DEFAULT by default in #22514 .
The signet miner script sets the sighash type of the created PSBT to
SIGHASH_ALL, hence this leads to a sighash mismatch when the
`walletprocesspsbt` RPC is called. Fix this by explicitly passing the
correct sighash type.
Note that the same change was needed in one of our functional tests,
see commit d3992669df826899a3de78a77a366dab46028026.
Reported by gruve-p.
Github-Pull: bitcoin#24553
Rebased-From: 12cc020
2022-03-31 10:30:12 +02:00
MarcoFalke
235b042594
rpc: Exclude descriptor when address is excluded
...
Github-Pull: bitcoin#24636
Rebased-From: faf37c2
2022-03-31 10:30:10 +02:00
MarcoFalke
b05a59b69f
ci: Temporarily use clang-13 to work around clang-14 TSan bug
...
Github-Pull: bitcoin#24572
Rebased-From: fa43933
2022-03-31 10:30:07 +02:00
Jon Atack
65b966743c
doc, init: add links to doc/cjdns.md
...
Github-Pull: bitcoin#24663
Rebased-From: daae288
2022-03-31 10:30:05 +02:00
Jon Atack
7a553d4e65
doc: update i2p.md with cjdns, improve local addresses section
...
Github-Pull: bitcoin#24555
Rebased-From: f44efc3
2022-03-31 10:30:02 +02:00
Jon Atack
4148396229
doc: update tor.md with cjdns and getnodeaddresses, fix tor grep,
...
and improve local addresses section
Github-Pull: bitcoin#24555
Rebased-From: 3bf6f0c
2022-03-31 10:29:25 +02:00
Jon Atack
4690e8af13
doc: create initial doc/cjdns.md for cjdns how-to documentation
...
Adapted in part from the CJDNS description in #23077 by Vasil Dimov
and from CJDNS documentation and feedback by Caleb James DeLisle.
Co-authored-by: Vasil Dimov <vd@FreeBSD.org>
Github-Pull: bitcoin#24555
Rebased-From: ed15848
2022-03-31 10:28:29 +02:00
Jon Atack
5d24f612d1
Clarify in -maxtimeadjustment that only outbound peers influence time data
...
Github-Pull: bitcoin#24609
Rebased-From: 1bba72d
2022-03-28 12:49:51 +02:00
MarcoFalke
7d03cf632d
Merge bitcoin/bitcoin#24596 : [23.x] GUI backports
...
70f2c579b9de41f987e170f15c0ce767d9ad7931 options: flip listenonion to false if not listening (Vasil Dimov)
642f2726deaa1dad21912d4319fac0deb6dbb564 gui: restore Send for external signer (Sjors Provoost)
940694664de2a10b9d6d81ddff9be05495e6a3da refactor: helper function signWithExternalSigner() (Sjors Provoost)
fc421d4c8c8cdd94a5377a8004209506a089357b move-only: helper function to present PSBT (Sjors Provoost)
Pull request description:
Backports from the GUI repo:
- bitcoin-core/gui#555
- bitcoin-core/gui#568
ACKs for top commit:
Sjors:
utACK 70f2c579b9de41f987e170f15c0ce767d9ad7931
gruve-p:
ACK 70f2c579b9
2022-03-24 08:12:11 +01:00
Vasil Dimov
70f2c579b9
options: flip listenonion to false if not listening
...
If the user has unchecked "Allow incoming connections" in
`Settings->Options...->Network` then `fListen=false` is saved in
`~/.config/Bitcoin/Bitcoin-Qt.conf`. This flips `-listen` to `false`
during startup, but leaves `-listenonion` to `true`.
This flipping of `-listen` is done in `OptionsModel::Init()` after
`InitParameterInteraction()` has been executed which would have flipped
`-listenonion`, should it have seen `-listen` being `false`
(this is a difference between `bitcoind` and `bitcoin-qt`).
Fixes: https://github.com/bitcoin-core/gui/issues/567
Github-Pull: bitcoin-core/gui#568
Rebased-From: 7f90dc26c8938f348938929b6d8bf1ea6f149209
2022-03-23 17:26:19 +01:00
laanwj
55a60b9718
Merge bitcoin/bitcoin#24593 : [23.x] macOS / build backports
...
61c021605f8733891cb8d92509c84ac814d3712a doc, guix: Include arm64-apple-darwin into codesigned archs (Hennadii Stepanov)
f541a252f676dcdab15654e8b2b83b2dbcee46b3 doc: Drop a note about Intel-based Macs (Hennadii Stepanov)
dd2c7f71fd0f759d0d724ff182b508fc2db59131 guix: Use "win64" for Windows artifacts consistently (Hennadii Stepanov)
2e7cde8f6851be73477766bac00c4c922d79370f guix: Drop "-signed" suffix for signed macOS .dmg files (Hennadii Stepanov)
7f6420c833fe63e51ec094c1484969d29aac415b guix: Use $HOST instead of generic osx{64} for macOS artifacts (Hennadii Stepanov)
de528793b6912dd657c7197b1a01c2da708f0a1f Update signapple for platform identifier fix (Andrew Chow)
Pull request description:
Backports:
* #24549
* #24573
* #24588
* #24597
ACKs for top commit:
laanwj:
Code review ACK 61c021605f8733891cb8d92509c84ac814d3712a
Tree-SHA512: 023bfe6f1a31cec66f0255fb8e9c186f44a50a900a9f22c65b2da672b413fec7570f0f11626317344b6f91e74610006ffe0e35243af510de1eb8a3ceb8e8d37f
2022-03-17 09:47:42 +01:00
Hennadii Stepanov
61c021605f
doc, guix: Include arm64-apple-darwin into codesigned archs
...
Github-Pull: #24597
Rebased-From: 1f4801b6b197657b81daba52ef62c146fc6bd584
2022-03-17 08:38:58 +00:00
Sjors Provoost
642f2726de
gui: restore Send for external signer
...
Before this change the send confirmation dialog would keep the Send option disabled. The Create Unsigned choice would actually send. This is potentially confusing.
With this change the Create Unsigned button will not attempt to sign and always produce a PSBT. The Send button will attempt to sign, and only return a PSBT if more signatures are needed.
When using an external signer, the Create Unsigned option only appears when PSBT controls are enabled in the wallet settings.
This commit maintains the pre-existing behavior of filling the PSBT (without signing) even when not using an external signer.
Closes #551
Co-authored-by: Jon Atack <jon@atack.com>
Github-Pull: bitcoin-core/gui#555
Rebased-From: 2efdfb88aab6496dcf2b98e0de30635bc6bade85
2022-03-17 07:28:50 +01:00
Sjors Provoost
940694664d
refactor: helper function signWithExternalSigner()
...
Does not change behavior.
Review hint:
git show --color-moved --color-moved-ws=allow-indentation-change
Github-Pull: bitcoin-core/gui#555
Rebased-From: 4b5a6cd14967b8ec3cb525e4cb18628de6c15091
2022-03-17 07:28:50 +01:00
Sjors Provoost
fc421d4c8c
move-only: helper function to present PSBT
...
This commit does not change behavior.
Review hint:
git show --color-moved --color-moved-ws=allow-indentation-change
Github-Pull: bitcoin-core/gui#555
Rebased-From: 026b5b4523317fdefc69cf5cec55f76f18ad0c0a
2022-03-17 07:28:50 +01:00
Hennadii Stepanov
f541a252f6
doc: Drop a note about Intel-based Macs
...
Github-Pull: #24588
Rebased-From: e359ba6b35edebf02b968fe60cae48473ed88826
2022-03-16 20:51:32 +00:00
Hennadii Stepanov
dd2c7f71fd
guix: Use "win64" for Windows artifacts consistently
...
Github-Pull: #24549
Rebased-From: 53dd6165b8994301d638298906b006032e0bbe48
2022-03-16 20:50:30 +00:00
Hennadii Stepanov
2e7cde8f68
guix: Drop "-signed" suffix for signed macOS .dmg files
...
This change makes naming of the signed artifacts consistent across
different OSes, including Windows.
Github-Pull: #24549
Rebased-From: 4b4b04a66d8f088f6aa9ec6398db49d40481910f
2022-03-16 20:49:47 +00:00
Hennadii Stepanov
7f6420c833
guix: Use $HOST instead of generic osx{64} for macOS artifacts
...
Github-Pull: #24549
Rebased-From: 933a43018f0f1c0b72acbfa9de5e0f84bf49d0a2
2022-03-16 20:49:19 +00:00
Andrew Chow
de528793b6
Update signapple for platform identifier fix
...
Github-Pull: #24573
Rebased-From: 3c74f775ac956de4da4fc076b2360b687531cd63
2022-03-16 20:47:58 +00:00
Martin Zumsande
b1646f1bb5
test: set segwit height back to 0 on regtest
...
This was changed in #22818 from 0 to 1. Since it changes
BLOCK_OPT_WIT of the genesis block, older versions of bitcoin
core would not read regtest directories created with newer versions
without a reindex.
Github-Pull: bitcoin#24527
Rebased-From: 5ce3057
2022-03-13 17:43:36 +01:00
Jon Atack
ef6a37b7c4
rpc: rename getdeploymentinfo status-next to status_next
...
Github-Pull: bitcoin#24528
Rebased-From: 5d7c69b
2022-03-13 17:41:05 +01:00
