Timothy Redaelli
dfac636fd7
We should include netinet/in.h to use sockaddr_in (POSIX.1-2001)
2012-04-27 10:42:37 -04:00
Luke Dashjr
a93ab87787
Merge branch '0.4.x' into 0.5.x
...
Conflicts:
src/main.cpp
2012-04-22 10:05:43 -04:00
Timothy Redaelli
d0fe14ffec
Add missing includes. (Fix bulding under GCC 4.7)
...
(Note: GCC 4.7 build NOT tested with backports -Luke)
2012-04-22 09:41:51 -04:00
Dwayne C. Litzenberger
e5b980d72f
Fix bugs on 'unsigned char' platforms.
...
In ISO C++, the signedness of 'char' is undefined. On some platforms (e.g.
ARM), 'char' is an unsigned type, but some of the code relies on 'char' being
signed (as it is on x86). This is indicated by compiler warnings like this:
bignum.h: In constructor 'CBigNum::CBigNum(char)':
bignum.h:81:59: warning: comparison is always true due to limited range of data type [-Wtype-limits]
util.cpp: In function 'bool IsHex(const string&)':
util.cpp:427:28: warning: comparison is always false due to limited range of data type [-Wtype-limits]
In particular, IsHex erroneously returned true regardless of the input
characters, as long as the length of the string was a positive multiple of 2.
Note: For testing, it's possible using GCC to force char to be unsigned by
adding the -funsigned-char parameter to xCXXFLAGS.
2012-04-22 09:38:27 -04:00
Dwayne C. Litzenberger
bd043f19c8
Fix phexdigits[255] is undefined.
2012-04-22 09:26:11 -04:00
Pieter Wuille
e401e5eb79
Add missing breaks in optionmodel's switch case
2012-04-17 20:30:31 -04:00
Pieter Wuille
dc588faf59
Fix potential deadlock
...
Conflict:
* cs_main in ProcessMessages() (before calling ProcessMessages)
* cs_vSend in CNode::BeginMessage
versus:
* cs_vSend in ThreadMessageHandler2 (before calling SendMessages)
* cs_main in SendMessages
Even though cs_vSend is a try_lock, if it succeeds simultaneously with
the locking of cs_main in ProcessMessages(), it could cause a deadlock.
2012-04-17 15:11:48 -04:00
Jeff Garzik
7f34351910
Fix misc. minor sign-comparison warnings
2012-04-17 15:08:18 -04:00
Jeff Garzik
1b7e5cbcad
CNode's nHeaderStart may be negative, so change its type (PARTIAL)
2012-04-17 15:03:05 -04:00
Jeff Garzik
774e9b6dbb
Fix loop index var types, fixing many minor sign comparison warnings
...
foo.size() typically returns an unsigned integral type; make loop variables
match those types' signedness.
2012-04-17 14:57:42 -04:00
Jeff Garzik
ef2f3ddaf7
The string class returns string::npos, when find() fails.
...
Noticed when sign-comparison warnings were enabled.
2012-04-17 14:50:26 -04:00
Wladimir J. van der Laan
d506c160eb
Add forgotten initializer
2012-04-17 14:49:36 -04:00
Jeff Garzik
1175d8f6a1
AlreadyHave(): only hold lock during mapTransactions access
2012-04-17 14:40:58 -04:00
Jeff Garzik
12570da46f
Locking fix for AlreadyHave()
...
Access to mapTransactions[] must be guarded by cs_mapTransactions lock.
2012-04-17 13:20:29 -04:00
Wladimir J. van der Laan
e2ce6438a9
Set label when selecting an address that already has a label. Fixes #1080 .
2012-04-16 09:18:06 -04:00
Luke Dashjr
e73b792b1a
Merge branch '0.5.0.x' into 0.5.x
2012-04-15 21:06:10 -04:00
Luke Dashjr
79fc752b61
Merge branch '0.4.x' into 0.5.0.x
...
Conflicts:
src/keystore.h
2012-04-15 21:05:54 -04:00
Wladimir J. van der Laan
8460185dec
fix warnings: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]
2012-04-15 19:43:41 -04:00
Wladimir J. van der Laan
678a319888
fix warnings: delete called on 'XX' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
2012-04-15 19:42:19 -04:00
Wladimir J. van der Laan
fdcafa3535
fix warnings: unused variable 'XX' [-Wunused-variable]
2012-04-15 19:37:34 -04:00
Wladimir J. van der Laan
5f4fee559e
fix warnings: enumeration values 'XX' not handled in switch [-Wswitch-enum]
2012-04-15 19:28:48 -04:00
Wladimir J. van der Laan
c4381587a6
fix warnings: 'XX' defined as a struct here but previously declared as a class [-Wmismatched-tags]
2012-04-15 19:28:34 -04:00
Wladimir J. van der Laan
85e975f379
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
2012-04-15 19:28:09 -04:00
Wladimir J. van der Laan
f650d62fc6
fix warnings: array subscript is of type 'char' [-Wchar-subscripts]
2012-04-15 19:28:00 -04:00
Wladimir J. van der Laan
401db6d96b
work around issue in boost::program_options that prevents from compiling in clang
2012-04-15 19:23:01 -04:00
Wladimir J. van der Laan
cb1035a008
Show a message box when runaway exception happens
...
This is more clear to users than when the program simply disappears (usually during initialization). It still logs the message to the console and debug log as well.
2012-04-15 13:25:35 -04:00
Luke Dashjr
79940a6793
Merge commit 'e962c7f' into 0.5.0.x
2012-04-15 13:23:43 -04:00
Luke Dashjr
e962c7f532
Bugfix: nTotalBlocks wasn't in 0.5.0, so need to replace it with equivalent function call in backport
2012-04-15 13:23:34 -04:00
Luke Dashjr
02a38ac22b
Add symlink to scripts/qt/make_windows_icon.sh from old file name, just in case
2012-04-14 15:38:26 -04:00
Wladimir J. van der Laan
f2862f1a49
Rename make_windows_icon.py to .sh as it is a shell script ( fixes #1099 )
2012-04-14 15:38:05 -04:00
Wladimir J. van der Laan
a558054709
Do not show green tick unless all known blocks are downloaded ( fixes #921 )
2012-04-14 15:33:24 -04:00
Wladimir J. van der Laan
1f91797535
Add missing tooltip and key shortcut in settings dialog ( #1088 without line break part)
2012-04-14 15:33:03 -04:00
Gavin Andresen
e88b6b341d
Bug fix listtransactions from/count handling.
2012-04-14 15:29:43 -04:00
Wladimir J. van der Laan
1f56046fd5
Show error message instead of exception crash when unable to bind RPC port
...
Fixes issue #875
2012-04-11 15:54:30 -04:00
Luke Dashjr
9bf1140b90
Merge branch '0.5.0.x' into 0.5.x
2012-04-06 17:45:20 -04:00
Luke Dashjr
527b512cf7
Bugfix: Windows lacks sleep(), so need to use Sleep() from util.h
2012-04-06 17:44:48 -04:00
Luke Dashjr
892fcaf291
Merge branch '0.5.0.x' into 0.5.x
...
Conflicts:
src/qt/notificator.h
2012-04-06 16:34:34 -04:00
p2k
bf1f995c4c
Proper support for Growl 1.3 notifications
2012-04-06 16:31:09 -04:00
Luke Dashjr
ce33356094
Bugfix: Replace "URL" with "URI" where we aren't actually working with URLs
2012-04-06 14:46:30 -04:00
Luke Dashjr
a93bb51604
Merge branch 'strlcpy_attribute' into 0.5.0.x
2012-04-05 19:43:06 -04:00
Luke Dashjr
7993454a92
Document strlcpy.h in assets-attribution.txt since it isn't MIT-licensed
2012-04-05 18:58:20 -04:00
Luke Dashjr
0d10cb7a1f
Merge branch '0.5.0.x' into 0.5.x
2012-04-05 18:21:01 -04:00
Luke Dashjr
0af2f2d856
Merge branch '0.4.x' into 0.5.0.x
2012-04-05 18:20:18 -04:00
Pieter Wuille
c7057326ea
Verify status of encrypt/decrypt calls to detect failed padding
2012-04-05 18:03:48 -04:00
Wladimir J. van der Laan
53e596512c
Increase time ago of last block for "up to date" status from 30 to 90 minutes
...
It was too hyperactive.
gmaxwell: I mean that right now when the block gap goes over an hour it starts showing synchronizing. Increasing that to 90 minutes or so would make it only happen about 6.4 times per year
2012-04-04 16:00:04 -04:00
Matt Corallo
d02833c76a
Add laanwj to gitian download scripts.
2012-04-04 15:58:15 -04:00
Matt Corallo
bf754cfd01
Add laanwj to gitian download scripts.
2012-04-04 15:58:02 -04:00
Luke Dashjr
658cf0b1be
Merge branch '0.5.0.x' into 0.5.x
...
Conflicts:
src/qt/bitcoingui.h
2012-04-04 15:41:07 -04:00
Luke Dashjr
a37092fcf4
Merge branch '0.4.x' into 0.5.0.x
2012-04-04 15:36:25 -04:00
Wladimir J. van der Laan
91d7e847e0
Use a messagebox to display the error when -server is provided without providing a rpc password
...
(plus part of 7cfbe1fee465e82ddbdc8ed17dfcce791bd765f5)
2012-04-04 13:57:32 -04:00
