cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src
History
Wladimir J. van der Laan 9e8e813df5
Merge #18410: Docs: Improve commenting for coins.cpp|h 
21fa0a44abe8c1b5c452e097eab20cf0ae988805 [docs] use consistent naming for possible_overwrite (John Newbery)
2685c214cce4b07695273503e60350e3f05fe3e2 [tests] small whitespace fixup (John Newbery)
e9936966c08bd8a6ac02828131f619ddaa1ced13 scripted-diff: Rename PRUNED to SPENT in coins tests (John Newbery)
c205979031ff4e8e32a5f05bae813405f233fccd [docs] Improve commenting in coins.cpp|h (John Newbery)

Pull request description:

  - Add full commenting for spentness / DIRTYness / FRESHness and which combinations are valid
  - Remove the 'pruned' terminology, which doesn't make sense since per-txout chainstate db was merged (#10195).
  - Rename `potential_overwrite` to `possible_overwrite` to standardize terminology (there were previously examples of both, which made searching the codebase difficult).
  - Make other minor improvements to the comments

ACKs for top commit:
  jonatack:
    Re-ACK 21fa0a4 per `git diff 98bee55 21fa0a4` the only change since my previous review is the following code commenting diff in `src/coins.cpp::L177-179`;  rebuilt/ran unit tests anyway as a sanity check on the unit test changes.

Tree-SHA512: 391e01588ef5edb417250080cec17361f982c4454bc5f8c6d78bbd528c68a2bb94373297760691295c24660ce1022ad3ef7599762f736c8eed772ce096d38c3d
2020-04-22 14:23:56 +02:00
..
bench
Merge #18673: scripted-diff: Sort test includes
2020-04-17 10:12:13 -04:00
compat
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
config
…
consensus
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
Merge #17691: doc: Add missed copyright headers
2020-01-16 15:58:35 -05:00
index
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
interfaces
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
node
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
policy
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
primitives
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
qt
wallet: Refactor WalletRescanReserver to use wallet reference
2020-04-19 14:04:37 +01:00
rpc
Merge #17831: rpc: doc: Fix and extend getblockstats examples
2020-04-20 07:15:45 -04:00
script
Merge #18612: script: Remove undocumented and unused operator+
2020-04-22 14:17:01 +02:00
secp256k1
Update the secp256k1 subtree to the latest upstream version
2019-03-31 11:41:05 -07:00
support
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
test
Merge #18410: Docs: Improve commenting for coins.cpp|h
2020-04-22 14:23:56 +02:00
univalue
Update univalue subtree
2020-02-09 07:44:29 -08:00
util
Merge #18190: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-04-20 15:32:41 -04:00
wallet
Merge #17579: [refactor] Merge getreceivedby tally into GetReceived function
2020-04-20 10:05:32 -04:00
zmq
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
.clang-format
util: Add AllowShortCaseLabelsOnASingleLine option
2019-10-14 13:24:54 +03:00
addrdb.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrdb.h
Convert addrdb/addrman to new serialization
2020-01-02 11:05:36 -08:00
addrman.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
addrman.h
logging: asmap logging and #include fixups
2020-03-04 14:24:19 +01:00
amount.h
Update copyright headers to 2018
2018-12-29 10:15:01 +01:00
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
banman.h
refactor: move DUMP_BANS_INTERVAL to banman.h
2020-03-10 09:52:53 -04:00
base58.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
base58.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bech32.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
bitcoin-wallet-res.rc
[tools] Add wallet inspection and modification tool
2019-01-30 16:26:52 -05:00
bitcoin-wallet.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
blockencodings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockencodings.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
blockfilter.cpp
tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-04-20 14:57:48 +00:00
blockfilter.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.cpp
refactor: Remove unused methods CBloomFilter::reset()/clear()
2020-04-17 01:09:39 +02:00
bloom.h
refactor: Remove unused methods CBloomFilter::reset()/clear()
2020-04-17 01:09:39 +02:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparams.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparams.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparamsbase.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsbase.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.20
2020-04-03 16:29:26 +02:00
checkqueue.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
[docs] use consistent naming for possible_overwrite
2020-04-21 14:19:15 -04:00
coins.h
Merge #18410: Docs: Improve commenting for coins.cpp|h
2020-04-22 14:23:56 +02:00
compat.h
windows: Set _WIN32_WINNT to 0x0601 (Windows 7)
2019-01-23 16:28:27 +08:00
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
core_write.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
cuckoocache.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
2020-04-08 14:45:27 +00:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dummywallet.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
fs.cpp
scripted-diff: Add missed copyright headers
2020-01-04 20:18:28 +02:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 0b70241850..b19c000063
2019-03-31 11:41:05 -07:00
httprpc.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
httprpc.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httpserver.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
httpserver.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
indirectmap.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
Do not expose and consider -logthreadnames when it does not work
2020-04-20 14:17:49 +03:00
init.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
logging.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
Makefile.am
Merge #18190: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-04-20 15:32:41 -04:00
Makefile.bench.include
Merge #18429: build: remove double LIBBITCOIN_SERVER from bench-Makefile
2020-03-26 17:20:28 +08:00
Makefile.crc32c.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.leveldb.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.qt_locale.include
qt: Translations update pre-branch
2020-04-01 12:49:15 +02:00
Makefile.qt.include
Revert "Merge #16367: Multiprocess build support"
2020-04-10 19:38:21 -04:00
Makefile.qttest.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
Makefile.test_fuzz.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.test_util.include
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
Makefile.test.include
Merge #18190: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode)
2020-04-20 15:32:41 -04:00
memusage.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
merkleblock.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
merkleblock.h
…
miner.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
miner.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
net_permissions.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
net_permissions.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
net_processing.cpp
Merge #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear')
2020-04-20 06:59:53 -04:00
net_processing.h
net: Add missing cs_vNodes lock
2020-03-29 11:45:46 -04:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
net: Add missing cs_vNodes lock
2020-03-29 11:45:46 -04:00
net.h
Merge #18544: net: limit BIP37 filter lifespan (active between 'filterload'..'filterclear')
2020-04-20 06:59:53 -04:00
netaddress.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
netaddress.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
netbase.cpp
Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.
2020-01-22 20:20:45 +01:00
netbase.h
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
noui.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
outputtype.h
List output types in an array in order to be iterated over
2020-01-23 16:35:06 -05:00
pow.cpp
…
pow.h
…
prevector.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
protocol.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
protocol.h
net: Fail instead of truncate command name in CMessageHeader
2020-02-06 13:24:40 +01:00
psbt.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
psbt.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
pubkey.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pubkey.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
random.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
random.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
randomenv.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
reverse_iterator.h
…
scheduler.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
scheduler.h
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
serialize.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
shutdown.cpp
…
shutdown.h
…
span.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
streams.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
sync.cpp
util: Remove unused itostr
2020-03-27 08:59:06 -04:00
sync.h
refactor: Add interfaces::FoundBlock class to selectively return block data
2020-03-31 08:36:02 -05:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
timedata.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
torcontrol.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
txdb.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
txmempool.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
txmempool.h
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
ui_interface.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
ui_interface.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
uint256.cpp
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
uint256.h
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
undo.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
validation.cpp
Merge #18410: Docs: Improve commenting for coins.cpp|h
2020-04-22 14:23:56 +02:00
validation.h
protect g_chainman with cs_main
2020-03-17 14:07:58 -04:00
validationinterface.cpp
Do not clear validationinterface entries being executed
2020-04-07 12:53:40 -07:00
validationinterface.h
refactor: drop boost::signals2 in validationinterface
2020-04-04 11:44:39 -04:00
version.h
…
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00