MarcoFalke f7c19e829e

Merge #19320: wallet: Replace CDataStream& with CDataStream&& where appropriate ...

fa8a341b88cabfd7f8d702db7cb9972b0804bf2a wallet: Replace CDataStream& with CDataStream&& where appropriate (MarcoFalke)
fa021e9a5b7e930a3db0febb416942dea3a90a8f wallet: Remove confusing double return value ret+success (MarcoFalke)

Pull request description:

  The keys and values are only to be used once because their memory is set
  to zero. Make that explicit by moving the bytes into the lower level
  methods.

ACKs for top commit:
  sipa:
    utACK fa8a341b88cabfd7f8d702db7cb9972b0804bf2a
  ryanofsky:
    Code review ACK fa8a341b88cabfd7f8d702db7cb9972b0804bf2a. Nice changes.

Tree-SHA512: 5c0218bae0f3cd2a07346f1bbf4ad232e5dde7ef2f807d82cc6cfd208d11fe60c8b0f37e7986087b52fbfc79cdfd33c3c8a5822b3d4d9a44d1c6b09e354fc424

2020-07-09 01:01:21 +02:00

..

test

Merge #19277: util: Add Assert identity function

2020-07-04 08:44:45 -04:00

bdb.cpp

Merge #19320: wallet: Replace CDataStream& with CDataStream&& where appropriate

2020-07-09 01:01:21 +02:00

bdb.h

Merge #19320: wallet: Replace CDataStream& with CDataStream&& where appropriate

2020-07-09 01:01:21 +02:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Move ui_interface to the node lib

2020-06-27 11:49:28 -04:00

ismine.h

…

load.cpp

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

load.h

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

rpcdump.cpp

Merge #19114: scripted-diff: TxoutType C++11 scoped enum class

2020-06-28 14:20:00 -04:00

rpcwallet.cpp

Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO

2020-07-02 16:10:49 +02:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

salvage.h

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

scriptpubkeyman.cpp

Merge #19215: psbt: Include and allow both non_witness_utxo and witness_utxo for segwit inputs

2020-07-03 09:23:22 +12:00

scriptpubkeyman.h

FillPSBT: report number of inputs signed (or would sign)

2020-06-18 23:32:59 -07:00

wallet.cpp

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

wallet.h

Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO

2020-07-02 16:10:49 +02:00

walletdb.cpp

Merge #19324: wallet: Move BerkeleyBatch static functions to BerkeleyDatabase

2020-07-05 18:06:00 -04:00

walletdb.h

Add Create*WalletDatabase functions

2020-06-17 12:31:29 -04:00

wallettool.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

wallettool.h

…

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00