cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src/wallet
History
MarcoFalke 6c156e49cb
Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore 
fa4e088cbac035b8029a10b492849540150d0622 wallet: Mark replaced tx to not be in the mempool anymore (MarcoFalke)

Pull request description:

  The wallet does not mark the replaced tx as out-of-mempool. This causes failures in user scripts, because later RPCs may depend on this state change from `bumpfee`.

  For example, the following might fail on current master:

  ```
  txid = sendtoaddress(...)
  bumpfee(txid)
  abandontransaction(txid)  # fails because txid is still marked as "in mempool"
  ```

  Fixes #18831

ACKs for top commit:
  meshcollider:
    utACK fa4e088cbac035b8029a10b492849540150d0622
  ryanofsky:
    Code review ACK fa4e088cbac035b8029a10b492849540150d0622, and previous ACK faeedff5c87091fd83d2fb2b29eb49c948363f29 is also still valid in case there's a preference for the original fix

Tree-SHA512: 9858f40f5fb5a43a7b584b5c4268b6befa82e6a84583be5206fe721bcb6c255e8d35479d347d0b9aed72703df49887c02b14ab680e8efdd28b90dd6b93d9439a
2021-03-09 07:54:18 +01:00
..
test
Change BOOST_CHECK to BOOST_CHECK_EQUAL to see mismatched values when a check fails.
2021-02-09 15:00:02 +01:00
bdb.cpp
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
bdb.h
wallet: Add BerkeleyDB version sanity check at init time
2021-01-17 18:10:20 +01:00
coincontrol.cpp
…
coincontrol.h
…
coinselection.cpp
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
coinselection.h
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
context.cpp
…
context.h
wallet: Pass unused args to StartWallets
2020-07-09 13:07:37 +02:00
crypter.cpp
…
crypter.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
db.cpp
wallet: List all wallets in non-SQLite or non-BDB builds
2020-12-04 11:03:28 -04:00
db.h
refactor: Consolidate redundant wallet database path and exists functions
2020-12-04 11:03:28 -04:00
dump.cpp
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
dump.h
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
external_signer_scriptpubkeyman.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
external_signer_scriptpubkeyman.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
feebumper.cpp
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
feebumper.h
…
fees.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fees.h
…
init.cpp
wallet: fix doc typo in signer option
2021-02-23 11:05:13 -08:00
interfaces.cpp
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
ismine.h
doc: Add developer documentation to isminetype
2021-01-19 19:04:45 +08:00
load.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
load.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
rpcdump.cpp
wallet: listdescriptors uses normalized descriptor form
2021-02-23 08:51:01 +01:00
rpcsigner.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
rpcsigner.h
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
rpcwallet.cpp
Merge #18466: rpc: fix invalid parameter error codes for {sign,verify}message RPCs
2021-03-01 11:45:42 +01:00
rpcwallet.h
Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
2020-09-22 20:49:30 +02:00
salvage.cpp
refactor: Drop call to GetWalletEnv in wallet salvage code
2020-12-04 11:03:28 -04:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
scriptpubkeyman.h
wallet: ExternalSigner: add GetDescriptors method
2021-02-23 14:34:31 +01:00
sqlite.cpp
refactor: Consolidate redundant wallet database path and exists functions
2020-12-04 11:03:28 -04:00
sqlite.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
wallet.cpp
Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore
2021-03-09 07:54:18 +01:00
wallet.h
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
walletdb.cpp
wallet: load flags before everything else
2021-02-09 19:01:15 +01:00
walletdb.h
Include wallet/bdb.h where it is actually being used
2020-11-18 11:55:43 -05:00
wallettool.cpp
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
wallettool.h
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
walletutil.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
walletutil.h
wallet: add external_signer flag
2021-02-23 14:34:30 +01:00