fanquake
1e7564eca8
Merge bitcoin/bitcoin#24251: Re-enable windows path tests disabled by #20744
...
d216bc8d76d7f4e9dce58b0bb732a2d4deaf23b6 Re-enable walletinit_verify_walletdir_no_trailing2 test disabled in #20744 (Ryan Ofsky)
80cd64e84296f1166e133c237fa0afc046b01ce2 Re-enable util_datadir check disabled in #20744 (Ryan Ofsky)
Pull request description:
Reenable some broken tests as discussed https://github.com/bitcoin/bitcoin/pull/20744#discussion_r798651736 and https://github.com/bitcoin/bitcoin/pull/20744#discussion_r798678137
Fix windows test cases broken in #20744 , by passing normalized path arguments to fs::equivalent, fs::exists, and fs::is_directory, instead of non-normalized arguments. Also re-enable the tests.
It is possible these changes also fix real init behavior on windows when -datadir or -walletdir paths with trailing dots or dashes are used, but it's not clear because I only tested on wine.
ACKs for top commit:
hebasto:
ACK d216bc8d76d7f4e9dce58b0bb732a2d4deaf23b6, I have reviewed the code and it looks OK, I agree it can be merged.
Tree-SHA512: 2099ddfa1a3ad70f7ac2ff413929414a1851d257b280da25c0f5cefb46fd1372b580a1f1ee5280681a1c16e6031f119185cadd4f7a6121298562cf001f711068
2022-02-05 20:02:41 +08:00
..
2022-02-04 09:33:41 -05:00
2022-02-01 11:19:18 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-30 08:59:10 -03:00
2022-01-25 20:43:12 +01:00
2022-01-06 22:14:16 -05:00
2022-01-25 10:16:06 +01:00
2021-12-30 19:36:57 +02:00
2022-02-04 22:47:49 +08:00
2022-01-31 09:27:12 +01:00
2022-01-17 12:24:43 +00:00
2022-01-26 15:10:44 +01:00
2022-02-04 12:39:07 +02:00
2022-02-03 18:35:52 +08:00
2022-01-27 19:19:12 +01:00
2021-12-15 09:19:50 -05:00
2022-01-02 11:40:31 +01:00
2022-02-05 20:02:41 +08:00
2021-10-11 20:45:56 +08:00
2022-02-04 09:09:09 -05:00
2022-02-04 09:10:19 -05:00
2022-01-31 16:53:12 +01:00
2021-11-12 11:46:34 +01:00
2022-02-03 18:35:52 +08:00
2021-12-30 19:36:57 +02:00
2021-12-28 21:54:51 +01:00
2022-01-04 23:08:11 +08:00
2022-01-04 23:08:11 +08:00
2022-01-13 15:56:59 +01:00
2022-01-28 19:27:25 +00:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-06 14:17:41 +13:00
2021-12-06 14:17:41 +13:00
2021-12-30 19:36:57 +02:00
2022-01-28 15:26:24 +01:00
2021-12-30 19:36:57 +02:00
2022-01-06 22:14:16 -05:00
2022-01-06 22:14:16 -05:00
2022-01-06 11:29:55 -05:00
2022-01-25 10:49:46 +01:00
2022-01-31 09:23:54 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-26 12:58:23 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-26 09:56:51 +08:00
2022-01-07 13:37:47 -05:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-06 22:14:16 -05:00
2021-12-30 19:36:57 +02:00
2022-02-03 18:35:52 +08:00
2022-02-03 18:35:52 +08:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-13 18:35:25 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-04 09:25:36 +01:00
2022-01-06 22:14:16 -05:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-02-03 18:35:52 +08:00
2022-02-03 18:35:52 +08:00
2022-01-06 11:27:06 -05:00
2021-12-20 10:53:01 -05:00
2021-10-15 01:02:45 +00:00
2021-10-21 09:37:30 +08:00
2022-02-04 13:43:36 +01:00
2021-12-20 10:53:01 -05:00
2021-12-20 10:53:01 -05:00
2021-12-20 10:53:01 -05:00
2021-12-20 10:53:01 -05:00
2021-10-11 20:46:25 +08:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-25 20:43:37 +01:00
2022-01-25 18:48:41 +01:00
2021-12-14 18:58:45 +01:00
2021-12-30 19:36:57 +02:00
2022-02-04 09:24:17 +01:00
2022-02-04 09:24:17 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2022-01-13 15:55:01 +01:00
2022-01-30 08:59:10 -03:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-06 22:14:16 -05:00
2022-01-14 13:25:23 +01:00
2022-01-14 13:27:41 +01:00
2022-01-02 11:52:11 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:13:40 +01:00
2022-01-02 11:40:31 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-01-28 20:52:53 +01:00
2022-01-28 20:52:53 +01:00
2022-01-25 11:20:18 +08:00
2022-01-25 11:20:18 +08:00
2021-12-30 19:36:57 +02:00
2022-01-02 11:40:31 +01:00
2022-01-31 11:00:40 +01:00
2022-01-31 11:00:40 +01:00
2022-01-28 08:46:03 +01:00
2022-01-28 08:46:03 +01:00
2022-01-06 22:14:16 -05:00
2021-12-30 19:36:57 +02:00