MarcoFalke a3af5b5c13

Merge #17138: Remove wallet access to some node arguments ...

b96ed0396294fc4fa89d83ceab6bc169dd09f002 [wallet] Remove pruning check for -rescan option (John Newbery)
eea462de9c652dca556ad241d2126b10790f67f8 [wallet] Remove package limit config access from wallet (John Newbery)

Pull request description:

  Removes wallet access to `-limitancestorcount`, `-limitdescendantcount` and `-prune`:

  - `-limitancestorcount` and `-limitdescendantcount` are now accessed with a method `getPackageLimits` in the `Chain` interface.
  - `-prune` is not required. It was only used in wallet component initiation to prevent running `-rescan` when pruning was enabled. This check is not required.

  Partially addresses #17137.

ACKs for top commit:
  MarcoFalke:
    Tested ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  ryanofsky:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  promag:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002.
  ariard:
    ACK b96ed03, check there isn't left anymore wallet access to node arguments.

Tree-SHA512: 90c8e3e083acbd37724f1bccf63dab642cf9ae95cc5e684872a67443ae048b4fdbf57b52ea47c5a1da6489fd277278fe2d9bbe95e17f3d4965a1a0fbdeb815bf

2019-10-15 14:59:43 -04:00

..

test

Merge #16786: test: add unit test for wallet watch-only methods involving PubKeys

2019-10-10 12:12:54 -04:00

coincontrol.cpp

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coincontrol.h

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coinselection.cpp

Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection

2018-12-12 14:22:12 -08:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

crypter.h

Remove CCryptoKeyStore and move all of it's functionality into CWallet

2019-07-09 16:20:18 -04:00

db.cpp

Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record

2019-07-27 22:45:31 +12:00

db.h

Merge #15588: Log the actual wallet file version and no longer publicly expose the "version" record

2019-07-27 22:45:31 +12:00

feebumper.cpp

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

[wallet] abort when attempting to fund a transaction above maxtxfee

2019-06-28 22:44:38 -04:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

[wallet] Remove pruning check for -rescan option

2019-10-14 13:39:25 -04:00

ismine.cpp

Move various SigningProviders to signingprovider.{cpp,h}

2019-07-09 16:20:18 -04:00

ismine.h

Change ismine to take a CWallet instead of CKeyStore

2019-06-19 18:06:30 -04:00

load.cpp

scripted-diff: Make translation bilingual

2019-07-24 16:33:20 +03:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

psbtwallet.cpp

Merge #15427: Add support for descriptors to utxoupdatepsbt

2019-07-02 16:53:22 +02:00

psbtwallet.h

Remove unused TransactionError constants

2019-02-14 10:32:02 -05:00

rpcdump.cpp

Encapsulate tx status in a Confirmation struct

2019-08-23 14:53:20 -04:00

rpcwallet.cpp

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

rpcwallet.h

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

wallet.cpp

[wallet] Remove package limit config access from wallet

2019-10-14 13:32:41 -04:00

wallet.h

Merge #16524: Wallet: Disable -fallbackfee by default

2019-10-02 13:42:57 -04:00

walletdb.cpp

wallet: Drop unused OldKey

2019-07-31 18:35:46 +01:00

walletdb.h

Add setting as known type

2019-07-30 06:36:34 +01:00

wallettool.cpp

scripted-diff: Replace fprintf with tfm::format

2019-06-13 10:32:52 -04:00

wallettool.h

Move ismine to wallet module

2019-06-19 18:06:30 -04:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

wallet: Add WalletLocation utility class

2018-10-25 11:53:17 +01:00