cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src/wallet
History
W. J. van der Laan 5c9b06db81
Merge #21302: wallet: createwallet examples for descriptor wallets 
5039e0e55a7c9dd63a38c12fa60d244592de69e0 test: HelpExampleCliNamed and HelpExampleRpcNamed (Ivan Metlushko)
591735ef0bf13b94643b794518406f981fa5dcb7 rpc: Add HelpExampleCliNamed and use it for `createwallet` doc (Wladimir J. van der Laan)
5d5a90e819d23a302f9bec6b995a3116ead6ae94 rpc: Add HelpExampleRpcNamed (Ivan Metlushko)

Pull request description:

  Rationale: make descriptor wallets more visible and just a bit easier to setup

  `bitcoin-cli help createwallet`

  **Before**:
  ```
  Examples:
  > bitcoin-cli createwallet "testwallet"
  > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["testwallet"]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
  ```

  **After**
  ```
  Examples:
  > bitcoin-cli createwallet "testwallet"
  > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["testwallet"]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
  > bitcoin-cli createwallet "descriptors" false false "" true true true
  > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id": "curltest", "method": "createwallet", "params": ["descriptors", false, false, "", true, true, true]}' -H 'content-type: text/plain;' http://127.0.0.1:8332/
  ```

ACKs for top commit:
  laanwj:
    Tested ACK 5039e0e55a7c9dd63a38c12fa60d244592de69e0

Tree-SHA512: d37210e6ce639addee881377092d8f6fb2a537a60a259c561899e24cf68a0254d7ff45a213573c938f626677e46770cd21113aae5974f26c66b9a2e137699c14
2021-04-05 15:31:41 +02:00
..
test
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
bdb.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
bdb.h
wallet: Add BerkeleyDB version sanity check at init time
2021-01-17 18:10:20 +01:00
coincontrol.cpp
…
coincontrol.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
coinselection.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
coinselection.h
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
context.cpp
Remove g_rpc_chain global
2020-05-28 02:13:19 -04:00
context.h
wallet: Pass unused args to StartWallets
2020-07-09 13:07:37 +02:00
crypter.cpp
…
crypter.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
db.cpp
wallet: List all wallets in non-SQLite or non-BDB builds
2020-12-04 11:03:28 -04:00
db.h
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
dump.cpp
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
dump.h
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
external_signer_scriptpubkeyman.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
external_signer_scriptpubkeyman.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
feebumper.cpp
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
feebumper.h
…
fees.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fees.h
…
init.cpp
Add new format string placeholders for walletnotify to include relevant block information for transactions
2021-03-15 18:45:36 +02:00
interfaces.cpp
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
ismine.h
doc: Add developer documentation to isminetype
2021-01-19 19:04:45 +08:00
load.cpp
remove unnecessary newline from initWarning() argument
2021-03-24 04:31:48 -06:00
load.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
rpcdump.cpp
Merge #21063: wallet, rpc: update listdescriptors response format
2021-04-02 13:18:35 +08:00
rpcsigner.cpp
rpc: don't require wallet for enumeratesigners
2021-03-11 15:15:14 +01:00
rpcsigner.h
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
rpcwallet.cpp
Merge #21302: wallet: createwallet examples for descriptor wallets
2021-04-05 15:31:41 +02:00
rpcwallet.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
salvage.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
scriptpubkeyman.h
wallet: ExternalSigner: add GetDescriptors method
2021-02-23 14:34:31 +01:00
sqlite.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
sqlite.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
wallet.cpp
Merge #21040: wallet: Fix already-loading message grammar
2021-03-21 07:51:11 +01:00
wallet.h
Merge #21415: refactor: remove Optional & nullopt
2021-03-17 12:17:33 +01:00
walletdb.cpp
refactor: post Optional<> removal cleanups
2021-03-17 14:56:20 +08:00
walletdb.h
Include wallet/bdb.h where it is actually being used
2020-11-18 11:55:43 -05:00
wallettool.cpp
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
wallettool.h
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
walletutil.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
walletutil.h
wallet: add external_signer flag
2021-02-23 14:34:30 +01:00