Wladimir J. van der Laan f8cc2b967b

Merge #17267: bench: Fix negative values and zero for -evals flag ...

3bb0a4674f74d22043c7911ea76ab8a4d93fed62 bench: Fix negative values and zero for -evals flag (nijynot)

Pull request description:

  This PR makes `bench_bitcoin -evals=0` evaluate at once and throws when `-evals` is a negative integer.

  ---

  Currently when you run `bench_bitcoin -evals=0`, it'll get stuck at
  ```
  # Benchmark, evals, iterations, total, min, max, median
  ```
  . This is not intuitively expected and should instead evaluate instantly as it's set to zero. Negative integers for `-evals` does not make sense either and should throw if set.

ACKs for top commit:
  laanwj:
    ACK 3bb0a4674f74d22043c7911ea76ab8a4d93fed62

Tree-SHA512: 03cd4c7c55134c7ffd8cdb6ee993551ce41061a73e13c3c047247af9df1fd7ed07d798272b643ec864099036922aaadbdcd2b798d710406f48df60b9d5448c26

2019-10-28 14:14:11 +01:00

..

data

Add deserialize + CheckBlock benchmarks, and a full block hex

2016-11-09 11:27:59 -08:00

.gitignore

Ignore bench_bitcoin binary.

2015-10-06 17:46:12 +02:00

base58.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

bech32.cpp

Make reasoning about dependencies easier by not including unused dependencies

2019-06-02 17:15:23 +02:00

bench_bitcoin.cpp

bench: Fix negative values and zero for -evals flag

2019-10-28 13:07:38 +01:00

bench.cpp

[refactor] interfaces: Add missing LockAnnotation for cs_main

2019-05-13 14:46:01 -04:00

bench.h

Remove unused includes

2019-10-15 22:56:43 +00:00

block_assemble.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

ccoins_caching.cpp

Move various SigningProviders to signingprovider.{cpp,h}

2019-07-09 16:20:18 -04:00

chacha20.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

chacha_poly_aead.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

checkblock.cpp

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

checkqueue.cpp

Make reasoning about dependencies easier by not including unused dependencies

2019-06-02 17:15:23 +02:00

coin_selection.cpp

bitcoin-wallet tool: Drop MakeChain calls

2019-04-10 09:51:37 -04:00

crypto_hash.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

data.cpp

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

data.h

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

duplicate_inputs.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

examples.cpp

Make reasoning about dependencies easier by not including unused dependencies

2019-06-02 17:15:23 +02:00

gcs_filter.cpp

blockfilter: Refactor GCS params into struct.

2018-11-06 09:12:54 -08:00

lockedpool.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

mempool_eviction.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

merkle_root.cpp

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

poly1305.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

prevector.cpp

Drop defunct IS_TRIVIALLY_CONSTRUCTIBLE handling from prevector.h

2018-11-14 12:19:04 -05:00

rollingbloom.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

rpc_blockchain.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

rpc_mempool.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

util_time.cpp

util: Add type safe GetTime

2019-05-23 14:12:32 -04:00

verify_script.cpp

refactor: test/bench: dedup Build{Crediting,Spending}Transaction()

2019-10-23 01:59:32 +02:00

wallet_balance.cpp

Make reasoning about dependencies easier by not including unused dependencies

2019-06-02 17:15:23 +02:00