History

Wladimir J. van der Laan 6b6e854362

Merge #9662 : Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets

a3fa4d6a6acf19d640a1d5879a00aa1f059e2380 QA: Fix bug in -usecli logic that converts booleans to non-lowercase strings (Jonas Schnelli)
4704e5f074e57782d058404a594a7313cf170cf0 [QA] add createwallet disableprivatekey test (Jonas Schnelli)
c7b8f343e99d9d53ea353ddce9a977f1886caf30 [Qt] Disable creating receive addresses when private keys are disabled (Jonas Schnelli)
2f15c2bc20d583b4c1788da78c9c635c36e03ed0 Add disable privatekeys option to createwallet (Jonas Schnelli)
cebefba0855cee7fbcb9474b34e6779369e8e9ce Add option to disable private keys during internal wallet creation (Jonas Schnelli)
9995a602a639b64a749545b7c3bafbf67f97324f Add facility to store wallet flags (64 bits) (Jonas Schnelli)

Pull request description:

  This mode ('createwallet {"disableprivatekeys": true}') is intended for a sane pure watch-only mode, ideal for a use-case where one likes to use Bitcoin-Core in conjunction with a hardware-wallet or another solutions for cold-storage.

  Since we have support for custom change addresses in `fundrawtransaction`, pure watch-only wallets including coin-selection are possible and do make sense for some use cases.

  This new mode disables all forms of private key generation and ensure that no mix between hot and cold keys are possible.

Tree-SHA512: 3ebe7e8d54c4d4e5f790c348d4c292d456f573960a5b04d69ca5ef43a9217c7e7671761c6968cdc56f9a8bc235f3badd358576651af9f10855a0eb731f3fc508

2018-07-20 14:28:50 +02:00

handler.cpp

Extract MakeUnique into utilmemory.h

2018-07-17 13:56:21 -04:00

handler.h

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

node.cpp

Break circular dependency: init -> * -> init by extracting shutdown.h

2018-06-25 00:08:49 -04:00

node.h

Give an error and exit if there are unknown parameters

2018-05-30 11:27:50 -04:00

README.md

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

wallet.cpp

Merge #9662 : Add createwallet "disableprivatekeys" option: a sane mode for watchonly-wallets

2018-07-20 14:28:50 +02:00

wallet.h

[Qt] Disable creating receive addresses when private keys are disabled

2018-07-12 20:32:07 +01:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #10973.
Chain::Client — used by node to start & stop Chain clients. Added in #10973.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.