cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src/interfaces
History
Wladimir J. van der Laan a22b62481a
Merge #17070: wallet: Avoid showing GUI popups on RPC errors 
facec1c643105d0ae74b5d32cf33d593f9e82a36 wallet: Avoid showing GUI popups on RPC errors (MarcoFalke)

Pull request description:

  RPC errors and warnings are shown as popups in the GUI instead of being returned to the RPC caller. For example,

  ```
  $ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
  error code: -4
  error message:
  Wallet loading failed.
  ```

  gives me a GUI popup and no reason why loading the wallet failed.

  After this pull request:

  ```
  $ ./src/bitcoin-cli loadwallet $(pwd)/./test/functional/data/wallets/high_minversion/
  error code: -4
  error message:
  Wallet loading failed: Error loading /home/marco/workspace/btc_bitcoin_core/./test/functional/data/wallets/high_minversion/wallet.dat: Wallet requires newer version of Bitcoin Core

ACKs for top commit:
  laanwj:
    Code review ACK facec1c643105d0ae74b5d32cf33d593f9e82a36

Tree-SHA512: c8274bbb02cfcf71676eeec1e773e51fb3538cf93f82e7cb8536f4716d44ed819cdc162dfc039ac7386a4db381a734cdb27fd32567043a1180c02519fbcba194
2019-10-21 13:48:27 +02:00
..
chain.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
chain.h
[wallet] Remove package limit config access from wallet
2019-10-14 13:32:41 -04:00
handler.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
handler.h
scripted-diff: Avoid interface keyword to fix windows gitian build
2018-04-07 03:42:02 -04:00
node.cpp
Merge #17070: wallet: Avoid showing GUI popups on RPC errors
2019-10-21 13:48:27 +02:00
node.h
wallet: Avoid showing GUI popups on RPC errors
2019-10-08 13:02:14 -04:00
README.md
Suggested interfaces::Chain cleanups from #15288
2019-03-04 15:57:58 -05:00
wallet.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
wallet.h
Get rid of PendingWalletTx class.
2019-07-18 12:06:23 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.