cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src
History
MarcoFalke a840dab2a5
Merge #18541: rpc: Make verifychain default values static, not depend on global args 
fad691cafe083743a26f434488990f060ae4ac45 rpc: Make verifychain default values static, not depend on global args (MarcoFalke)

Pull request description:

  This fixes several issues:

  * The documentation is not compile-time static and depends on run-time arguments, making it impossible to host it on a static resource like a website or pdf. See also a similar change in the wallet rpc code: #18499
  * The same call (relying on default values) will run different code on different machines, depending on the command line args that were used to start the server. This might lead to hard-to-debug-remote issues.

  This is a small behaviour change, and I will add release notes.

ACKs for top commit:
  theStack:
    ACK fad691cafe
  promag:
    Code review ACK fad691cafe083743a26f434488990f060ae4ac45.

Tree-SHA512: 1c7a253ff0ec13a973b10d3777b71c70954ded5805b65a3ab06317327014de4cd0601d71d30c6ce89a581722c150cb5567acc1bd3e0c789cb51bab6ef0dcfc4a
2020-04-10 11:21:57 -04:00
..
bench
Fix wallet unload race condition
2020-03-27 15:17:35 +00:00
compat
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
config
…
consensus
Update merkle.cpp
2020-03-18 10:34:53 -07:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
Merge #17691: doc: Add missed copyright headers
2020-01-16 15:58:35 -05:00
index
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
interfaces
Wallet: Replace CAddressBookData.name with GetLabel() method
2020-04-06 20:52:04 +00:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
doc: Correct spelling errors in comments
2020-03-02 23:07:21 -08:00
node
doc: Correct spelling errors in comments
2020-03-02 23:07:21 -08:00
policy
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
primitives
Check for overflow when calculating sum of outputs
2020-03-23 16:36:24 +02:00
qt
qt: Fix Window -> Minimize menu item
2020-04-07 00:19:19 +03:00
rpc
Merge #18541: rpc: Make verifychain default values static, not depend on global args
2020-04-10 11:21:57 -04:00
script
Merge #18388: Make VerifyWitnessProgram use a Span stack
2020-03-27 14:49:50 +08:00
secp256k1
…
support
Merge #15600: lockedpool: When possible, use madvise to avoid including sensitive information in core dumps
2020-03-26 16:56:03 +01:00
test
Merge #18529: Add fuzzer version of randomized prevector test
2020-04-09 15:00:57 -04:00
univalue
Update univalue subtree
2020-02-09 07:44:29 -08:00
util
build: Detect gmtime_* definitions via configure
2020-04-02 12:31:54 +08:00
wallet
Merge #18532: rpc: Avoid initialization-order-fiasco on static CRPCCommand tables
2020-04-07 23:46:17 +08:00
zmq
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
.clang-format
…
addrdb.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
addrdb.h
Convert addrdb/addrman to new serialization
2020-01-02 11:05:36 -08:00
addrman.cpp
logging: asmap logging and #include fixups
2020-03-04 14:24:19 +01:00
addrman.h
logging: asmap logging and #include fixups
2020-03-04 14:24:19 +01:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
banman.h
refactor: move DUMP_BANS_INTERVAL to banman.h
2020-03-10 09:52:53 -04:00
base58.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
base58.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace std::to_string with locale-independent alternative
2020-03-14 12:23:01 -07:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
bitcoin-wallet: Use PACKAGE_NAME in usage help
2020-01-14 18:19:00 +00:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
blockencodings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockencodings.h
Convert blockencodings.h to new serialization framework
2020-02-25 14:10:44 -08:00
blockfilter.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
blockfilter.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bloom.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
chainparams.cpp
chainparams: Bump assumed valid hash
2020-04-02 05:34:47 +08:00
chainparams.h
[test] add chainparams property to indicate chain allows time mocking
2020-02-13 08:59:51 -08:00
chainparamsbase.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsbase.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.20
2020-04-03 16:29:26 +02:00
checkqueue.h
refactor: Remove redundant conditional
2020-01-21 14:07:42 +00:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
coins.h
serialization: prevent int overflow for big Coin::nHeight
2020-03-28 08:38:07 +09:00
compat.h
…
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
Merge #17917: tests: Add amount compression/decompression fuzzing to existing fuzzing harness
2020-03-05 15:25:36 -05:00
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
Limit decimal range of numbers ParseScript accepts
2020-03-27 15:51:05 +09:00
core_write.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
cuckoocache.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
2020-04-08 14:45:27 +00:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dummywallet.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
flatfile.cpp
…
flatfile.h
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
fs.cpp
scripted-diff: Add missed copyright headers
2020-01-04 20:18:28 +02:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
…
hash.h
…
httprpc.cpp
scripted-diff: Replace MilliSleep with UninterruptibleSleep
2020-02-21 10:06:21 -08:00
httprpc.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
httpserver.cpp
tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions
2020-04-06 13:58:51 +00:00
httpserver.h
tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions
2020-04-06 13:58:51 +00:00
indirectmap.h
Add missing includes
2020-01-31 12:36:13 +00:00
init.cpp
Merge #18526: Remove PID file at the very end
2020-04-10 11:06:27 -04:00
init.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
logging.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
Makefile.am
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.bench.include
Merge #18429: build: remove double LIBBITCOIN_SERVER from bench-Makefile
2020-03-26 17:20:28 +08:00
Makefile.crc32c.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.leveldb.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.qt_locale.include
qt: Translations update pre-branch
2020-04-01 12:49:15 +02:00
Makefile.qt.include
Merge #17513: refactor, qt: Nuke some circular dependencies
2019-11-21 19:38:39 +01:00
Makefile.qttest.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
Makefile.test_fuzz.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.test_util.include
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
Makefile.test.include
Merge #18529: Add fuzzer version of randomized prevector test
2020-04-09 15:00:57 -04:00
memusage.h
Add missing includes
2020-01-31 12:36:13 +00:00
merkleblock.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
merkleblock.h
…
miner.cpp
Refactor FormatStateMessage into ValidationState
2020-02-27 17:59:07 -08:00
miner.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net_permissions.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
net_permissions.h
net: Remove forcerelay of rejected txs
2020-02-11 07:44:12 -08:00
net_processing.cpp
Merge #18454: net: Make addr relay mockable, add test
2020-04-10 10:12:46 -04:00
net_processing.h
net: Add missing cs_vNodes lock
2020-03-29 11:45:46 -04:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
net: Add missing cs_vNodes lock
2020-03-29 11:45:46 -04:00
net.h
Merge #18454: net: Make addr relay mockable, add test
2020-04-10 10:12:46 -04:00
netaddress.cpp
net: extract conditional to bool CNetAddr::IsHeNet
2020-03-04 14:31:31 +01:00
netaddress.h
net: extract conditional to bool CNetAddr::IsHeNet
2020-03-04 14:31:31 +01:00
netbase.cpp
Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests.
2020-01-22 20:20:45 +01:00
netbase.h
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
noui.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
Revert "Store p2sh scripts in AddAndGetDestinationForScript"
2020-02-12 11:48:30 -05:00
outputtype.h
List output types in an array in order to be iterated over
2020-01-23 16:35:06 -05:00
pow.cpp
…
pow.h
…
prevector.h
Make VectorFormatter support stateful formatters
2020-02-15 19:49:24 -08:00
protocol.cpp
net: Fail instead of truncate command name in CMessageHeader
2020-02-06 13:24:40 +01:00
protocol.h
net: Fail instead of truncate command name in CMessageHeader
2020-02-06 13:24:40 +01:00
psbt.cpp
Merge #17156: psbt: check that various indexes and amounts are within bounds
2020-01-29 19:39:50 +08:00
psbt.h
Fix doxygen errors
2020-01-16 18:25:11 -08:00
pubkey.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pubkey.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
random.cpp
build: fix sysctl() detection on macOS
2020-03-19 11:36:38 +08:00
random.h
tests: Add fuzzing harness for functions/classes in random.h
2020-03-29 13:17:04 +00:00
randomenv.cpp
Drop unused mach time headers
2020-02-28 14:56:49 -08:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
reverse_iterator.h
…
scheduler.cpp
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
scheduler.h
scheduler: Make schedule* methods type safe
2020-03-10 09:47:32 -04:00
serialize.h
Merge #18112: Serialization improvements step 5 (blockencodings)
2020-03-05 19:56:26 +01:00
shutdown.cpp
…
shutdown.h
…
span.h
Make VerifyWitnessProgram use a Span stack
2020-03-23 14:44:58 -07:00
streams.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
sync.cpp
util: Remove unused itostr
2020-03-27 08:59:06 -04:00
sync.h
Fix missing header in sync.h
2020-03-15 22:43:39 +00:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
timedata.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
torcontrol.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.cpp
Get rid of VARINT default argument
2020-02-10 12:00:10 -08:00
txdb.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
txmempool.cpp
[mempool] Remove NotifyEntryAdded and NotifyEntryRemoved callbacks
2020-03-11 18:38:33 -04:00
txmempool.h
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
ui_interface.cpp
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
ui_interface.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
uint256.cpp
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
uint256.h
refactor: define a UINT256_ONE global constant
2020-01-23 16:35:08 -05:00
undo.h
serialization: prevent int overflow for big Coin::nHeight
2020-03-28 08:38:07 +09:00
validation.cpp
Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals
2020-03-19 17:26:51 +01:00
validation.h
scripted-diff: Bump copyright of files changed in 2020
2020-01-15 02:18:00 +07:00
validationinterface.cpp
Do not clear validationinterface entries being executed
2020-04-07 12:53:40 -07:00
validationinterface.h
refactor: drop boost::signals2 in validationinterface
2020-04-04 11:44:39 -04:00
version.h
…
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
warnings.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00