fanquake 7efc628539

Merge bitcoin/bitcoin#23385: refactor: get wallet path relative to wallet_dir ...

9ba7c44265a47880585e39d0167d057ba935ff16 refactor: get wallet path relative to wallet_dir (Michael Dietz)

Pull request description:

  Now that boost has been updated > 1.60 (see #22320), we can simplify how we get
  wallet path relative to wallet_dir by using:
  `boost::filesystem::lexically_relative`, removing a TODO.

  Test coverage comes from `test/functional/wallet_multiwallet.py`

  I first tried this in #20265 which was my first attempted PR, and funny enough exactly 1 year later I'm opening this one to hopefully finally close this.

ACKs for top commit:
  ryanofsky:
    Code review ACK 9ba7c44265a47880585e39d0167d057ba935ff16. Basically this same code change is made in #20744 commit b70c84348ac7a8e427a1183f894c73e52c734529, so this PR helps simplify that one
  lsilva01:
    Code Review ACK 9ba7c44

Tree-SHA512: 6ccb91a18bcb52c3ae0c789a94a18fb5be7db7769fd1121552d63f259fbd32b50c3dcf169cec0b02f978321db3bc60eb4b881b8327e9764f32e700236e0d8a35

2021-10-30 15:20:27 +08:00

..

test

Merge bitcoin/bitcoin#22787: refactor: actual immutable pointing

2021-10-29 10:52:37 +02:00

bdb.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

bdb.h

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

External input fund support cleanups

2021-10-06 06:55:34 +08:00

coinselection.cpp

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

coinselection.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

context.cpp

…

context.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

…

db.cpp

refactor: get wallet path relative to wallet_dir

2021-10-29 09:36:32 -05:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

dump.h

…

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

…

fees.cpp

…

fees.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

init.cpp

Remove -rescan startup parameter

2021-09-30 12:06:27 +13:00

interfaces.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

ismine.h

…

load.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

load.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

receive.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

receive.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

rpcdump.cpp

refactor: use CWallet const shared pointers when possible

2021-10-25 16:12:21 +09:00

rpcwallet.cpp

refactor: use CWallet const shared pointers when possible

2021-10-25 16:12:21 +09:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

Remove -rescan startup parameter

2021-09-30 12:06:27 +13:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23093: Add ability to flush keypool and always flush when upgrading non-HD to HD

2021-10-14 18:05:58 +02:00

scriptpubkeyman.h

refactor: Remove unused KeyIDHasher

2021-08-22 17:31:58 +02:00

spend.cpp

External input fund support cleanups

2021-10-06 06:55:34 +08:00

spend.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

sqlite.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

sqlite.h

…

transaction.cpp

MOVEONLY: CWallet transaction code out of wallet.cpp/.h

2021-05-26 06:32:51 -05:00

transaction.h

doc: Fix CWalletTx::Confirmation doc

2021-10-21 22:13:35 +02:00

wallet.cpp

Merge bitcoin/bitcoin#22787: refactor: actual immutable pointing

2021-10-29 10:52:37 +02:00

wallet.h

doc: Fix CWalletTx::Confirmation doc

2021-10-21 22:13:35 +02:00

walletdb.cpp

walletdb: Use SQLiteDatabase for mock wallet databases

2021-10-22 17:49:43 -04:00

walletdb.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

wallettool.cpp

refactor: const shared_ptrs

2021-10-25 16:12:19 +09:00

wallettool.h

…

walletutil.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00