MeshCollider c536dfbcb0

Merge #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency ...

78a2fb55c bitcoin-wallet tool: Drop libbitcoin_server.a dependency (Russell Yanofsky)
b874747b5 Remove access to node globals from wallet-linked code (Russell Yanofsky)
fbc6bb8e8 bitcoin-wallet tool: Drop MakeChain calls (Russell Yanofsky)

Pull request description:

  Dropping the `bitcoin-wallet` dependency on `libbitcoin_server.a` ensures wallet code can't access node global state, avoiding bugs like https://github.com/bitcoin/bitcoin/pull/15557#discussion_r267735431

ACKs for commit 78a2fb:
  jnewbery:
    utACK 78a2fb55c97fbc26f7b74c5b1fb999a2aff8ce88. Nice work, Russ.
  MarcoFalke:
    utACK 78a2fb5
  MeshCollider:
    utACK 78a2fb55c9

Tree-SHA512: ee6ea774f683b936bea66638211dd53c42b8316e1ef03dd58d12fb7ee3891432a43c5c149944173c1e2436aa756b672e1679c39fc10043792ac55cd4d8af2823

2019-04-11 21:29:59 +12:00

..

test

bitcoin-wallet tool: Drop MakeChain calls

2019-04-10 09:51:37 -04:00

coincontrol.cpp

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

coincontrol.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

coinselection.cpp

Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection

2018-12-12 14:22:12 -08:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

[wallet] Support creating a blank wallet

2019-02-10 12:24:53 -05:00

crypter.h

[tools] Add wallet inspection and modification tool

2019-01-30 16:26:52 -05:00

db.cpp

wallet: Improve log output for errors during load

2019-03-14 18:49:19 -07:00

db.h

wallet: Improve log output for errors during load

2019-03-14 18:49:19 -07:00

feebumper.cpp

Remove access to node globals from wallet-linked code

2019-04-10 09:51:37 -04:00

feebumper.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

fees.cpp

Remove remaining wallet accesses to node globals

2019-03-06 16:47:57 -05:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

[build] Move wallet load functions to wallet/load unit

2019-04-09 17:53:08 -04:00

load.cpp

[build] Move wallet load functions to wallet/load unit

2019-04-09 17:53:08 -04:00

load.h

[build] Move wallet load functions to wallet/load unit

2019-04-09 17:53:08 -04:00

psbtwallet.cpp

Remove unused TransactionError constants

2019-02-14 10:32:02 -05:00

psbtwallet.h

Remove unused TransactionError constants

2019-02-14 10:32:02 -05:00

rpcdump.cpp

Take non-importing keys into account for spendability warning in descriptor import

2019-04-06 09:14:56 -07:00

rpcwallet.cpp

Remove access to node globals from wallet-linked code

2019-04-10 09:51:37 -04:00

rpcwallet.h

Remove use of CRPCTable::appendCommand in wallet code

2019-03-05 10:20:00 -04:00

wallet.cpp

Merge #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency

2019-04-11 21:29:59 +12:00

wallet.h

Merge #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency

2019-04-11 21:29:59 +12:00

walletdb.cpp

[build] Move CheckTransaction from lib_server to lib_consensus

2019-04-09 17:53:08 -04:00

walletdb.h

Store key origin info in key metadata

2019-02-14 17:58:25 -05:00

wallettool.cpp

bitcoin-wallet tool: Drop MakeChain calls

2019-04-10 09:51:37 -04:00

wallettool.h

[tools] Add wallet inspection and modification tool

2019-01-30 16:26:52 -05:00

walletutil.cpp

wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree

2019-03-13 20:41:42 +00:00

walletutil.h

wallet: Add WalletLocation utility class

2018-10-25 11:53:17 +01:00