Wladimir J. van der Laan bd60a9a8ed

Merge #19818: p2p: change CInv::type from int to uint32_t, fix UBSan warning ...

7984c39be11ca04460883365e1ae2a496aaa6c0e test framework: serialize/deserialize inv type as unsigned int (Jon Atack)
407175e0c2bc797599ebd9c0a1f2ec89ad7af136 p2p: change CInv::type from int to uint32_t (Jon Atack)

Pull request description:

  Fixes UBSan implicit-integer-sign-change issue per https://github.com/bitcoin/bitcoin/pull/19610#issuecomment-680686460.

  Credit to Crypt-iQ for finding and reporting the issue and to vasild for the original review suggestion in https://github.com/bitcoin/bitcoin/pull/19590#pullrequestreview-455788826.

  Closes #19678.

ACKs for top commit:
  laanwj:
    ACK 7984c39be11ca04460883365e1ae2a496aaa6c0e
  MarcoFalke:
    ACK 7984c39be11ca04460883365e1ae2a496aaa6c0e 🌻
  vasild:
    ACK 7984c39be

Tree-SHA512: 59f3a75f40ce066ca6f0bb1927197254238302b4073af1574bdbfe6ed580876437be804be4e47d51467d604f0d9e3a5875159f7f2edbb2351fdb2bb9465100b5

2020-09-03 17:23:52 +02:00

..

__init__.py

Rename rpc-tests directory to functional

2017-03-20 10:40:31 -04:00

address.py

Revert "[TESTS] Move base58 to own module to break circular dependency"

2020-06-10 11:54:25 -04:00

authproxy.py

test: retry when write to a socket fails on macOS

2020-06-25 17:26:20 +07:00

blocktools.py

[test] CScriptNum Decode Check as Unit Tests

2020-06-03 07:18:01 -07:00

coverage.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

descriptors.py

Output a descriptor in createmultisig and addmultisigaddress

2020-01-30 23:55:36 -05:00

key.py

test: Move modinv to util and add unit test

2020-07-16 18:10:43 +02:00

messages.py

Merge #19818: p2p: change CInv::type from int to uint32_t, fix UBSan warning

2020-09-03 17:23:52 +02:00

muhash.py

test: Add chacha20 test vectors in muhash

2020-07-16 18:10:48 +02:00

netutil.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

p2p.py

test: Rename wait until helper to wait_until_helper

2020-08-27 18:50:05 +02:00

script_util.py

test: Remove unused, undocumented and misleading CScript.__add__

2020-04-22 09:00:56 -04:00

script.py

refactor: test: use _ variable for unused loop counters

2020-08-06 18:39:33 +02:00

segwit_addr.py

…

siphash.py

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

socks5.py

scripted-diff: Update copyright in ./test

2019-03-02 10:58:35 -05:00

test_framework.py

test: Remove unused lock arg from BitcoinTestFramework.wait_until

2020-08-27 18:50:08 +02:00

test_node.py

test: Rename wait until helper to wait_until_helper

2020-08-27 18:50:05 +02:00

test_shell.py

TestShell: Return self from setup()

2019-11-05 12:55:52 +01:00

util.py

Merge #19816: test: Rename wait until helper to wait_until_helper

2020-09-03 12:07:53 +08:00

wallet_util.py

[tests] move generate_wif_key to wallet_util.py

2020-06-10 12:10:02 -04:00