Wladimir J. van der Laan 64ee94356f

Merge #14409: utils and libraries: Make 'blocksdir' always net specific ...

e4a0c3547ed886871f8b3d51c6b4ffdb181a8b9c Improve blocksdir functional test. (Hennadii Stepanov)
c3f1821ac788e522e7558e3575150433450dcb8c Make blockdir always net specific (Hennadii Stepanov)

Pull request description:

  The blocks directory is net specific by definition.

  Also this prevents the side effect of calling `GetBlocksDir(false)` in the non-mainnet environment.
  Currently a new node creates an unused `blocks\` directory in the root of the data directory when `-testnet` or `-regtest` is specified.

  Refs:
  - #12653
  - https://github.com/bitcoin/bitcoin/pull/12653#discussion_r174784834 by @laanwj
  - https://github.com/bitcoin/bitcoin/issues/14595#issuecomment-436011186

Tree-SHA512: c9957a68a4a200ebd2010823a56db7e61563afedcb7c9828e86b13f3af2990e07854b622c1f3374756f94574acb3ea32de7d2a399eef6c0623f0e11265155627

2019-01-16 13:40:27 +01:00

..

bytevectorhash.cpp

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

bytevectorhash.h

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

memory.h

…

moneystr.cpp

Use IsDigit(...) instead of std::isdigit

2018-11-06 17:32:08 +01:00

moneystr.h

Add NODISCARD to all {Decode,Parse}[...](...) functions returning bool. Sort includes.

2018-11-05 17:03:11 +01:00

strencodings.cpp

util: Make ToLower and ToUpper take a char

2019-01-10 02:51:14 +01:00

strencodings.h

util: Make ToLower and ToUpper take a char

2019-01-10 02:51:14 +01:00

system.cpp

Merge #14409: utils and libraries: Make 'blocksdir' always net specific

2019-01-16 13:40:27 +01:00

system.h

Merge #14409: utils and libraries: Make 'blocksdir' always net specific

2019-01-16 13:40:27 +01:00

time.cpp

…

time.h

…