W. J. van der Laan 58275db371
Merge bitcoin/bitcoin#23140: Make CAddrman::Select_ select buckets, not positions, first
632aad9e6d8369750f4327a886ca5b3d3fed89bd Make CAddrman::Select_ select buckets, not positions, first (Pieter Wuille)

Pull request description:

  The original CAddrMan behaviour (before #5941) was to pick a uniformly random non-empty bucket, and then pick a random element from that bucket. That commit, which introduced deterministic placement of entries in buckets, changed this to picking a uniformly random non-empty bucket position instead.

  I believe that was a mistake. Buckets are our best metric for spreading out requests across independently-controlled nodes. That
  does mean that if a bucket has fewer entries, its entries are supposed to be picked more frequently.

  This PR reverts to the original high-level behavior, but on top of the deterministic placement logic.

ACKs for top commit:
  jnewbery:
    utACK 632aad9e6d8369750f4327a886ca5b3d3fed89bd
  naumenkogs:
    ACK 632aad9e6d8369750f4327a886ca5b3d3fed89bd
  mzumsande:
    ACK 632aad9e6d8369750f4327a886ca5b3d3fed89bd

Tree-SHA512: 60768afba2b6f0abd0dddff04381cab5acf374df48fc0e883ee16dde7cf7fd33056a04b573cff24a1b4d8e2a645bf0f0b3689eec84da4ff330e7b59ef142eca1
2021-10-22 13:55:05 +02:00
..
2021-09-10 11:18:58 +08:00
2021-10-16 13:35:57 -07:00
2021-09-29 14:10:29 +02:00
2021-07-30 11:21:51 +02:00
2021-03-17 17:59:22 -07:00
2021-09-16 21:16:39 +09:00
2021-10-11 21:45:49 +10:00
2021-10-05 11:11:18 +02:00
2021-10-07 13:22:02 +02:00
2021-09-11 10:47:02 +03:00
2021-04-06 14:50:17 +08:00
2021-08-23 21:38:34 -04:00
2021-09-29 18:46:30 +02:00
2021-08-20 16:59:41 +02:00