fanquake
8071ec179d
Merge bitcoin/bitcoin#21789 : refactor: Remove ::Params() global from CChainState
...
fa0d9211ef87a682573aaae932c0c440acbcb8a8 refactor: Remove chainparams arg from CChainState member functions (MarcoFalke)
fa389471251f043ec25e7b01e59b37d3b921ce54 refactor: Remove ::Params() global from inside CChainState member functions (MarcoFalke)
Pull request description:
The `::Params()` global is verbose and confusing. Also it makes tests a bit harder to write because they'd have to mock a global.
Fix all issues by simply using a member variable that points to the right params.
(Can be reviewed with `--word-diff-regex=.`)
ACKs for top commit:
jnewbery:
ACK fa0d9211ef87a682573aaae932c0c440acbcb8a8
kiminuo:
utACK fa0d9211
theStack:
ACK fa0d9211ef87a682573aaae932c0c440acbcb8a8 🍉
Tree-SHA512: 44676b19c9ed471ccb536331d3029bad192d7d50f394fd7b8527ec431452aeec8c4494164b9cf8e16e0123c4463b16be864366c6b599370032c17262625a0356
2021-06-29 11:22:57 +08:00
..
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-14 17:28:30 +03:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2021-03-15 10:41:30 +08:00
2021-06-24 15:57:34 +02:00
2021-06-18 23:13:07 +00:00
2021-03-15 17:26:35 -07:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-03-15 10:41:30 +08:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-17 09:47:08 -04:00
2021-05-24 20:28:31 +08:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-17 10:32:59 +02:00
2021-03-03 12:23:41 +02:00
2021-03-03 09:17:37 +01:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-06-17 21:40:51 +02:00
2021-03-11 13:45:14 +08:00
2021-05-18 07:13:25 +02:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-07 13:41:14 +02:00
2021-05-21 19:41:43 +00:00
2021-02-22 10:27:22 +01:00
2021-03-09 12:56:44 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-05-24 10:29:58 +02:00
2021-05-12 14:42:41 +02:00
2020-12-10 07:15:42 +01:00
2021-03-11 13:45:14 +08:00
2021-02-22 10:27:22 +01:00
2021-06-13 09:43:54 +02:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2021-05-12 16:13:30 +02:00
2021-04-30 11:29:14 +01:00
2021-02-22 10:27:22 +01:00
2021-03-16 19:52:31 +01:00
2021-06-14 13:58:05 +02:00
2021-05-25 08:20:43 -07:00
2020-12-31 09:45:41 +01:00
2021-05-09 10:04:01 +02:00
2021-03-19 23:50:36 +01:00
2020-12-31 09:45:41 +01:00
2021-03-11 13:45:14 +08:00
2021-03-03 09:17:37 +01:00
2021-03-03 09:17:37 +01:00
2021-03-24 06:57:55 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-06-17 10:55:39 +02:00
2021-04-22 17:28:39 +03:00
2020-12-10 07:15:42 +01:00
2021-04-09 13:17:37 +02:00
2020-12-10 07:15:42 +01:00
2020-12-15 19:00:36 +01:00
2021-02-22 10:27:22 +01:00
2021-05-11 21:24:49 +02:00
2021-05-04 09:24:17 +02:00
2020-12-10 07:15:42 +01:00
2021-03-17 14:56:20 +08:00
2021-04-25 10:36:00 +02:00
2020-12-10 07:15:42 +01:00
2021-05-12 10:20:59 +02:00
2020-12-15 19:00:36 +01:00
2020-12-10 07:15:42 +01:00
2021-04-28 21:13:44 +02:00
2021-02-22 10:27:22 +01:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2021-03-30 10:42:45 +02:00
2021-03-03 09:17:37 +01:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2021-03-16 19:52:37 +01:00
2021-05-09 10:25:21 +02:00
2021-03-15 10:41:30 +08:00
2021-05-11 08:54:24 +02:00
2021-03-04 08:39:27 +01:00
2021-05-20 17:26:24 +02:00
2020-12-31 09:45:41 +01:00
2020-12-31 09:45:41 +01:00
2021-05-27 22:40:24 +02:00
2020-12-10 07:15:42 +01:00
2021-05-09 10:53:24 +02:00
2021-06-07 13:41:13 +02:00
2021-05-24 10:29:58 +02:00
2021-06-10 15:04:39 -04:00
2021-04-12 11:14:49 +10:00