MarcoFalke 7a24cca829

Merge #19100: refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions ...

f42f5e58f5fd063d5feec3eadf4a4040a941d4af refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions (Russell Yanofsky)

Pull request description:

  This simplifies control flow and also helps get rid of the ::vpwallets variable in #19101 since EnsureWalletIsAvailable doesn't have access to the request context.

ACKs for top commit:
  MarcoFalke:
    ACK f42f5e58f5fd063d5feec3eadf4a4040a941d4af (reviewed code to check that this is a refactor) 💢
  promag:
    Tested ACK f42f5e58f5fd063d5feec3eadf4a4040a941d4af.

Tree-SHA512: eb10685de3db3c1d10c3a797d8da5c8c731e4a8c9024bbb7245929ba767a77a52783a739b8cb1fa7af6fcd233dcf9c8ebbe414eb8b902e2542601aac18625997

2020-06-11 09:52:16 -04:00

..

test

test: Avoid overwriting the NodeContext member of the testing setup

2020-06-06 09:50:32 -04:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

Merge #18792: wallet: Remove boost from PeriodicFlush

2020-06-02 22:35:03 +08:00

db.h

Move RecoverDatabaseFile and RecoverKeysOnlyFilter into salvage.{cpp/h}

2020-05-25 12:59:29 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

…

init.cpp

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

load.h

wallet: remove -salvagewallet

2020-05-25 12:39:40 -04:00

rpcdump.cpp

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

rpcwallet.cpp

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

salvage.h

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

scriptpubkeyman.cpp

Merge #18787: wallet: descriptor wallet release notes and cleanups

2020-05-22 14:21:56 +12:00

scriptpubkeyman.h

Merge #19032: Serialization improvements: final step

2020-05-26 15:45:50 +02:00

wallet.cpp

refactor: Error message bilingual_str consistency

2020-06-09 15:39:44 +02:00

wallet.h

Merge #18982: wallet: Minimal fix to restore conflicted transaction notifications

2020-06-02 18:11:52 -04:00

walletdb.cpp

Merge #18792: wallet: Remove boost from PeriodicFlush

2020-06-02 22:35:03 +08:00

walletdb.h

Merge #18918: wallet: Move salvagewallet into wallettool

2020-05-27 14:51:49 +12:00

wallettool.cpp

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00