cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src
History
W. J. van der Laan 46b4937bc1
Merge bitcoin/bitcoin#23142: Return false on corrupt tx rather than asserting 
0ab4c3b27265401c59e40adc494041927dc9dbe3 Return false on corrupt tx rather than asserting (Samuel Dobson)

Pull request description:

  Takes up #19793

  Rather than asserting, we log an error and return CORRUPT so that the user is informed. This type of error isn't critical so it isn't worth `assert`ing.

ACKs for top commit:
  achow101:
    ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3
  laanwj:
    Code review ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3
  ryanofsky:
    Code review ACK 0ab4c3b27265401c59e40adc494041927dc9dbe3. There may be room for more improvements later like better error messages or easier recovery options, but changing from an assert to an error seems like a clear improvement, and this seems to avoid all the pitfalls of the last PR that tried this.

Tree-SHA512: 4a1a412e7c473d176c4e09123b85f390a6b0ea195e78d28ebd50b13814b7852f8225a172511a2efb6affb555b11bd4e667c19eb8c78b060c5444b62f0fae5f7a
2021-10-01 10:32:10 +02:00
..
bench
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
compat
compat: remove glibc_compat.cpp
2021-09-10 11:18:58 +08:00
config
…
consensus
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
crc32c
Update crc32c subtree
2021-09-29 14:10:29 +02:00
crypto
[crypto] Fix K1/K2 use in ChaCha20-Poly1305 AEAD
2021-06-23 09:46:38 -07:00
index
Remove txindex migration code
2021-08-20 16:59:41 +02:00
init
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
interfaces
Make GUI UTXO lock/unlock persistent
2021-09-25 23:50:06 +12:00
ipc
Add ipc::Context and ipc::capnp::Context structs
2021-06-10 09:58:45 -05:00
leveldb
…
logging
Make unexpected time type in BCLog::LogMsg() a compile-time error
2021-09-07 19:19:31 +02:00
node
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
policy
add missing includes in policy/rbf
2021-09-20 13:34:48 +01:00
primitives
…
qt
Merge bitcoin-core/gui#342: wallet: Move wallets loading out from the main GUI thread
2021-09-30 17:35:14 +03:00
rpc
Merge bitcoin/bitcoin#22722: rpc: update estimatesmartfee to return max of CBlockPolicyEstimator::estimateSmartFee, mempoolMinFee and minRelayTxFee
2021-09-29 10:55:29 +13:00
script
Merge bitcoin/bitcoin#22650: Remove -deprecatedrpc=addresses flag and corresponding code/logic
2021-09-29 10:41:30 +13:00
secp256k1
Update secp256k1 subtree to latest upstream + adapt API
2021-07-14 14:43:45 -07:00
support
…
test
Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull}
2021-09-30 15:14:58 +02:00
univalue
…
util
Merge bitcoin/bitcoin#20457: util: Make Parse{Int,UInt}{32,64} use locale independent std::from_chars(…) (C++17) instead of locale dependent strto{l,ll,ul,ull}
2021-09-30 15:14:58 +02:00
wallet
Merge bitcoin/bitcoin#23142: Return false on corrupt tx rather than asserting
2021-10-01 10:32:10 +02:00
zmq
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
.clang-format
…
.clang-tidy
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
addrdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
addrdb.h
Raise InitError when peers.dat is invalid or corrupted
2021-09-09 09:20:43 +02:00
addrman.cpp
addrman: Replace assert with throw on corrupt data
2021-09-21 10:09:45 +02:00
addrman.h
Refactor: Turn the internal addrman check helper into a forced check
2021-09-21 10:07:48 +02:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
banman.h
Ignore banlist.dat
2021-07-30 11:21:51 +02:00
base58.cpp
…
base58.h
…
bech32.cpp
Add references for the generator/constant used in Bech32(m)
2021-08-20 15:49:50 -04:00
bech32.h
naming nits
2021-03-17 17:59:22 -07:00
bitcoin-cli-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-cli.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
bitcoin-tx-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-tx.cpp
rpc: remove deprecated addresses and reqSigs from rpc outputs
2021-09-24 14:22:49 -05:00
bitcoin-util-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-util.cpp
refactor: Pass grind args vector as const reference
2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoin-wallet.cpp
Remove unused OptionsCategory arg from AddCommand
2021-06-18 20:09:23 +02:00
bitcoind-res.rc
windres: use PACKAGE_VERSION rather than building more version numbers
2021-08-17 16:54:47 +08:00
bitcoind.cpp
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
bloom: cleanup includes
2021-09-29 09:48:36 +08:00
bloom.h
bloom: cleanup includes
2021-09-29 09:48:36 +08:00
chain.cpp
…
chain.h
chain: add BLOCK_ASSUMED_VALID for use with assumeutxo
2021-09-15 15:46:44 -04:00
chainparams.cpp
doc: Remove un-actionable TODO from chainparams.cpp
2021-09-28 20:18:20 +02:00
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
test: Activate all regtest softforks at height 1, unless overridden
2021-09-16 18:53:04 +02:00
chainparamsbase.h
…
chainparamsseeds.h
contrib, p2p: update I2P hardcoded seeds
2021-07-30 11:03:44 +02:00
checkqueue.h
…
clientversion.cpp
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
clientversion.h
wallet: use FormatFullVersion instead of CLIENT_BUILD in rpcdump
2021-08-16 16:04:47 +08:00
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
net: extend Sock with methods for robust send & read until terminator
2021-03-01 17:36:16 +01:00
compressor.cpp
refactor: Use CPubKey vector constructor where possible
2021-05-04 06:53:32 +02:00
compressor.h
…
core_io.h
refactor: minor styling, prefer snake case and same line if
2021-09-24 14:22:53 -05:00
core_memusage.h
…
core_read.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
core_write.cpp
refactor: minor styling, prefer snake case and same line if
2021-09-24 14:22:53 -05:00
cuckoocache.h
…
dbwrapper.cpp
refactor: Use only one temporary buffer in CreateObfuscateKey
2021-05-04 06:53:37 +02:00
dbwrapper.h
…
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
consensus/params: simplify ValidDeployment check to avoid gcc warning
2021-08-02 23:48:32 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
Remove -rescan startup parameter
2021-09-30 12:06:27 +13:00
external_signer.cpp
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
Merge bitcoin/bitcoin#20586: Fix Windows build with --enable-werror
2021-08-27 08:31:45 +02:00
fs.h
…
hash.cpp
bloom: use Span instead of std::vector for insert and contains
2021-09-29 09:40:10 +08:00
hash.h
Squashed 'src/secp256k1/' changes from 3967d96bf1..efad3506a8
2021-04-23 11:35:15 -07:00
httprpc.cpp
Replace use of boost::trim use with locale-independent TrimString
2021-09-02 13:17:46 +08:00
httprpc.h
refactor: replace util::Ref by std::any (C++17)
2021-03-29 23:29:42 +02:00
httpserver.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
httpserver.h
…
i2p.cpp
net: do not connect to I2P hosts on port!=0
2021-07-09 11:19:37 +02:00
i2p.h
i2p: use pointers to Sock to accommodate mocking
2021-03-16 13:59:18 +01:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#23123: Remove -rescan startup parameter
2021-09-30 20:49:40 +02:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
…
key.cpp
Stricter BIP32 decoding and test vector 5
2021-08-30 12:02:04 -04:00
key.h
doc: Remove stale comment for CPrivKey
2021-09-16 21:16:39 +09:00
logging.cpp
log, sync: add LOCK logging category, apply it to lock contention
2021-08-18 19:57:15 +02:00
logging.h
log, sync: add LOCK logging category, apply it to lock contention
2021-08-18 19:57:15 +02:00
Makefile.am
build: remove glibc-back-compat from build system
2021-09-10 11:18:58 +08:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
Makefile.leveldb.include
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
Makefile.qttest.include
Start using init makeNode, makeChain, etc methods
2021-08-17 03:05:15 -05:00
Makefile.test_fuzz.include
build: compile libnatpmp with -DNATPMP_STATICLIB on Windows
2021-03-04 12:34:46 +08:00
Makefile.test_util.include
move-only: unittest: add test/util/chainstate.h
2021-09-15 15:46:48 -04:00
Makefile.test.include
fuzz: Move all addrman fuzz targets to one file
2021-09-21 10:09:56 +02:00
mapport.cpp
refactor: Use appropriate thread constructor
2021-04-29 18:39:01 +03:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
[net processing] Dont request compact blocks in blocks-only mode
2021-09-28 22:11:30 +02:00
net_processing.h
Merge bitcoin/bitcoin#22577: Close minor startup race between main and scheduler threads
2021-08-04 16:37:12 +02:00
net_types.cpp
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net_types.h
MOVEONLY: Expose BanMapToJson / BanMapFromJson
2021-09-03 05:21:58 -04:00
net.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
net.h
Merge bitcoin/bitcoin#22911: [net] Minor cleanups to asmap
2021-09-10 14:04:16 +08:00
netaddress.cpp
[asmap] Remove SanityCheckASMap() from netaddress
2021-09-07 13:31:10 +01:00
netaddress.h
[asmap] Remove SanityCheckASMap() from netaddress
2021-09-07 13:31:10 +01:00
netbase.cpp
Cleanup headers after #20788
2021-09-11 10:47:02 +03:00
netbase.h
doc: fixup -Wdocumentation issues
2021-04-06 14:50:17 +08:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
outputtype.h
make ParseOutputType return a std::optional<OutputType>
2021-08-04 19:20:32 +08:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
protocol.h
doc: Remove incorrect INIT_PROTO_VERSION from nTime comment
2021-08-23 18:53:34 +02:00
psbt.cpp
Make GetInputUTXO safer: verify non-witness UTXO match
2021-06-12 12:25:28 -07:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
Merge bitcoin/bitcoin#22836: Stricter BIP32 decoding and test vector 5
2021-09-02 10:41:16 +08:00
pubkey.h
Consolidate XOnlyPubKey lookup hack
2021-08-23 21:38:34 -04:00
random.cpp
refactor: Replace &foo[0] with foo.data()
2021-05-04 06:55:31 +02:00
random.h
…
randomenv.cpp
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
randomenv.h
…
rest.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
reverse_iterator.h
…
scheduler.cpp
test: Fix off-by-one in mockscheduler test RPC
2021-05-14 12:49:16 +02:00
scheduler.h
…
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
shutdown.h
move-only: Move AbortNode to shutdown
2021-04-04 18:08:36 +02:00
signet.cpp
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
signet.h
scripted-diff: remove Optional & nullopt
2021-03-15 10:41:30 +08:00
span.h
…
streams.h
streams: Accept URef obj for VectorReader unserialize
2021-05-05 20:19:03 +02:00
sync.cpp
log: Avoid broken DEBUG_LOCKORDER log
2021-09-29 18:46:30 +02:00
sync.h
sync: inline lock contention logging macro to fix time duration
2021-09-06 23:43:51 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
torcontrol: Resolve Tor control plane address
2021-06-27 19:27:25 +02:00
torcontrol.h
tests: Add fuzzing harness for TorController
2021-03-02 12:21:32 +00:00
txdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
txdb.h
Remove txindex migration code
2021-08-20 16:59:41 +02:00
txmempool.cpp
Use C++11 member initializer in CTxMemPoolEntry
2021-09-21 16:04:27 +02:00
txmempool.h
Use C++11 member initializer in CTxMemPoolEntry
2021-09-21 16:04:27 +02:00
txorphanage.cpp
scripted-diff: Update txorphanage naming convention
2021-02-27 01:08:09 +10:00
txorphanage.h
[net processing] Add Orphanage empty consistency check
2021-07-20 13:12:42 +01:00
txrequest.cpp
doc: Fix typos from codespell lint
2021-04-07 19:26:25 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
validation.h
Merge bitcoin/bitcoin#21526: validation: UpdateTip/CheckBlockIndex assumeutxo support
2021-09-23 22:22:07 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…