cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src
History
MarcoFalke 30dd562fd2
Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations 
0e279fe4899beae8630264ef1fe420dd71f29d5d walletdb: Remove unused static functions from walletdb.h (Andrew Chow)
9f536d4fe949666f14a0bf5b814522cecde71f56 wallettool: Have RecoverDatabaseFile return errors and warnings (Andrew Chow)
06e263a4e368671ebb4e4a77c1447ebd5104a488 Call RecoverDatabaseFile directly from wallettool (Andrew Chow)

Pull request description:

  Followup to #19324 addressing some comments.

  Removes the `SalvageWallet` function in wallettool and instead directly calls `RecoverDatabaseFile` as suggested in https://github.com/bitcoin/bitcoin/pull/19324#discussion_r450379596

  Removes the `LogPrintf`s and `tfm::format`s in `RecoverDatabaseFile` as noted in https://github.com/bitcoin/bitcoin/pull/19324#discussion_r448027237

  Removes the declarations of `VerifyEnvironment` and `VerifyDatabaseFile` that were forgotten in `walletdb.h` as noted in https://github.com/bitcoin/bitcoin/pull/19324#issuecomment-654389079

ACKs for top commit:
  meshcollider:
    Code review ACK 0e279fe4899beae8630264ef1fe420dd71f29d5d
  ryanofsky:
    Code review ACK 0e279fe4899beae8630264ef1fe420dd71f29d5d, just dropped last commit

Tree-SHA512: ffd01f30536c2eab4bf40ba363c3ea916ecef3c8f0c5262040b40498776ffb00f95240204a40e38415d6931800851d0a3fa63ee91efc1d329b60ac317da0363d
2020-08-14 15:12:44 +02:00
..
bench
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
compat
net: Use C++11 member initialization in protocol
2020-05-20 08:27:07 -04:00
config
…
consensus
Add txids with non-standard inputs to reject filter
2020-08-04 13:29:40 -04:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
build: improve builtin_clz* detection
2020-06-29 11:31:17 +08:00
index
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
interfaces
Add BlockAndHeaderTipInfo to the node interface/appInit
2020-08-12 16:44:06 +02:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
Remove use of non-standard zero variadic macros
2020-04-30 18:02:04 +08:00
node
Add support for tx-relay via wtxid
2020-07-19 02:05:29 -04:00
policy
Add txids with non-standard inputs to reject filter
2020-08-04 13:29:40 -04:00
primitives
refactor: add GenTxid (=txid or wtxid) type and use it for tx request logic
2020-07-30 13:44:54 -07:00
qt
Reduce cs_main lock accumulation during GUI startup
2020-08-12 16:44:09 +02:00
rpc
Merge #19455: rpc generate: print useful help and error message
2020-08-14 11:29:05 +02:00
script
Merge #17204: wallet: Do not turn OP_1NEGATE in scriptSig into 0x0181 in signing code (sipa)
2020-08-14 11:53:47 +02:00
secp256k1
Update src/secp256k1 subtree
2020-06-09 13:39:09 -07:00
support
Limit scope of all global std::once_flag
2020-05-29 17:22:07 -04:00
test
Merge #19709: test: Fix 'make cov' with clang
2020-08-14 14:57:49 +02:00
univalue
Update univalue subtree
2020-02-09 07:44:29 -08:00
util
Merge #19660: refactor: Make HexStr take a span
2020-08-09 15:35:58 +02:00
wallet
Merge #19457: wallet: Cleanup wallettool salvage and walletdb extraneous declarations
2020-08-14 15:12:44 +02:00
zmq
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
.clang-format
tools: clang-format 6 compatibility
2020-07-06 03:52:37 +02:00
addrdb.cpp
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
addrdb.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
banlist: log post-swept banlist size at startup
2020-07-08 21:44:45 +08:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
base58.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
bech32.cpp
Add some general std::vector utility functions
2019-10-16 08:56:57 -07:00
bech32.h
Assert that the HRP is lowercase in Bech32::Encode
2019-09-05 13:25:11 +12:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
bitcoind-res.rc
…
bitcoind.cpp
Add <datadir>/settings.json persistent settings storage.
2020-07-11 05:41:12 -04:00
blockencodings.cpp
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
blockfilter.h
[indexes] Fix default [de]serialization of BlockFilter.
2020-05-26 17:27:15 -04:00
bloom.cpp
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
bloom.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparams.cpp
Merge #19316: [net] Cleanup logic around connection types
2020-08-12 10:01:44 +08:00
chainparams.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
chainparamsbase.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
chainparamsbase.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.20
2020-04-03 16:29:26 +02:00
checkqueue.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
clientversion.cpp
Drop unused GIT_COMMIT_DATE macro
2020-05-04 19:53:58 +03:00
clientversion.h
…
coins.cpp
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
coins.h
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
compat.h
…
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
refactor: Replace const char* to std::string
2020-05-22 01:40:31 +09:00
core_write.cpp
refactor: Make HexStr take a span
2020-08-06 19:41:43 +02:00
cuckoocache.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
2020-04-08 14:45:27 +00:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
Drop unused CDBWrapper methods
2020-07-08 14:26:14 +03:00
dummywallet.cpp
scripted-diff: Replace gArgs with local argsman
2020-07-29 16:39:00 +07:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Add missing includes to fix compile errors
2020-06-16 15:15:46 -04:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
Make MurmurHash3 consume Spans
2020-07-30 13:57:54 -07:00
hash.h
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
httprpc.cpp
Merge #18740: Remove g_rpc_node global
2020-05-21 06:53:39 -04:00
httprpc.h
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
httpserver.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
httpserver.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
indirectmap.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
init.h
Optionally populate BlockAndHeaderTipInfo during AppInitMain
2020-08-12 16:44:09 +02:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
log: remove deprecated db log category
2020-06-07 17:03:49 +02:00
logging.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
Makefile.am
build: Sort Makefile.am after renaming file
2020-06-27 11:49:35 -04:00
Makefile.bench.include
Replace current benchmarking framework with nanobench
2020-06-13 12:24:18 +02:00
Makefile.crc32c.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
qt: Translations update pre-branch
2020-04-01 12:49:15 +02:00
Makefile.qt.include
scripted-diff: rename movie folder to animation
2020-06-29 18:49:13 +01:00
Makefile.qttest.include
build: Create test utility library from src/test/util/
2019-11-21 21:13:08 +01:00
Makefile.test_fuzz.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.test_util.include
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
Makefile.test.include
build: make clean removes .gcda and .gcno files from fuzz directory
2020-08-06 00:44:03 -04:00
memusage.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
merkleblock.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
merkleblock.h
Convert merkleblock to new serialization
2020-03-30 16:09:51 -07:00
miner.cpp
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
miner.h
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
net_permissions.cpp
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_permissions.h
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_processing.cpp
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
net_processing.h
Merge #19472: [net processing] Reduce cs_main scope in MaybeDiscourageAndDisconnect()
2020-07-24 17:20:58 +02:00
net_types.h
refactor: Remove addrdb.h dependency from node.h
2019-10-29 11:30:12 +02:00
net.cpp
Merge #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman
2020-08-12 15:23:06 +02:00
net.h
Merge #19658: [rpc] Allow RPC to fetch all addrman records and add records to addrman
2020-08-12 15:23:06 +02:00
netaddress.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
netaddress.h
net: save the network type explicitly in CNetAddr
2020-07-27 15:13:24 +02:00
netbase.cpp
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
netbase.h
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
netmessagemaker.h
refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg
2020-05-11 00:20:57 +02:00
noui.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
noui.h
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
Enable Wswitch for OutputType
2020-07-01 18:03:12 -04:00
outputtype.h
Remove confusing OutputType::CHANGE_AUTO
2020-07-01 18:02:38 -04:00
pow.cpp
…
pow.h
…
prevector.h
prevector: Avoid unnamed struct, which is a GNU extension
2020-04-30 18:02:03 +08:00
protocol.cpp
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
protocol.h
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
psbt.cpp
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
psbt.h
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
pubkey.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
pubkey.h
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
Add templated GetRandomDuration<>
2020-04-30 09:19:14 -04:00
randomenv.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
rpc: Avoid useless mempool query in gettxoutproof
2020-07-26 16:44:07 +02:00
reverse_iterator.h
…
scheduler.cpp
clang-format scheduler
2020-06-21 06:02:59 -04:00
scheduler.h
clang-format scheduler
2020-06-21 06:02:59 -04:00
serialize.h
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
shutdown.cpp
…
shutdown.h
…
span.h
Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2020-07-30 13:57:09 -07:00
streams.h
refactor: Drop unused CBufferedFile::Seek()
2020-07-26 22:46:28 +03:00
sync.cpp
test: Add LockStackEmpty()
2020-08-02 16:42:39 +03:00
sync.h
test: Add LockStackEmpty()
2020-08-02 16:42:39 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
Add means to handle negative capabilities in thread safety annotations
2020-06-11 15:49:39 +03:00
timedata.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
Replace hidden service with onion service
2020-08-07 14:55:02 +02:00
torcontrol.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
txdb.cpp
Merge #18637: coins: allow cache resize after init
2020-07-29 07:53:19 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
refactor: make txmempool interface use GenTxid
2020-07-30 13:45:03 -07:00
txmempool.h
refactor: make txmempool interface use GenTxid
2020-07-30 13:45:03 -07:00
uint256.cpp
refactor: Make HexStr take a span
2020-08-06 19:41:43 +02:00
uint256.h
Make uint256 Span-convertible by adding ::data()
2020-07-30 13:57:09 -07:00
undo.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
validation.cpp
Merge #19660: refactor: Make HexStr take a span
2020-08-09 15:35:58 +02:00
validation.h
Pass mempool pointer to GetCoinsCacheSizeState
2020-07-29 12:30:11 +02:00
validationinterface.cpp
trivial: Suggested cleanups to surrounding code
2020-05-22 16:30:07 -04:00
validationinterface.h
trivial: Suggested cleanups to surrounding code
2020-05-22 16:30:07 -04:00
version.h
Add p2p message "wtxidrelay"
2020-07-19 02:10:41 -04:00
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
warnings.cpp
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00
warnings.h
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00