fa13e1b0c52738492310b6b421d8e38cb04da5b1 build: Add option --enable-danger-fuzz-link-all (MarcoFalke) 44444ba759480237172d83f42374c5c29c76eda0 fuzz: Link all targets once (MarcoFalke) Pull request description: Currently the linker is invoked more than 150 times when compiling with `--enable-fuzz`. This is problematic for several reasons: * It wastes disk space north of 20 GB, as all libraries and sanitizers are linked more than 150 times * It wastes CPU time, as the link step can practically not be cached (similar to ccache for object files) * It makes it a blocker to compile the fuzz tests by default for non-fuzz builds #19388, for the aforementioned reasons * The build file is several thousand lines of code, without doing anything meaningful except listing each fuzz target in a highly verbose manner * It makes writing new fuzz tests unnecessarily hard, as build system knowledge is required; Compare that to boost unit tests, which can be added by simply editing an existing cpp file * It encourages fuzz tests that re-use the `buffer` or assume the `buffer` to be concatenations of seeds, which increases complexity of seeds and complexity for the fuzz engine to explore; Thus reducing the effectiveness of the affected fuzz targets Fixes #20088 ACKs for top commit: practicalswift: Tested ACK fa13e1b0c52738492310b6b421d8e38cb04da5b1 sipa: ACK fa13e1b0c52738492310b6b421d8e38cb04da5b1. Reviewed the code changes, and tested the 3 different test_runner.py modes (run once, merge, generate). I also tested building with the new --enable-danger-fuzz-link-all Tree-SHA512: 962ab33269ebd51810924c51266ecc62edd6ddf2fcd9a8c359ed906766f58c3f73c223f8d3cc49f2c60f0053f65e8bdd86ce9c19e673f8c2b3cd676e913f2642
151 lines
5.5 KiB
C++
151 lines
5.5 KiB
C++
// Copyright (c) 2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <chainparams.h>
|
|
#include <chainparamsbase.h>
|
|
#include <net.h>
|
|
#include <net_permissions.h>
|
|
#include <netaddress.h>
|
|
#include <optional.h>
|
|
#include <protocol.h>
|
|
#include <random.h>
|
|
#include <test/fuzz/FuzzedDataProvider.h>
|
|
#include <test/fuzz/fuzz.h>
|
|
#include <test/fuzz/util.h>
|
|
#include <test/util/setup_common.h>
|
|
|
|
#include <cstdint>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
void initialize_net()
|
|
{
|
|
static const BasicTestingSetup basic_testing_setup;
|
|
}
|
|
|
|
FUZZ_TARGET_INIT(net, initialize_net)
|
|
{
|
|
FuzzedDataProvider fuzzed_data_provider(buffer.data(), buffer.size());
|
|
SetMockTime(ConsumeTime(fuzzed_data_provider));
|
|
const std::optional<CAddress> address = ConsumeDeserializable<CAddress>(fuzzed_data_provider);
|
|
if (!address) {
|
|
return;
|
|
}
|
|
const std::optional<CAddress> address_bind = ConsumeDeserializable<CAddress>(fuzzed_data_provider);
|
|
if (!address_bind) {
|
|
return;
|
|
}
|
|
|
|
CNode node{fuzzed_data_provider.ConsumeIntegral<NodeId>(),
|
|
static_cast<ServiceFlags>(fuzzed_data_provider.ConsumeIntegral<uint64_t>()),
|
|
fuzzed_data_provider.ConsumeIntegral<int>(),
|
|
INVALID_SOCKET,
|
|
*address,
|
|
fuzzed_data_provider.ConsumeIntegral<uint64_t>(),
|
|
fuzzed_data_provider.ConsumeIntegral<uint64_t>(),
|
|
*address_bind,
|
|
fuzzed_data_provider.ConsumeRandomLengthString(32),
|
|
fuzzed_data_provider.PickValueInArray({ConnectionType::INBOUND, ConnectionType::OUTBOUND_FULL_RELAY, ConnectionType::MANUAL, ConnectionType::FEELER, ConnectionType::BLOCK_RELAY, ConnectionType::ADDR_FETCH}),
|
|
fuzzed_data_provider.ConsumeBool()};
|
|
node.SetCommonVersion(fuzzed_data_provider.ConsumeIntegral<int>());
|
|
while (fuzzed_data_provider.ConsumeBool()) {
|
|
switch (fuzzed_data_provider.ConsumeIntegralInRange<int>(0, 10)) {
|
|
case 0: {
|
|
node.CloseSocketDisconnect();
|
|
break;
|
|
}
|
|
case 1: {
|
|
node.MaybeSetAddrName(fuzzed_data_provider.ConsumeRandomLengthString(32));
|
|
break;
|
|
}
|
|
case 2: {
|
|
const std::vector<bool> asmap = ConsumeRandomLengthBitVector(fuzzed_data_provider);
|
|
if (!SanityCheckASMap(asmap)) {
|
|
break;
|
|
}
|
|
CNodeStats stats;
|
|
node.copyStats(stats, asmap);
|
|
break;
|
|
}
|
|
case 3: {
|
|
const CNode* add_ref_node = node.AddRef();
|
|
assert(add_ref_node == &node);
|
|
break;
|
|
}
|
|
case 4: {
|
|
if (node.GetRefCount() > 0) {
|
|
node.Release();
|
|
}
|
|
break;
|
|
}
|
|
case 5: {
|
|
if (node.m_addr_known == nullptr) {
|
|
break;
|
|
}
|
|
const std::optional<CAddress> addr_opt = ConsumeDeserializable<CAddress>(fuzzed_data_provider);
|
|
if (!addr_opt) {
|
|
break;
|
|
}
|
|
node.AddAddressKnown(*addr_opt);
|
|
break;
|
|
}
|
|
case 6: {
|
|
if (node.m_addr_known == nullptr) {
|
|
break;
|
|
}
|
|
const std::optional<CAddress> addr_opt = ConsumeDeserializable<CAddress>(fuzzed_data_provider);
|
|
if (!addr_opt) {
|
|
break;
|
|
}
|
|
FastRandomContext fast_random_context{ConsumeUInt256(fuzzed_data_provider)};
|
|
node.PushAddress(*addr_opt, fast_random_context);
|
|
break;
|
|
}
|
|
case 7: {
|
|
const std::optional<CInv> inv_opt = ConsumeDeserializable<CInv>(fuzzed_data_provider);
|
|
if (!inv_opt) {
|
|
break;
|
|
}
|
|
node.AddKnownTx(inv_opt->hash);
|
|
break;
|
|
}
|
|
case 8: {
|
|
node.PushTxInventory(ConsumeUInt256(fuzzed_data_provider));
|
|
break;
|
|
}
|
|
case 9: {
|
|
const std::optional<CService> service_opt = ConsumeDeserializable<CService>(fuzzed_data_provider);
|
|
if (!service_opt) {
|
|
break;
|
|
}
|
|
node.SetAddrLocal(*service_opt);
|
|
break;
|
|
}
|
|
case 10: {
|
|
const std::vector<uint8_t> b = ConsumeRandomLengthByteVector(fuzzed_data_provider);
|
|
bool complete;
|
|
node.ReceiveMsgBytes(b, complete);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
(void)node.GetAddrLocal();
|
|
(void)node.GetAddrName();
|
|
(void)node.GetId();
|
|
(void)node.GetLocalNonce();
|
|
(void)node.GetLocalServices();
|
|
(void)node.GetMyStartingHeight();
|
|
const int ref_count = node.GetRefCount();
|
|
assert(ref_count >= 0);
|
|
(void)node.GetCommonVersion();
|
|
(void)node.RelayAddrsWithConn();
|
|
|
|
const NetPermissionFlags net_permission_flags = fuzzed_data_provider.ConsumeBool() ?
|
|
fuzzed_data_provider.PickValueInArray<NetPermissionFlags>({NetPermissionFlags::PF_NONE, NetPermissionFlags::PF_BLOOMFILTER, NetPermissionFlags::PF_RELAY, NetPermissionFlags::PF_FORCERELAY, NetPermissionFlags::PF_NOBAN, NetPermissionFlags::PF_MEMPOOL, NetPermissionFlags::PF_ISIMPLICIT, NetPermissionFlags::PF_ALL}) :
|
|
static_cast<NetPermissionFlags>(fuzzed_data_provider.ConsumeIntegral<uint32_t>());
|
|
(void)node.HasPermission(net_permission_flags);
|
|
(void)node.ConnectedThroughNetwork();
|
|
}
|