cryptogera/litecoin
cryptogera/litecoin
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
litecoin/src
History
Andrew Chow 194710d8ff
Merge bitcoin/bitcoin#25481: wallet: unify max signature logic 
d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9 wallet: use CCoinControl to estimate signature size (S3RK)
a94659c84ee10ac5915eb5a6b654435183d88521 wallet: replace GetTxSpendSize with CalculateMaximumSignedInputSize (S3RK)

Pull request description:

  Currently `DummySignTx` and `DummySignInput` use different ways to determine signature size.
  This PR unifies the way wallet estimates signature size for various inputs.
  Instead of passing boolean flags from calling code the `use_max_sig` is now calculated at the place of signature creation using information available in `CCoinControl`

ACKs for top commit:
  achow101:
    ACK d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9
  theStack:
    Code-review ACK d54c5c8b1b1a38b5b38e6878aea0fa8d6c1ad7e9

Tree-SHA512: e790903ad4683067070aa7dbf7434a1bd142282a5bc425112e64d88d27559f1a2cd60c68d6022feaf6b845237035cb18ece10f6243d719ba28173b69bd99110a
2022-07-08 10:27:06 -04:00
..
bench
Merge bitcoin/bitcoin#25481: wallet: unify max signature logic
2022-07-08 10:27:06 -04:00
common
refactor: make GetRand a template, remove GetRandInt
2022-04-22 09:04:39 -05:00
compat
compat: remove glibcxx sanity checks
2022-05-28 09:43:02 +01:00
config
…
consensus
Remove LOCKTIME_MEDIAN_TIME_PAST constant
2022-06-22 09:54:15 +02:00
crc32c
…
crypto
build: test for timingsafe_bcmp
2022-06-10 12:39:08 +01:00
index
Merge bitcoin/bitcoin#24832: index: Verify the block filter hash when reading the filter from disk.
2022-07-07 17:59:02 +01:00
init
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
interfaces
refactor: use ForEachAddrBookEntry in interfaces::getAddresses
2022-06-21 10:23:20 -03:00
ipc
…
kernel
Introduce mempoolfullrbf node setting.
2022-07-06 20:57:29 -04:00
leveldb
build: Minor leveldb subtree update
2022-03-02 15:25:48 +01:00
logging
…
minisketch
Update minisketch subtree to latest master
2022-06-29 16:35:02 +01:00
node
Merge bitcoin/bitcoin#25500: refactor: Move inbound eviction logic to its own translation unit
2022-07-07 17:54:37 +01:00
policy
Merge bitcoin/bitcoin#25290: [kernel 3a/n] Decouple CTxMemPool from ArgsManager
2022-06-29 09:13:31 +02:00
primitives
…
qt
Merge bitcoin-core/gui#617: Reset options, notify user about backup creation
2022-06-29 00:35:06 +02:00
rpc
Merge bitcoin/bitcoin#25353: Add a -mempoolfullrbf node setting
2022-07-08 11:06:24 +02:00
script
sign: Use sigdata taproot spenddata when signing
2022-06-27 16:47:48 -04:00
secp256k1
Update secp256k1 subtree to latest upstream master
2022-06-11 14:55:18 +01:00
support
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
test
Merge bitcoin/bitcoin#25500: refactor: Move inbound eviction logic to its own translation unit
2022-07-07 17:54:37 +01:00
univalue
refactor: cleanups post unsubtree'ing univalue
2022-06-15 12:56:44 +01:00
util
Merge bitcoin/bitcoin#24836: add RPC (-regtest only) for testing package policy
2022-06-30 15:43:50 +01:00
wallet
Merge bitcoin/bitcoin#25481: wallet: unify max signature logic
2022-07-08 10:27:06 -04:00
zmq
scripted-diff: remove duplicate categories from LogPrint output
2022-06-06 12:12:03 +02:00
.bear-tidy-config
tidy: enable modernize-use-nullptr
2022-04-26 10:43:33 +01:00
.clang-format
…
.clang-tidy
tidy: use modernize-use-default-member-init
2022-05-17 17:19:07 +01:00
addrdb.cpp
Merge bitcoin/bitcoin#24925: refactor: make GetRand a template, remove GetRandInt
2022-05-12 08:57:22 +02:00
addrdb.h
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
addrman_impl.h
[netgroupman] Add GetMappedAS() and GetGroup()
2022-04-20 14:35:52 +01:00
addrman.cpp
Remove redundant nLastTry check
2022-06-08 13:35:32 +02:00
addrman.h
[net] Move asmap into NetGroupManager
2022-04-20 14:29:29 +01:00
arith_uint256.cpp
Merge bitcoin/bitcoin#24077: util: Make base_uint::GetHex() and base_uint::SetHex() not depend on uint256
2022-04-14 07:15:22 +02:00
arith_uint256.h
Remove duplicate static_asserts
2022-04-14 19:26:22 +02:00
attributes.h
…
banman.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
banman.h
refactor: Add thread safety annotation to BanMan::SweepBanned()
2022-05-20 15:17:00 +02:00
base58.cpp
scripted-diff: Rename ValidAsCString to ContainsNoNUL
2022-04-27 14:16:35 +02:00
base58.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
bech32.cpp
Avoid implicit-integer-sign-change in bech32.cpp
2022-02-25 09:43:54 +01:00
bech32.h
…
bitcoin-chainstate.cpp
kernel: SanityChecks: Return an error struct
2022-06-02 12:22:46 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
compat: Consolidate mingw-w64 ASLR workaround for upstream libsecp changes
2022-06-11 14:55:13 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
compat: Consolidate mingw-w64 ASLR workaround for upstream libsecp changes
2022-06-11 14:55:13 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
compat: Consolidate mingw-w64 ASLR workaround for upstream libsecp changes
2022-06-11 14:55:13 +01:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
compat: Consolidate mingw-w64 ASLR workaround for upstream libsecp changes
2022-06-11 14:55:13 +01:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
blockencodings.cpp
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockencodings.h
Remove fUseWTXID parameter from CBlockHeaderAndShortTxIDs constructor
2022-05-17 10:37:10 +01:00
blockfilter.cpp
Make sanity check in GCSFilter constructor optional
2022-05-02 16:04:00 +09:00
blockfilter.h
Make sanity check in GCSFilter constructor optional
2022-05-02 16:04:00 +09:00
chain.cpp
…
chain.h
…
chainparams.cpp
refactor: introduce single-separator split helper SplitString
2022-04-11 22:19:46 +02:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
net: Update hardcoded seeds for 23.x
2022-02-22 15:15:27 +01:00
checkqueue.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
clientversion.cpp
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
clientversion.h
refactor: shift CopyrightHolders() and LicenseInfo() to clientversion.cpp
2022-02-22 15:36:19 +00:00
coins.cpp
…
coins.h
refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize()
2022-06-21 16:19:10 +02:00
compat.h
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
compressor.cpp
…
compressor.h
…
core_io.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
core_memusage.h
…
core_read.cpp
core_read: Replace boost::split with SplitString
2022-05-04 07:34:47 +02:00
core_write.cpp
refactor: add stdd:: includes to core_write
2022-03-30 20:11:15 +01:00
cuckoocache.h
…
dbwrapper.cpp
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
dbwrapper.h
refactor: remove unused method CDBWrapper::CompactRange
2022-06-23 13:59:25 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
deploymentstatus.h
validation: move g_versionbitscache into ChainstateManager
2022-05-10 12:09:33 +10:00
dummywallet.cpp
…
external_signer.cpp
parsing external signer master fingerprint string as bytes instead of caring for lower/upper case in ExternalSigner::SignTransaction
2022-05-07 11:09:52 +02:00
external_signer.h
…
flatfile.cpp
Disallow more unsafe string->path conversions allowed by path append operators
2022-04-21 12:01:00 -05:00
flatfile.h
…
fs.cpp
build: globally define NOMINMAX
2022-06-20 12:22:05 +01:00
fs.h
Disallow more unsafe string->path conversions allowed by path append operators
2022-04-21 12:01:00 -05:00
hash.cpp
…
hash.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
httprpc.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#25338: scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-15 08:10:38 +02:00
httpserver.h
Merge bitcoin/bitcoin#24681: build: Bump libevent minimum version up to 2.1.8
2022-04-06 13:19:36 +01:00
i2p.cpp
net: rename Sock::Reset() to Sock::Close() and make it private
2022-06-22 09:19:43 +02:00
i2p.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#25353: Add a -mempoolfullrbf node setting
2022-07-08 11:06:24 +02:00
init.h
Move init::SanityCheck to kernel::SanityCheck
2022-06-02 11:42:12 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
refactor: Use Span of std::byte in CExtKey::SetSeed
2022-04-27 19:53:37 +02:00
key.h
refactor: Use Span of std::byte in CExtKey::SetSeed
2022-04-27 19:53:37 +02:00
logging.cpp
logging: fix logging empty threadname
2022-06-02 22:30:30 +08:00
logging.h
logging: add LogPrintfCategory to log unconditionally with category
2022-06-08 14:02:54 +02:00
Makefile.am
Merge bitcoin/bitcoin#25500: refactor: Move inbound eviction logic to its own translation unit
2022-07-07 17:54:37 +01:00
Makefile.bench.include
Merge bitcoin/bitcoin#24852: util: optimize HexStr
2022-05-04 20:36:09 +02:00
Makefile.crc32c.include
build: Create .la library for crc32c
2022-04-26 16:25:38 -04:00
Makefile.leveldb.include
Use more specific path when including memenv.h header
2022-06-23 15:33:01 +02:00
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: Pre-branch translation updates for 23.x
2022-02-28 16:59:56 +01:00
Makefile.qt.include
qt, refactor: Add transactionoverviewwidget.cpp source file
2022-06-14 16:55:22 +02:00
Makefile.qttest.include
build: Remove vestigial LIBLEVELDB_SSE42
2022-04-11 16:56:34 -04:00
Makefile.test_fuzz.include
build: Don't add unrelated libs to LIBTEST_*
2022-04-11 16:56:34 -04:00
Makefile.test_util.include
build: Don't add unrelated libs to LIBTEST_*
2022-04-11 16:56:34 -04:00
Makefile.test.include
fuzz: add low-level target for txorphanage
2022-07-06 22:13:54 +08:00
Makefile.univalue.include
…
mapport.cpp
Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)
2022-04-26 10:41:45 +01:00
mapport.h
…
mempool_args.cpp
Introduce mempoolfullrbf node setting.
2022-07-06 20:57:29 -04:00
mempool_args.h
mempool: Introduce (still-unused) MemPoolLimits
2022-06-28 15:46:10 -04:00
memusage.h
…
merkleblock.cpp
doc: fix various typos
2021-01-04 12:31:31 +08:00
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#25454: p2p: Avoid multiple getheaders messages in flight to the same peer
2022-07-04 21:28:21 +01:00
net_processing.h
Pass Peer& to Misbehaving()
2022-05-27 16:59:45 +02:00
net_types.cpp
scripted-diff: Use getInt<T> over get_int/get_int64
2022-05-18 19:15:03 +02:00
net_types.h
…
net.cpp
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
net.h
[net] Move eviction logic to its own file
2022-07-06 18:13:54 +02:00
netaddress.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
netaddress.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
netbase.cpp
scripted-diff: Convert global Mutexes to GlobalMutexes
2022-05-21 01:23:23 +10:00
netbase.h
net: use Sock::SetSockOpt() instead of standalone SetSocketNoDelay()
2022-04-15 09:39:25 +02:00
netgroup.cpp
[netgroup] Use nStartByte as offset for the last byte of the group
2022-04-25 15:09:14 +02:00
netgroup.h
[netgroupman] Remove NetGroupManager::GetAsmap()
2022-04-20 14:35:53 +01:00
netmessagemaker.h
…
noui.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
noui.h
…
outputtype.cpp
…
outputtype.h
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
pow.cpp
…
pow.h
…
prevector.h
Merge bitcoin/bitcoin#24962: prevector: enforce is_trivially_copyable_v
2022-05-16 16:25:47 +02:00
protocol.cpp
…
protocol.h
Remove no-op TIME_INIT on deser
2022-05-30 13:55:39 +02:00
psbt.cpp
psbt: Implement merge for Taproot fields
2022-06-27 16:47:48 -04:00
psbt.h
Implement de/ser of PSBT's Taproot fields
2022-06-27 16:47:48 -04:00
pubkey.cpp
…
pubkey.h
Add serialization methods to XOnlyPubKey
2022-06-27 16:47:48 -04:00
random.cpp
Use consistent wording in log
2022-06-21 22:54:55 +07:00
random.h
Merge bitcoin/bitcoin#24925: refactor: make GetRand a template, remove GetRandInt
2022-05-12 08:57:22 +02:00
randomenv.cpp
tidy: add readability-redundant-declaration
2022-05-01 10:39:40 +01:00
randomenv.h
…
rest.cpp
rest/getutxos: Don't construct empty mempool
2022-06-15 17:28:55 -04:00
rest.h
Handle query string when parsing data format
2022-03-10 12:01:53 +01:00
reverse_iterator.h
…
scheduler.cpp
refactor: use C++11 default initializers
2022-05-17 17:18:58 +01:00
scheduler.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
serialize.h
scripted-diff: rename BytePtr to AsBytePtr
2022-04-26 09:41:45 +01:00
shutdown.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
scripted-diff: rename BytePtr to AsBytePtr
2022-04-26 09:41:45 +01:00
streams.h
…
sync.cpp
…
sync.h
sync.h: Imply negative assertions when calling LOCK
2022-05-21 01:23:23 +10:00
threadinterrupt.cpp
…
threadinterrupt.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
threadsafety.h
…
timedata.cpp
scripted-diff: Avoid incompatibility with CMake AUTOUIC feature
2022-06-14 10:38:51 +02:00
timedata.h
timedata: make it possible to reset the state
2022-03-02 15:40:30 +01:00
tinyformat.h
…
torcontrol.cpp
logging: use LogPrintfCategory rather than a manual category
2022-06-08 14:02:54 +02:00
torcontrol.h
torcontrol: Query Tor for correct -onion configuration
2022-03-15 01:33:52 +00:00
txdb.cpp
refactor: remove unused methods {CDBIterator,CCoinsViewDBCursor}::GetValueSize()
2022-06-21 16:19:10 +02:00
txdb.h
Remove utxo db upgrade code
2022-03-10 13:05:29 +01:00
txmempool.cpp
Introduce mempoolfullrbf node setting.
2022-07-06 20:57:29 -04:00
txmempool.h
Introduce mempoolfullrbf node setting.
2022-07-06 20:57:29 -04:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Introduce mempoolfullrbf node setting.
2022-07-06 20:57:29 -04:00
validation.h
mempool: Pass in -mempoolexpiry instead of referencing gArgs
2022-06-28 15:42:23 -04:00
validationinterface.cpp
refactor: Remove defunct attributes.h includes
2022-05-21 13:54:33 -05:00
validationinterface.h
scripted-diff: Rename MainSignalsInstance() class to MainSignalsImpl()
2022-05-09 18:35:44 +02:00
version.h
…
versionbits.cpp
Sanity assert GetAncestor() != nullptr where appropriate
2022-05-05 15:55:44 +02:00
versionbits.h
Increase threadsafety annotation coverage
2022-05-12 02:25:55 +10:00
walletinitinterface.h
…
warnings.cpp
scripted-diff: Convert global Mutexes to GlobalMutexes
2022-05-21 01:23:23 +10:00
warnings.h
…