3113 Commits

Author SHA1 Message Date
David Burkett
91a8c4e6ae * Prevent MWEB txs from being accepted to mempool before activation
* Add 'mweb' rule to getblocktemplate request
* Add 'mweb' field to getblocktemplate reply
* Build out MWEB serialization for better functional test coverage
2022-05-08 18:18:03 +01:00
David Burkett
0e1f4e1671 MWEB: Functional tests 2022-05-08 18:18:03 +01:00
David Burkett
2fbe202623 Litecoin: Add -mempoolreplacement flag and disable RBF by default 2022-01-27 20:17:51 -05:00
David Burkett
f1f22275de * Changing taproot start & timeout heights
* Minor version bits cleanup
2021-10-03 05:33:42 -04:00
David Burkett
3865f76a97 Implement BIP8 for taproot 2021-09-13 14:32:14 -04:00
David Burkett
beb0f22f26 Test fixes 2021-09-13 14:04:21 -04:00
Adrian Gallagher
61e2c39ae8
Litecoin: bech32m tests 2021-05-17 23:51:28 -07:00
Adrian Gallagher
0a994ef374
Litecoin: Functional 2021-05-17 23:03:23 -07:00
Adrian Gallagher
5f4e932069
Litecoin: Validation 2021-05-17 23:03:22 -07:00
Adrian Gallagher
478dabad29
Litecoin: Make linter happy 2021-05-17 23:03:22 -07:00
Adrian Gallagher
c6b319d9d2
Litecoin: More functional tests 2021-05-17 23:03:22 -07:00
Adrian Gallagher
60fb716792
Litecoin: Functional tests 2021-05-17 23:03:21 -07:00
Adrian Gallagher
86fe3c68b8
Litecoin: Functional tests 2021-05-17 23:03:15 -07:00
Adrian Gallagher
6ece9ae091
Litecoin: Branding 2021-05-17 22:25:55 -07:00
Adrian Gallagher
98528bf8dc
Litecoin: Multisig 2021-05-17 22:25:54 -07:00
Adrian Gallagher
d87e597b3b
Litecoin: HRPs 2021-05-17 22:25:54 -07:00
Adrian Gallagher
f522022273
Litecoin: Function tests 2021-05-17 22:25:52 -07:00
Adrian Gallagher
d1d5fa80fb
Litecoin: Tests 2021-05-17 22:25:51 -07:00
Adrian Gallagher
a1e47d9f0e
Litecoin: Fix various tests 2021-05-17 22:25:50 -07:00
Adrian Gallagher
e16dd76732
Litecoin: Multisig code testing 2021-05-17 22:25:18 -07:00
Xinxi Wang
c7c4806e7a
Litecoin: M prefix added for script addresses 2021-05-17 22:15:44 -07:00
Adrian Gallagher
0de5edb7e2
Litecoin: Disable RBF 2021-05-17 22:15:15 -07:00
Adrian Gallagher
44d25fdf26
Litecoin: Fix more functional tests 2021-05-17 22:15:14 -07:00
Adrian Gallagher
dcf565982a
Litecoin: Fix various tests 2021-05-17 22:15:14 -07:00
Adrian Gallagher
86b0e12da3
Litecoin: Branding 2021-05-17 22:15:08 -07:00
Adrian Gallagher
a66fc11fc4
Litecoin: Protocol and default settings
0) Adjust BIP30 enforcement values

1) Reduce amount that peers can adjust our time to eliminate an attack vector. Thanks to
coblee for this fix.

2) Zeitgeist2 patch - thanks to Lolcust and ArtForz. This fixes an issue where a
51% attack can change difficulty at will. Go back the full period unless it's the
first retarget after genesis.

3) Avoid overflow in CalculateNextWorkRequired(). Thanks to pooler for the overflow fix.

4) Zeitgeist2 bool fshift bnNew.bits(). Thanks to romanornr for this path.

5) SegWit ContextualCheckBlockHeader adjustment and extra coverage.

6) Reject peer proto version below 70002. Thanks to wtogami for this patch.

7) Send final alert message to nodes warning about removal of the alert system. Thanks to coblee for this patch.

8) Adjust default settings for Litecoin.

9) Adjust STALE_CHECK_INTERVAL value
2021-05-17 22:14:35 -07:00
Adrian Gallagher
f3e8486f00
Litecoin: Fix various tests 2021-05-17 22:14:32 -07:00
Anthony Towns
4cab84cfdf
versionbits: Add support for delayed activation
Github-Pull: #21377
Rebased-From: 73d4a706393e6dbd6b6d6b6428f8d3233ac0a2d8
2021-04-15 12:03:27 -04:00
Andrew Chow
f79189ca54
Test that signrawtx works when a signed CSV and CLTV inputs are present
Github-Pull: #21166
Rebased-From: a97a9298cea085858e1a65a5e9b20d7a9e0f7303
2021-04-08 18:19:02 -04:00
Pieter Wuille
f2195d7c4a Backport invalid address tests
Reduced version of the test from master/#20861 by John Newbery.

Github-Pull: #20861
Rebased-From: fe5e495c31de47b0ec732b943db11fe345d874af
2021-03-27 12:09:48 -07:00
Pieter Wuille
593e206627 Use Bech32m encoding for v1+ segwit addresses
This also includes updates to the Python test framework implementation,
test vectors, and release notes.

Github-Pull: #20861
Rebased-From: fe5e495c31de47b0ec732b943db11fe345d874af
2021-03-27 12:09:44 -07:00
Andrew Chow
36ecf5eb87 tests: Test that a fully signed tx given to signrawtx is unchanged
Tests that a fully signed transaction given to
signrawtransactionwithwallet is both unchanged and marked as complete.
This tests for a regression in 0.20 where the transaction would not be
marked as complete.

Github-Pull: #20562
Rebased-From: 773c42b265fb2212b5cb8785b7226a206d063543
2021-03-06 08:18:16 +01:00
Jon Atack
4ef1e4bd40 test: disallow sendtoaddress/sendmany when private keys disabled
Github-Pull: #21201
Rebased-From: 6bfbc97d716faad38c87603ac6049d222236d623
2021-02-19 12:47:43 +01:00
MarcoFalke
08dada8456 util: Disallow negative mocktime
Signed-off-by: practicalswift <practicalswift@users.noreply.github.com>

Github-Pull: #21043
Rebased-From: 3ddbf22ed179a2db733af4b521bec5d2b13ebf4b
2021-02-11 12:42:40 +01:00
Bruno Garcia
4607019798 fix the unreachable code at feature_taproot
Github-Pull: #21081
Rebased-From: 5e0cd25e29541e6c19559fb5c2555e008ed896fa
2021-02-08 08:51:02 +01:00
Vasil Dimov
bdce029191 test: add test for banning of non-IP addresses
Co-authored-by: Jon Atack <jon@atack.com>

Github-Pull: #20852
Rebased-From: 39b43298d9c54f9c18bef36f3d5934f57aefd088
2021-01-11 11:57:21 +01:00
Pieter Wuille
ce13b99020 Add regression test for incorrect decoding
Github-Pull: #20595
Rebased-From: 0f949cde3dff15170db7930b0f7345ff995c267d
2020-12-10 11:37:57 +01:00
Jon Atack
0d3c140c4d test: add coverage for passing fee rate as a string
Github-Pull: #20573
Rebased-From: 6fa72ceb8021c3b5aea62f6cfe92665c29212923
2020-12-10 11:37:41 +01:00
Jon Atack
06c84232b3 wallet, bugfix: allow send to take string fee rate values
Github-Pull: #20573
Rebased-From: ce207d6b93d35bc02fcd2dd28f1fd95869261d43
2020-12-10 11:37:36 +01:00
Pieter Wuille
bead935470 Send and require SENDADDRV2 before VERACK
See the corresponding BIP change: https://github.com/bitcoin/bips/pull/1043

Github-Pull: #20564
Rebased-From: 1583498fb6781c01ca2f33c09319ed793964c574
2020-12-10 11:37:22 +01:00
Jon Atack
6e4969f76f
Update feeRate (BTC/kvB) to fee_rate (sat/vB) in wallet_bumpfee
as the feeRate argument should soon be deprecated.

Also loosen one test (and a similar one) that caused a one-off CI failure with:
expected message
'Insufficient total fee 0.00000141, must be at least 0.00001704 (oldFee 0.00000999 + incrementalFee 0.00000705)'
actual message
'Insufficient total fee 0.00000141, must be at least 0.00001712 (oldFee 0.00001007 + incrementalFee 0.00000705)'

Github-Pull: #20426
Rebased-From: 3f1e10b2b1cd11f7112fbad6355464bd4adbbc5c
2020-11-26 19:32:06 +01:00
Jon Atack
54e1edcc2b
Allow zero-fee fundrawtxn and walletcreatefundedpsbt calls
A check to raise an error on zero-fee txns was mistakenly extended in commit
a0d4957 from the bumpfee and send{toaddress, many} RPCs to also include
fundrawtransaction and walletcreatefundedpsbt.

This commit overrides zero fee rate checking for these two RPCs, not only for
the feeRate (BTC/kvB) arg to return to previous behavior, but also for the new
fee_rate (sat/vB) arg.

Github-Pull: #20426
Rebased-From: 1b3d7009280595108eb22ac1188bc43678
2020-11-26 19:31:26 +01:00
MarcoFalke
9facca3ce0
Merge #20490: [backport] wallet: upgradewallet fixes, improvements, test coverage
ca8cd893bb56bf5d455154b0498b1f58f77d20ed wallet: fix and improve upgradewallet error responses (Jon Atack)
99d56e357159c7154f69f28cb5587c5ca20d6594 wallet: fix and improve upgradewallet result responses (Jon Atack)
2498b04ce88696a3216fc38b7d393906b733e8b1 Don't upgrade to HD split if it is already supported (Andrew Chow)
c46c18b788cb0862aafbb116fd37936cbed6a431 wallet: refactor GetClosestWalletFeature() (Jon Atack)

Pull request description:

  Github-Pull: #20403
  Rebased-From: c46c18b788cb0862aafbb116fd37936cbed6a431

  Github-Pull: #20403
  Rebased-From: 2498b04ce88696a3216fc38b7d393906b733e8b1

  Github-Pull: #20403
  Rebased-From: 99d56e357159c7154f69f28cb5587c5ca20d6594

  Github-Pull: #20403
  Rebased-From: ca8cd893bb56bf5d455154b0498b1f58f77d20ed

Top commit has no ACKs.

Tree-SHA512: b18a1d015c963298740c585385eaa056988464112c88a519fe619be22dc78a8f6a102365cf799c50b781a77a09bec82b58ce411ab007b48f8b5de876e9c75060
2020-11-25 18:03:53 +01:00
MarcoFalke
d47d16025e
Merge #20485: [backport] wallet: Do not treat default constructed types as None-type
fa69c2c78455fd0dc436018fece9ff7fc83a180d wallet: Do not treat default constructed types as None-type (MarcoFalke)
fac4e136fa3d0fab7fde900a6be921313e16e7a6 refactor: Change pointer to reference because it can not be null (MarcoFalke)

Pull request description:

  Github-Pull: #20410
  Rebased-From: fac4e136fa3d0fab7fde900a6be921313e16e7a6

  Github-Pull: #20410
  Rebased-From: fa69c2c78455fd0dc436018fece9ff7fc83a180d

Top commit has no ACKs.

Tree-SHA512: 05c3fe29677710b57dcc482fd529b0ab79475519f60f9cfde19f956c4e2212d09b042af458ec4f1272c581360ce841b735dca4df144e0798b3ccf16547de9cd0
2020-11-25 11:27:42 +01:00
MarcoFalke
4e964094db
Merge #20486: [backport] test: Fix intermittent issue in mempool_compatibility
fa05d19bd6ba619bb3f9aabc05c439cd18d34544 test: Fix intermittent issue in mempool_compatibility (MarcoFalke)

Pull request description:

  Github-Pull: #20456
  Rebased-From: fa05d19bd6ba619bb3f9aabc05c439cd18d34544

Top commit has no ACKs.

Tree-SHA512: c07ed3ffab315da2bf70427882e2da8216964fef97dd538d7c46c5d5b3563b0732626ffbe4b0e19537ad49a8542eedb3c08850cccacdef466f24582defe99d22
2020-11-25 11:25:33 +01:00
MarcoFalke
3fae2f95f1
Merge #20475: [backport] RPC: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet
b1f59d55d920d2b35269b474762f94fec87bfb16 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet (Luke Dashjr)

Pull request description:

  Github-Pull: #20462
  Rebased-From: b1f59d55d920d2b35269b474762f94fec87bfb16

Top commit has no ACKs.

Tree-SHA512: 2ee0a8a280f56baf196a3a48a59620f297075d23898e6aa3b3e677cdde74826688614d27a477a1448306234c2109fa39083946f691ced10d8bbc53006730784e
2020-11-24 17:28:19 +01:00
Luke Dashjr
b1f59d55d9 RPC/Wallet: unloadwallet: Clarify docs/error when both the RPC endpoint and wallet_name parameter specify a wallet 2020-11-24 05:31:58 +00:00
MarcoFalke
fa05d19bd6
test: Fix intermittent issue in mempool_compatibility 2020-11-23 09:27:36 +01:00
MarcoFalke
bf9548bc59
Merge #20431: [backport 0.21] tests: shrink feature_taproot transfer of funds tx
7ffac12545328cadd92a3caec4f1c6ca7c127493 tests: shrink feature_taproot transfer of funds tx (Anthony Towns)

Pull request description:

  Github-Pull: #20428
  Rebased-From: 7ffac12545328cadd92a3caec4f1c6ca7c127493

Top commit has no ACKs.

Tree-SHA512: 4e6b37a44dca3e29d5168b7eb9238a7ce0bbb9b0924a21671537a7c534790fb6b05b1a30a404db434fade030b4f369adfc73694ef85d91884bb7349adddc5f6a
2020-11-20 11:50:10 +01:00
Anthony Towns
7ffac12545 tests: shrink feature_taproot transfer of funds tx 2020-11-20 07:29:42 +10:00