Antoine Riard f77b1de16f Only return early from BlockUntilSyncedToCurrentChain if current tip ...

is exact match

In the next commit, we start using BlockConnected/BlockDisconnected
callbacks to establish tx depth, rather than querying the chain
directly.

Currently, BlockUntilSyncedToCurrentChain will return early if
the best block processed by the wallet is a descendant of the node'tip.
That means that in the case of a re-org, it won't wait for the
BlockDisconnected callbacks that have been enqueued during the re-org
but have not yet been triggered in the wallet.

Change BlockUntilSyncedToCurrentChain to only return early if the
wallet's m_last_block_processed matches the tip exactly. This ensures
that there are no BlockDisconnected or BlockConnected callbacks
in-flight.

2019-11-06 13:36:43 -05:00

..

test

Add block_height field in struct Confirmation

2019-11-06 13:29:53 -05:00

coincontrol.cpp

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coincontrol.h

refactor: Replace all uses of boost::optional with our own Optional type

2019-10-30 14:27:31 +01:00

coinselection.cpp

refactor: Replace all uses of boost::optional with our own Optional type

2019-10-30 14:27:31 +01:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

Remove unused includes

2019-10-15 22:56:43 +00:00

db.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

db.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

feebumper.cpp

[wallet] Remove state argument from CWallet::CommitTransaction

2019-10-18 09:43:01 -04:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Pass NodeContext, ConnMan, BanMan references more places

2019-10-28 10:30:51 -04:00

ismine.h

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

load.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

psbtwallet.cpp

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

psbtwallet.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcdump.cpp

Refactor some importprunedfunds checks with guard clause

2019-11-06 13:36:43 -05:00

rpcwallet.cpp

Merge #17258: Fix issue with conflicted mempool tx in listsinceblock

2019-11-05 21:56:34 +13:00

rpcwallet.h

Avoid using g_rpc_node global in wallet code

2019-10-28 10:30:51 -04:00

scriptpubkeyman.cpp

Refactor: Move nTimeFirstKey accesses out of CWallet

2019-11-01 22:58:05 -04:00

scriptpubkeyman.h

Refactor: Move nTimeFirstKey accesses out of CWallet

2019-11-01 22:58:05 -04:00

wallet.cpp

Only return early from BlockUntilSyncedToCurrentChain if current tip

2019-11-06 13:36:43 -05:00

wallet.h

Add block_height field in struct Confirmation

2019-11-06 13:29:53 -05:00

walletdb.cpp

Refactor: Split up CWallet and LegacyScriptPubKeyMan and classes

2019-10-25 19:20:24 -04:00

walletdb.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

wallettool.cpp

Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan

2019-10-29 08:19:23 -04:00

wallettool.h

Remove unused includes

2019-10-15 22:56:43 +00:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

Move wallet enums to walletutil.h

2019-10-25 19:20:24 -04:00