1f3278ecab
Changes are as below: Wrap CBlockHeader::nVersion into a new class (CBlockVersion). This allows to take care of interpreting the field into a base version, auxpow flag and the chain ID. Update getauxblock.py for new 'generate' RPC call. Add 'auxpow' to block JSON. Accept auxpow as PoW verification. Add unit tests for auxpow verification. Add check for memory-layout of CBlockVersion. Weaken auxpow chain ID checks for the testnet. Allow Params() to overrule when to check the auxpow chain ID and for legacy blocks. Use this to disable the checks on testnet. Introduce CPureBlockHeader. Split the block header part that is used by auxpow and the "real" block header (that uses auxpow) to resolve the cyclic dependency between the two. Differentiate between uint256 and arith_uint256. This change was done upstream, modify the auxpow code. Add missing lock in auxpow_tests. Fix REST header check for auxpow headers. Those can be longer, thus take that into account. Also perform the check actually on an auxpow header. Correctly set the coinbase for getauxblock results. Call IncrementExtraNonce in getauxblock so that the coinbase is actually initialised with the stuff it should be. (BIP30 block height and COINBASE_FLAGS.) Implement getauxblock plus regression test. Turn auxpow test into FIXTURE test. This allows using of the Params() calls. Move CMerkleTx code to auxpow.cpp. Otherwise we get linker errors when building without wallet. Fix rebase with BIP66. Update the code to handle BIP66's nVersion=3. Enforce that auxpow parent blocks have no auxpow block version. This is for compatibility with namecoind. See also https://github.com/namecoin/namecoin/pull/199. Move auxpow-related parameters to Consensus::Params.
Regression tests
test_framework/authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework/test_framework.py
Base class for new regression tests.
test_framework/util.py
Generally useful functions.
test_framework/mininode.py
Basic code to support p2p connectivity to a bitcoind.
test_framework/comptool.py
Framework for comparison-tool style, p2p tests.
test_framework/script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
test_framework/blockstore.py
Implements disk-backed block and tx storage.
test_framework/key.py
Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)
test_framework/bignum.py
Helpers for script.py
test_framework/blocktools.py
Helper functions for creating blocks and transactions.
P2P test design notes
Mininode
-
mininode.pycontains all the definitions for objects that pass over the network (CBlock,CTransaction, etc, along with the network-level wrappers for them,msg_block,msg_tx, etc). -
P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.
-
NodeConnis the class used to connect to a bitcoind. If you implement a callback class that derives fromNodeConnCBand pass that to theNodeConnobject, your code will receive the appropriate callbacks when events of interest arrive. -
You can pass the same handler to multiple
NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test. -
Call
NetworkThread.start()after allNodeConnobjects are created to start the networking thread. (Continue with the test logic in your existing thread.) -
RPC calls are available in p2p tests.
-
Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples:
p2p-accept-block.py,maxblocksinflight.py.
Comptool
-
Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.
-
Set the
num_nodesvariable (defined inComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then--testbinarycan be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then--refbinarycan be optionally used to change the bitcoind that will be used on nodes 2 and up. -
Implement a (generator) function called
get_tests()which yieldsTestInstances. EachTestInstanceconsists of:- a list of
[object, outcome, hash]entriesobjectis aCBlock,CTransaction, orCBlockHeader.CBlock's andCTransaction's are tested for acceptance.CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.outcomeisTrue,False, orNone. IfTrueorFalse, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. IfNoneis specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.hashis the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
sync_every_block:True/False. IfFalse, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. IfTrue, then each block is tested in sequence and synced (this is slower when processing many blocks).sync_every_transaction:True/False. Analogous tosync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. IfTrueorFalse, then only the last tx's acceptance is tested against the given outcome.
- a list of
-
For examples of tests written in this framework, see
invalidblockrequest.pyandp2p-fullblocktest.py.