Wladimir J. van der Laan a884b32854

Merge #16911: wallet: Only check the hash of transactions loaded from disk ...

cd68594dcdadc195bd2ea9394fa04edfdbdf1149 Only check the hash of transactions loaded from disk (Andrew Chow)

Pull request description:

  It feels unnecessary to do a full `CheckTransaction` for every transaction saved in the wallet. It should not be possible for an invalid transaction to get into the wallet in the first place, and if there is any disk corruption, the hash check will catch it.

ACKs for top commit:
  MarcoFalke:
    ACK cd68594dcdadc195bd2ea9394fa04edfdbdf1149
  laanwj:
    ACK cd68594dcdadc195bd2ea9394fa04edfdbdf1149
  promag:
    ACK cd68594dcdadc195bd2ea9394fa04edfdbdf1149, AFAICT the check is not needed, hash comparison gives data integrity.

Tree-SHA512: 5b2e719f76097cfbf125392db6cc6c764355c81f0b7a5b60aee4b06af1afcca80cfd38a3cf5307fd9e2c1afc405f8321929a4552943099a8161e6762965451fb

2019-10-23 12:05:37 +02:00

..

test

Merge #16786: test: add unit test for wallet watch-only methods involving PubKeys

2019-10-10 12:12:54 -04:00

coincontrol.cpp

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coincontrol.h

extract min & max depth onto coin control

2019-07-22 15:23:21 -04:00

coinselection.cpp

Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection

2018-12-12 14:22:12 -08:00

coinselection.h

amount: Move CAmount CENT to unit test header

2018-09-17 14:34:56 -04:00

crypter.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

crypter.h

Remove unused includes

2019-10-15 22:56:43 +00:00

db.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

db.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

feebumper.cpp

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

feebumper.h

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

Remove uses of fee globals in wallet code

2019-02-22 15:43:02 -04:00

init.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

ismine.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

ismine.h

Change ismine to take a CWallet instead of CKeyStore

2019-06-19 18:06:30 -04:00

load.cpp

wallet: Avoid showing GUI popups on RPC errors

2019-10-08 13:02:14 -04:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

psbtwallet.cpp

Merge #15427: Add support for descriptors to utxoupdatepsbt

2019-07-02 16:53:22 +02:00

psbtwallet.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcdump.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

rpcwallet.cpp

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

rpcwallet.h

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

wallet.cpp

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

wallet.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

walletdb.cpp

Merge #16911: wallet: Only check the hash of transactions loaded from disk

2019-10-23 12:05:37 +02:00

walletdb.h

Merge #17070: wallet: Avoid showing GUI popups on RPC errors

2019-10-21 13:48:27 +02:00

wallettool.cpp

scripted-diff: Replace fprintf with tfm::format

2019-06-13 10:32:52 -04:00

wallettool.h

Remove unused includes

2019-10-15 22:56:43 +00:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

wallet: Add WalletLocation utility class

2018-10-25 11:53:17 +01:00