Wladimir J. van der Laan fad42e8c4a

Merge #13547: Make signrawtransaction* give an error when amount is needed but missing ...

685d1d8115f61b15115d80523dd8273f0a816534 [tests] Check signrawtransaction* errors on missing prevtx info (Anthony Towns)
a3b065b51fb333d976108a1fe34b7f663fd67285 Error on missing amount in signrawtransaction* (Anthony Towns)

Pull request description:

  Signatures using segregated witness commit to the amount being spent, so that value must be passed into signrawtransactionwithkey and signrawtransactionwithwallet. This ensures an error is issued if that doesn't happen, rather than just assuming the value is 0 and producing a signature that is almost certainly invalid.

  Based on Ben Woosley's #12458, Fixes: #12429.

Tree-SHA512: 8e2ff89d5bcf79548e569210af0d850028bc98d86c149b92207c9300ab1d63664a7e2b222c1be403a15941aa5cf36ccc3c0d570ee1c1466f3496b4fe06c17e11

2018-07-10 17:04:11 +02:00

..

blockchain.cpp

cleanup: avoid hidden copies in range-for loops

2018-06-15 13:40:00 -04:00

blockchain.h

Drop the chain argument to GetDifficulty

2018-05-20 22:19:42 -07:00

client.cpp

Merge #13060: [wallet] [rpc] Remove getlabeladdress RPC

2018-06-11 15:21:24 +02:00

client.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

mining.cpp

Break circular dependency: init -> * -> init by extracting shutdown.h

2018-06-25 00:08:49 -04:00

mining.h

scripted-diff: Replace #include "" with #include <> (ryanofsky)

2017-11-16 08:23:01 +13:00

misc.cpp

Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h

2018-07-04 15:34:03 +02:00

net.cpp

scripted-diff: Avoid temporary copies when looping over std::map

2018-06-11 13:12:55 -07:00

protocol.cpp

scripted-diff: Use UniValue.pushKV instead of push_back(Pair())

2018-02-10 10:05:07 -05:00

protocol.h

rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section

2018-04-27 09:19:09 +02:00

rawtransaction.cpp

Merge #13547: Make signrawtransaction* give an error when amount is needed but missing

2018-07-10 17:04:11 +02:00

rawtransaction.h

Declare CMutableTransaction a struct in rawtransaction.h

2018-02-20 14:16:37 -08:00

register.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

server.cpp

Break circular dependency: init -> * -> init by extracting shutdown.h

2018-06-25 00:08:49 -04:00

server.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

util.cpp

Merge #12542: Remove redundant includes. Conform to header include guidelines.

2018-03-16 16:59:27 -07:00

util.h

Remove redundant includes. Conform to header include guidelines.

2018-02-27 22:30:40 +01:00