cryptogera/dogecoin
1
0
Fork 0
mirror of https://github.com/dogecoin/dogecoin.git synced 2026-02-16 18:28:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
dogecoin/src
History
Wladimir J. van der Laan 9efa55c715
Merge #20130: Wallet: remove db mode string 
135afa749c6e835ea33b8678cdb35da9640eede8 wallet: remove db mode string (Ivan Metlushko)

Pull request description:

  This is a [follow-up](https://github.com/bitcoin/bitcoin/pull/19077#discussion_r500261927) for #19077

  This PR simplifies DB interface by removing mode string from `WalletDatabase` and `WalletBatch`.

  The mode string was used to determine two flags for the instantiation of db connection:
  1) read-only flag. Never used on connection level. And on batch level Is only used within `BerkeleyDatabase::Rewrite` where it's replaced with bool flag.
  2) create flag. Is not required as we always check `require_existing` & `require_create` flags in `MakeDatabase()` before creating actual database instance. So we can safely default to always creating database if it doesn't exist yet.

ACKs for top commit:
  achow101:
    ACK 135afa749c6e835ea33b8678cdb35da9640eede8
  laanwj:
    Code review ACK 135afa749c6e835ea33b8678cdb35da9640eede8

Tree-SHA512: f49c07c7387c02e517a58199620a678a918f8dfc20d1347d29fd6adea0bc89698c26cb8eef42b0977961c11c207c4bbe109bc31059f47c126cc600b01fd987eb
2020-10-14 14:50:22 +02:00
..
bench
[validation] Remove absurdfee from accepttomempool
2020-10-05 04:55:01 -07:00
compat
net: Use C++11 member initialization in protocol
2020-05-20 08:27:07 -04:00
config
…
consensus
add signet basic support (signet.cpp)
2020-09-10 10:47:40 +09:00
crc32c
Import crc32c using subtree merge as as 'src/crc32c'
2020-01-28 17:00:01 +01:00
crypto
Merge #19845: net: CNetAddr: add support to (un)serialize as ADDRv2
2020-09-28 12:27:08 -07:00
index
Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB
2020-08-21 12:48:46 +08:00
interfaces
[send] Make send RPCs return fee reason
2020-09-26 17:57:26 -07:00
leveldb
Update to leveldb upstream using subtree merge
2020-01-28 16:59:07 +01:00
logging
Remove use of non-standard zero variadic macros
2020-04-30 18:02:04 +08:00
node
style and nits for fee-checking in BroadcastTransaction
2020-10-08 14:11:16 -07:00
policy
policy/fees: remove a floating-point division by zero
2020-09-14 16:23:23 +02:00
primitives
net: CNetAddr: add support to (un)serialize as ADDRv2
2020-09-17 22:17:17 +02:00
qt
gui: Fix SplashScreen crash when run with -disablewallet
2020-10-09 21:14:47 +03:00
rpc
Merge #19339: validation: re-delegate absurd fee checking from mempool to clients
2020-10-07 10:58:30 +08:00
script
Merge #20006: Fix misleading error message: Clean stack rule
2020-09-30 14:21:42 +02:00
secp256k1
Update src/secp256k1 subtree to upstream libsecp256k1
2020-09-11 12:44:08 -07:00
support
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
test
Merge #20129: tests: don't export in6addr_loopback
2020-10-14 10:33:55 +02:00
univalue
Update univalue subtree
2020-02-09 07:44:29 -08:00
util
Merge #20092: util: Do not use gArgs global in ArgsManager member functions
2020-10-07 09:31:12 +02:00
wallet
wallet: remove db mode string
2020-10-13 18:42:59 +07:00
zmq
zmq: Append address to notify log output
2020-10-01 00:33:38 +02:00
.clang-format
tools: clang-format 6 compatibility
2020-07-06 03:52:37 +02:00
addrdb.cpp
refactor: Use uint16_t instead of unsigned short
2020-06-22 12:12:22 +02:00
addrdb.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
net: CAddress & CAddrMan: (un)serialize as ADDRv2
2020-10-09 16:42:49 +02:00
amount.h
…
arith_uint256.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
arith_uint256.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
attributes.h
…
banman.cpp
banlist: log post-swept banlist size at startup
2020-07-08 21:44:45 +08:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
base58.h
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
rpc: Set HTTP Content-Type in bitcoin-cli
2020-10-01 17:33:56 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted diff: Improve invalid vout value rpc error message
2020-09-30 20:43:05 +03:30
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
doc: Update comments for new chain settings (-signet and -chain=signet)
2020-09-22 22:32:25 +02:00
bitcoind-res.rc
…
bitcoind.cpp
doc: Update comments for new chain settings (-signet and -chain=signet)
2020-09-22 22:32:25 +02:00
blockencodings.cpp
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockencodings.h
Get rid of -Wthread-safety-precise warnings
2020-05-28 09:55:39 +03:00
blockfilter.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
blockfilter.h
[indexes] Fix default [de]serialization of BlockFilter.
2020-05-26 17:27:15 -04:00
bloom.cpp
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
bloom.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
chain.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
signet: do not log signet startup messages for other chains
2020-10-01 11:25:42 +02:00
chainparams.h
Remove gArgs global from CreateChainParams to aid testing
2020-09-29 10:20:05 +02:00
chainparamsbase.cpp
net: Add alternative port for onion service
2020-09-29 09:59:51 +03:00
chainparamsbase.h
net, refactor: Refactor CBaseChainParams::RPCPort function
2020-09-29 09:59:52 +03:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.20
2020-04-03 16:29:26 +02:00
checkqueue.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
clientversion.cpp
Drop unused GIT_COMMIT_DATE macro
2020-05-04 19:53:58 +03:00
clientversion.h
…
coins.cpp
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
coins.h
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
compat.h
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
compressor.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
compressor.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
core_io.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
core_memusage.h
…
core_read.cpp
refactor: Replace const char* to std::string
2020-05-22 01:40:31 +09:00
core_write.cpp
refactor: Avoid duplicate map lookup in ScriptToAsmStr
2020-09-04 10:25:44 +01:00
cuckoocache.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
2020-04-08 14:45:27 +00:00
dbwrapper.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
dbwrapper.h
Drop unused CDBWrapper methods
2020-07-08 14:26:14 +03:00
dummywallet.cpp
Merge #19671: wallet: Remove -zapwallettxes
2020-09-01 09:26:28 +08:00
flatfile.cpp
…
flatfile.h
Merge #18317: Serialization improvements step 6 (all except wallet/gui)
2020-05-20 07:30:29 -04:00
fs.cpp
Add missing includes to fix compile errors
2020-06-16 15:15:46 -04:00
fs.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
hash.cpp
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
hash.h
Add SHA256Uint256 helper functions
2020-08-06 16:28:26 -07:00
httprpc.cpp
Merge #18740: Remove g_rpc_node global
2020-05-21 06:53:39 -04:00
httprpc.h
refactor: Pass NodeContext to RPC and REST methods through util::Ref
2020-05-13 16:20:13 -04:00
httpserver.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
httpserver.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
indirectmap.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
Merge #19991: net: Use alternative port for incoming Tor connections
2020-10-02 13:37:23 +02:00
init.h
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
key_io.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
key_io.h
…
key.cpp
tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_export_der(...)
2020-08-18 18:03:57 +00:00
key.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
limitedmap.h
…
logging.cpp
log: remove deprecated db log category
2020-06-07 17:03:49 +02:00
logging.h
refactor: Rename LockGuard to StdLockGuard for consistency with StdMutex
2020-05-28 09:54:24 +03:00
Makefile.am
Merge #18267: BIP-325: Signet [consensus]
2020-09-21 22:33:00 +02:00
Makefile.bench.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.crc32c.include
build: CRC32C build system integration
2020-01-28 17:01:48 +01:00
Makefile.leveldb.include
build: Enable -Wsuggest-override
2020-05-12 18:03:39 +03:00
Makefile.qt_locale.include
qt: Periodic translations update
2020-10-01 22:24:08 +02:00
Makefile.qt.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.qttest.include
build: split PTHREAD_* flags out of AM_LDFLAGS
2020-09-14 16:35:09 +08:00
Makefile.test_fuzz.include
build: create test_fuzz library from src/test/fuzz/fuzz.cpp
2020-04-05 01:01:13 +02:00
Makefile.test_util.include
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
Makefile.test.include
Merge #18267: BIP-325: Signet [consensus]
2020-09-21 22:33:00 +02:00
memusage.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
merkleblock.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
merkleblock.h
Convert merkleblock to new serialization
2020-03-30 16:09:51 -07:00
miner.cpp
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
miner.h
Remove mapLinks in favor of entry inlined structs with iterator type erasure
2020-09-04 09:46:44 -07:00
net_permissions.cpp
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_permissions.h
Add addr permission flag enabling non-cached addr sharing
2020-07-30 14:38:50 +03:00
net_processing.cpp
Only relay IPv4, IPv6, Tor addresses
2020-10-11 11:29:11 -07:00
net_processing.h
Merge #19498: Tidy up ProcessOrphanTx
2020-09-30 15:53:25 +02:00
net_types.h
…
net.cpp
net: Add CNode::ConnectedThroughNetwork member function
2020-10-03 15:38:19 +03:00
net.h
Merge #19998: net: Add CNode::ConnectedThroughNetwork member function
2020-10-12 18:40:45 +02:00
netaddress.cpp
Merge #19998: net: Add CNode::ConnectedThroughNetwork member function
2020-10-12 18:40:45 +02:00
netaddress.h
Merge #19998: net: Add CNode::ConnectedThroughNetwork member function
2020-10-12 18:40:45 +02:00
netbase.cpp
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.h
net: Avoid using C-style NUL-terminated strings as arguments in the netbase interface
2020-01-08 12:35:59 +00:00
netmessagemaker.h
refactor: s/command/msg_type/ in CNetMsgMaker and CSerializedNetMsg
2020-05-11 00:20:57 +02:00
noui.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
noui.h
Make ThreadSafe{MessageBox|Question} bilingual
2020-05-05 04:45:59 +03:00
optional.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
outputtype.cpp
Enable Wswitch for OutputType
2020-07-01 18:03:12 -04:00
outputtype.h
Remove confusing OutputType::CHANGE_AUTO
2020-07-01 18:02:38 -04:00
pow.cpp
…
pow.h
…
prevector.h
prevector: Avoid unnamed struct, which is a GNU extension
2020-04-30 18:02:03 +08:00
protocol.cpp
net: advertise support for ADDRv2 via new message
2020-10-09 16:42:50 +02:00
protocol.h
net: advertise support for ADDRv2 via new message
2020-10-09 16:42:50 +02:00
psbt.cpp
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
psbt.h
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
pubkey.cpp
tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)
2020-08-18 18:03:56 +00:00
pubkey.h
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
Add templated GetRandomDuration<>
2020-04-30 09:19:14 -04:00
randomenv.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
randomenv.h
[MOVEONLY] Move perfmon data gathering to new randomenv module
2019-11-12 14:50:44 -08:00
rest.cpp
Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)
2020-09-22 17:08:08 +02:00
reverse_iterator.h
…
scheduler.cpp
clang-format scheduler
2020-06-21 06:02:59 -04:00
scheduler.h
clang-format scheduler
2020-06-21 06:02:59 -04:00
serialize.h
Support bypassing range check in ReadCompactSize
2020-10-09 10:32:19 +02:00
shutdown.cpp
…
shutdown.h
…
signet.cpp
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
signet.h
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
span.h
Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2020-07-30 13:57:09 -07:00
streams.h
net: CAddress & CAddrMan: (un)serialize as ADDRv2
2020-10-09 16:42:49 +02:00
sync.cpp
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
sync.h
Remove unused LockAssertion struct
2020-09-19 18:02:42 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
threadsafety.h
Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
2020-08-18 10:46:53 +03:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
util: Update tinyformat to upstream
2019-12-06 10:02:08 +01:00
torcontrol.cpp
Merge #19954: Complete the BIP155 implementation and upgrade to TORv3
2020-10-11 08:51:57 +08:00
torcontrol.h
net: Pass onion service target to Tor controller
2020-10-01 19:00:07 +03:00
txdb.cpp
Merge #18637: coins: allow cache resize after init
2020-07-29 07:53:19 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
txmempool.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
uint256.cpp
uint256: Update constructors to c++11, make ONE static
2020-09-28 12:14:19 +10:00
uint256.h
scripted-diff: Replace UINT256_ONE() with uint256::ONE
2020-09-28 12:14:19 +10:00
undo.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
validation.cpp
[validation] Remove absurdfee from accepttomempool
2020-10-05 04:55:01 -07:00
validation.h
[validation] Remove absurdfee from accepttomempool
2020-10-05 04:55:01 -07:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
net: CNetAddr: add support to (un)serialize as ADDRv2
2020-09-17 22:17:17 +02:00
versionbits.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbits.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
warnings.cpp
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00
warnings.h
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00