cryptogera/dogecoin
1
0
Fork 0
mirror of https://github.com/dogecoin/dogecoin.git synced 2026-02-13 00:38:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
dogecoin/src/rpc
History
Wladimir J. van der Laan 11de669d8b
Merge #16325: rpc: Clarify that block count means height excl genesis 
fab0c820fa4c0c3227eec85c64310a3bf938a149 rpc: Clarify that block count means height excl genesis (MarcoFalke)

Pull request description:

  There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block. See for example the discussion in https://github.com/bitcoin/bitcoin/pull/16292#issuecomment-506303256.

  However, it really returns the height, which is `0` for the genesis block.

  So clarify that and also remove the misleading "longest blockchain" comment.

  Finally, fix the wallet test that incorrectly used this rpc.

ACKs for top commit:
  instagibbs:
    utACK fab0c820fa
  promag:
    ACK fab0c82, sorry for the misconception.

Tree-SHA512: 0d087cbb628d3866352bca6420402f392e6a997e579941701a408a7fca355d84645045661f39b022e4479cc07f85a6cddaa9095b6fd9911b245692482420a5e4
2019-07-03 14:49:40 +02:00
..
blockchain.cpp
rpc: Clarify that block count means height excl genesis
2019-07-02 12:28:21 -04:00
blockchain.h
rpc: Add lock annotations to block{,header}ToJSON
2019-05-02 14:33:26 -04:00
client.cpp
wallet/rpc: add 'avoid_reuse' option to RPC commands
2019-05-29 18:40:31 +09:00
client.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
mining.cpp
Merge #16262: rpc: Allow shutdown while in generateblocks
2019-07-03 12:31:15 +02:00
misc.cpp
Merge #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address
2019-06-21 19:44:08 +12:00
net.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
protocol.cpp
Make reasoning about dependencies easier by not including unused dependencies
2019-06-02 17:15:23 +02:00
protocol.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
rawtransaction_util.cpp
signrawtransactionwithkey: report error when missing redeemScript/witnessScript param
2019-06-25 12:37:08 +10:00
rawtransaction_util.h
rpc: Remove dependency on interfaces::Chain in SignTransaction
2019-04-17 08:17:17 -04:00
rawtransaction.cpp
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00
register.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
server.cpp
Merge #15483: rpc: Adding a 'logpath' entry to getrpcinfo
2019-07-03 14:35:58 +02:00
server.h
[build] Move rpc utility methods to rpc/util
2019-04-09 17:53:08 -04:00
util.cpp
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00
util.h
Merge #15427: Add support for descriptors to utxoupdatepsbt
2019-07-02 16:53:22 +02:00