cryptogera/dogecoin
1
0
Fork 0
mirror of https://github.com/dogecoin/dogecoin.git synced 2026-02-14 01:08:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
dogecoin/src/wallet
History
MarcoFalke 13a7454fbd
Merge #14380: fix assert crash when specified change output spend size is unknown 
0fb2e69815 CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change (Gregory Sanders)
b06483c96a Remove stale comment in CalculateMaximumSignedInputSize (Gregory Sanders)

Pull request description:

  This is triggered anytime a fundraw type call(psbt or legacy) is used with a change output address that the wallet doesn't know how to sign for.

  This regression was added in 6a34ff5335786615771ca423134a484b04831c4e since BnB coin selection actually cares about this.

  The fix is to assume the smallest typical spend, a P2SH-P2WPKH, which is calculated using a "prototype" dummy signature flow. Future work could generalize this infrastructure to get estimated sizes of inputs for a variety of types.

  I also removed a comment which I believe is stale and misleading.

Tree-SHA512: c7e2be189e524f81a7aa4454ad9370cefba715e3781f1e462c8bab77e4d27540191419029e3ebda11e3744c0703271e479dcd560d05e4d470048d9633e34da16
2018-11-30 10:49:49 -05:00
..
test
CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
2018-11-12 13:12:09 -05:00
coincontrol.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
coincontrol.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
coinselection.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
coinselection.h
amount: Move CAmount CENT to unit test header
2018-09-17 14:34:56 -04:00
crypter.cpp
Merge #14478: Show error to user when corrupt wallet unlock fails
2018-11-14 11:27:01 -05:00
crypter.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
db.cpp
wallet: Create IsDatabaseLoaded function
2018-11-08 11:54:37 +08:00
db.h
wallet: Create IsDatabaseLoaded function
2018-11-08 11:54:37 +08:00
feebumper.cpp
Pass chain locked variables where needed
2018-11-06 11:44:40 -04:00
feebumper.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
fees.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
fees.h
Update copyright headers to 2018
2018-07-27 07:15:02 -04:00
init.cpp
Remove direct node->wallet calls in init.cpp
2018-11-06 11:44:40 -04:00
rpcdump.cpp
Use RPCHelpMan for all RPCs
2018-11-14 15:33:15 -05:00
rpcwallet.cpp
Merge #14477: Add ability to convert solvability info to descriptor
2018-11-27 12:22:41 -08:00
rpcwallet.h
Simplify arguments to SignPSBTInput
2018-11-01 12:11:24 -07:00
wallet.cpp
Merge #14380: fix assert crash when specified change output spend size is unknown
2018-11-30 10:49:49 -05:00
wallet.h
CreateTransaction: Assume minimum p2sh-p2wpkh spend size for unknown change
2018-11-12 13:12:09 -05:00
walletdb.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
walletdb.h
[wallet] Kill accounts
2018-08-30 16:08:42 +02:00
walletutil.cpp
Merge #14350: Add WalletLocation class
2018-11-05 13:17:03 +01:00
walletutil.h
wallet: Add WalletLocation utility class
2018-10-25 11:53:17 +01:00