MarcoFalke a822a0e4f6
Merge #15999: init: Remove dead code in LoadChainTip
fa86c8aec6 init: Remove dead code in LoadChainTip (MarcoFalke)

Pull request description:

  `LoadChainTip` sets `::ChainActive()` based on `pcoinsTip`'s best block. `LoadChainTip` is never called when that block is null, so we can remove all code from within that method that is only executed when that block is null.

  Fixes #15967  Inconsistent locking behavior in LoadChainTip

ACKs for commit fa86c8:
  promag:
    utACK fa86c8aec611a9b9d2f53960c92419cf2a8bb92d.
  practicalswift:
    utACK fa86c8aec611a9b9d2f53960c92419cf2a8bb92d
  Empact:
    utACK fa86c8aec6
  laanwj:
    utACK fa86c8aec611a9b9d2f53960c92419cf2a8bb92d
  ryanofsky:
    utACK fa86c8aec611a9b9d2f53960c92419cf2a8bb92d. LoadChainTip isn't called currently when pcoinsTip best block is null due to this line:
  jamesob:
    utACK fa86c8aec6

Tree-SHA512: 8961c0e579800a52038ac5655478468852faac055299b64d6cfdf0c213d3bf09669c4889467d09d93457f6c8b073967bb0475a137f77ddd3a3a3c03ad90001c4
2019-05-17 07:22:52 -04:00
..
2019-01-26 12:45:48 -05:00
2018-09-07 08:21:14 -04:00
2019-05-07 00:17:33 +00:00
2019-01-16 13:54:18 -05:00
2018-12-29 10:15:01 +01:00
2018-08-13 13:57:15 +02:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2019-02-22 17:38:45 -08:00
2019-02-22 17:38:45 -08:00
2019-04-10 12:16:52 +01:00
2018-08-11 09:34:47 +03:00
2019-04-09 17:53:08 -04:00
2018-07-27 07:15:02 -04:00
2019-03-27 13:59:50 +01:00
2019-03-27 13:59:50 +01:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2019-04-10 11:48:47 -04:00
2019-01-24 15:58:49 -08:00
2018-07-27 07:15:02 -04:00
2018-12-29 10:15:01 +01:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2019-05-03 20:31:18 +02:00
2018-07-27 11:52:18 -07:00
2018-07-27 07:15:02 -04:00
2018-03-21 08:34:44 +02:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00