b37b7e655b
The algorithm here is important and took some time to get right. Instead of comparing whether the current number of connected nodes minus the number of unevictable nodes is greater than the number of max connections, check that: * there are any evictable nodes (connected nodes minus unevictable nodes) * there are more nodes connected than requested (connected nodes minus max connections) While we could wait for nodes to disconnect organically, it's more important to run the eviction logic frequently enough that we can tell when it will have an effect. Whitelisted connections and protected inbound connections are unevictable, and max connections should account for inbound connections. Because the evictor will never evict protected inbound connections, the maximum connection count should always be at least as large as the protected connection count. Note that the tests for this use a delay and test that the delay has not expired. This helps improve determinism in the testing. Otherwise, a strict test for a fixed number of disconnections is susceptible to things like CPU jitter, especially when running through CI. Patrick ran this test for 1000 runs on busy CPUs and saw no failures.
The pull-tester folder contains a script to call multiple tests from the rpc-tests folder.
Every pull request to the dogecoin repository is built and run through the regression test suite. You can also run all or only individual tests locally.
Test dependencies
Before running the tests, the following must be installed.
Unix
python3-zmq and ltc_scrypt are required. On Ubuntu or Debian they can be installed via:
sudo apt-get update && apt-get install -y curl python3-zmq python3-dev gcc
cd qa/pull-tester/ && ./install-deps.sh
OS X
brew install curl
pip3 install pyzmq
cd qa/pull-tester && ./install-deps.sh
Running tests
You can run any single test by calling
qa/pull-tester/rpc-tests.py <testname>
Or you can run any combination of tests by calling
qa/pull-tester/rpc-tests.py <testname1> <testname2> <testname3> ...
Run the regression test suite with
qa/pull-tester/rpc-tests.py
Run all possible tests with
qa/pull-tester/rpc-tests.py -extended
By default, tests will be run in parallel. To specify how many jobs to run,
append -parallel=n (default n=4).
If you want to create a basic coverage report for the rpc test suite, append --coverage.
Possible options, which apply to each individual test run:
-h, --help show this help message and exit
--nocleanup Leave bitcoinds and test.* datadir on exit or error
--noshutdown Don't stop bitcoinds after the test execution
--srcdir=SRCDIR Source directory containing bitcoind/bitcoin-cli
(default: ../../src)
--tmpdir=TMPDIR Root directory for datadirs
--tracerpc Print out all RPC calls as they are made
--coveragedir=COVERAGEDIR
Write tested RPC commands into this directory
If you set the environment variable PYTHON_DEBUG=1 you will get some debug
output (example: PYTHON_DEBUG=1 qa/pull-tester/rpc-tests.py wallet).
A 200-block -regtest blockchain and wallets for four nodes is created the first time a regression test is run and is stored in the cache/ directory. Each node has 25 mature blocks (25*50=1250 BTC) in its wallet.
After the first run, the cache/ blockchain and wallets are copied into a temporary directory and used as the initial test state.
If you get into a bad state, you should be able to recover with:
rm -rf cache
killall dogecoind
Writing tests
You are encouraged to write tests for new or existing features. Further information about the test framework and individual rpc tests is found in qa/rpc-tests.