MarcoFalke 62d137ac3b

Merge #19561: refactor: Pass ArgsManager into functions that register args ...

8ed9002cd14165f751442f738fbf1fb8a37611b2 refactor: use local argsmanager in CRegTestParams (Ivan Metlushko)
9b20f6682845870d6ac53a01d3166fb83c467e7d scripted-diff: Replace gArgs with local argsman (Ivan Metlushko)
a316e9ce265212a7c6c4ef7922420f6ecba9e7b0 refactor: add unused ArgsManager to replace gArgs (Ivan Metlushko)

Pull request description:

  Rationale: reduce use of gArgs to decouple code and simplify future maintenance and easier unit testing.

  This PR is continuation of work started in  #18926 and #18662
  It covers only places that register args in ArgsManager with `AddArgs()` or `AddHiddenArgs()`.

  Closes #19511

ACKs for top commit:
  MarcoFalke:
    ACK 8ed9002cd14165f751442f738fbf1fb8a37611b2 👛

Tree-SHA512: 7e6ba8e8357a48833c71e9c3942a769acb3d93bdcc6748a8ef2b7c4461a2499419b60896abf1d8b6bf8e88ee2590284cdd5da64220243ac22375300bcb8fe3e8

2020-07-30 17:08:46 +02:00

..

test

Merge #19370: Static asserts for consistency of fee defaults

2020-07-22 19:25:07 +02:00

bdb.cpp

walletdb: Ensure that having no database handle is a failure

2020-07-29 12:30:24 -04:00

bdb.h

Remove BDB dummy databases

2020-07-29 12:30:23 -04:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

Introduce DummyDatabase and use it in the tests

2020-07-29 12:28:30 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Replace gArgs with local argsman

2020-07-29 16:39:00 +07:00

ismine.h

…

load.cpp

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

load.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

rpcdump.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

rpcwallet.cpp

Merge #18202: refactor: consolidate sendmany and sendtoaddress code

2020-07-12 14:42:35 +12:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

walletdb: Don't remove database transaction logs and instead error

2020-07-13 11:00:54 -04:00

salvage.h

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

scriptpubkeyman.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

scriptpubkeyman.h

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

wallet.cpp

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

wallet.h

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

walletdb.cpp

Introduce DummyDatabase and use it in the tests

2020-07-29 12:28:30 -04:00

walletdb.h

walletdb: Introduce WalletDatabase abstract class

2020-07-14 11:07:16 -04:00

wallettool.cpp

walletdb: Move BerkeleyDatabase::Flush(true) to Close()

2020-07-14 11:07:16 -04:00

wallettool.h

…

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00