Wladimir J. van der Laan 1dfe19e284

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet ...

538be4219ae7e65862e4aff540af88c9421e6061 wallet: fix importdescriptor silent fail (Ivan Metlushko)

Pull request description:

  Currently `importdescriptor` command will successfully import a descriptor with hardened derivations into a watch-only wallet while silently failing to expand the descriptor to fill the cache. This leads to a broken wallet state and failure to load such wallet due to missing cache on subsequent restart.

ACKs for top commit:
  laanwj:
    Code review ACK 538be4219ae7e65862e4aff540af88c9421e6061
  achow101:
    ACK 538be4219ae7e65862e4aff540af88c9421e6061
  meshcollider:
    utACK 538be4219ae7e65862e4aff540af88c9421e6061

Tree-SHA512: 4bdd0ab4437d55b3f1a79c3a300a0b186089155c020fe220a73d0cce274de47d90371d88918d39fd795f9fccf8db328f1e322d29a6062f9ce94a1c254398f004

2020-11-09 20:19:00 +01:00

..

test

[send] Make send RPCs return fee reason

2020-09-26 17:57:26 -07:00

bdb.cpp

Determine wallet file type based on file magic

2020-10-14 11:28:18 -04:00

bdb.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

coinselection.h

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

refactor: Pass wallet database into CWallet::Create

2020-09-03 12:24:32 -04:00

db.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

feebumper.cpp

[send] Make send RPCs return fee reason

2020-09-26 17:57:26 -07:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

wallet: Make -wallet setting not create wallets

2020-10-21 08:48:43 -04:00

ismine.h

…

load.cpp

Ignoring (but warn) on duplicate -wallet parameters

2020-11-03 12:06:32 +01:00

load.h

Do not create default wallet

2020-09-08 21:02:53 -04:00

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

Merge #20220: wallet, rpc: explicit fee rate follow-ups/fixes for 0.21

2020-11-04 16:35:23 +13:00

rpcwallet.h

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

2020-09-22 20:49:30 +02:00

salvage.cpp

wallet: Remove path checking code from bitcoin-wallet tool

2020-09-03 12:24:32 -04:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #19986: refactor: clean up -Wlogical-op warning in wallet/scriptpubkeyman.cp

2020-10-19 11:07:11 +08:00

scriptpubkeyman.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

sqlite.cpp

wallet: Set DatabaseStatus::SUCCESS in MakeSQLiteDatabase

2020-11-05 20:48:41 +01:00

sqlite.h

rpc, wallet: Expose database format in getwalletinfo

2020-10-14 21:47:42 +01:00

wallet.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

wallet.h

Fix change detection of imported internal descriptors

2020-10-29 17:55:13 -04:00

walletdb.cpp

Make sqlite support optional (compile-time)

2020-10-20 13:44:43 +00:00

walletdb.h

wallet: remove db mode string

2020-10-13 18:42:59 +07:00

wallettool.cpp

Show name, format and if uses descriptors in bitcoin-wallet tool

2020-10-21 13:28:15 +02:00

wallettool.h

wallet: Remove path checking code from bitcoin-wallet tool

2020-09-03 12:24:32 -04:00

walletutil.cpp

Make sqlite support optional (compile-time)

2020-10-20 13:44:43 +00:00

walletutil.h

Remove WalletLocation class

2020-09-03 12:24:32 -04:00